* [PATCH] mm: memcg: declare do_memsw_account inline
@ 2024-11-28 20:39 John Sperbeck
2024-11-28 22:48 ` Roman Gushchin
0 siblings, 1 reply; 2+ messages in thread
From: John Sperbeck @ 2024-11-28 20:39 UTC (permalink / raw)
To: Andrew Morton
Cc: Johannes Weiner, Michal Hocko, Roman Gushchin, Shakeel Butt,
Muchun Song, cgroups, linux-mm, linux-kernel, John Sperbeck
In commit 66d60c428b23 ("mm: memcg: move legacy memcg event code
into memcontrol-v1.c"), the static do_memsw_account() function was
moved from a .c file to a .h file. Unfortunately, the traditional
inline keyword wasn't added. If a file (e.g., a unit test) includes
the .h file, but doesn't refer to do_memsw_account(), it will get a
warning like:
mm/memcontrol-v1.h:41:13: warning: unused function 'do_memsw_account' [-Wunused-function]
41 | static bool do_memsw_account(void)
| ^~~~~~~~~~~~~~~~
Fixes: 66d60c428b23 ("mm: memcg: move legacy memcg event code into memcontrol-v1.c")
Signed-off-by: John Sperbeck <jsperbeck@google.com>
---
mm/memcontrol-v1.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memcontrol-v1.h b/mm/memcontrol-v1.h
index 0e3b82951d91..144d71b65907 100644
--- a/mm/memcontrol-v1.h
+++ b/mm/memcontrol-v1.h
@@ -38,7 +38,7 @@ void mem_cgroup_id_put_many(struct mem_cgroup *memcg, unsigned int n);
iter = mem_cgroup_iter(NULL, iter, NULL))
/* Whether legacy memory+swap accounting is active */
-static bool do_memsw_account(void)
+static inline bool do_memsw_account(void)
{
return !cgroup_subsys_on_dfl(memory_cgrp_subsys);
}
--
2.47.0.338.g60cca15819-goog
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] mm: memcg: declare do_memsw_account inline
2024-11-28 20:39 [PATCH] mm: memcg: declare do_memsw_account inline John Sperbeck
@ 2024-11-28 22:48 ` Roman Gushchin
0 siblings, 0 replies; 2+ messages in thread
From: Roman Gushchin @ 2024-11-28 22:48 UTC (permalink / raw)
To: John Sperbeck
Cc: Andrew Morton, Johannes Weiner, Michal Hocko, Shakeel Butt,
Muchun Song, cgroups, linux-mm, linux-kernel
On Thu, Nov 28, 2024 at 12:39:59PM -0800, John Sperbeck wrote:
> In commit 66d60c428b23 ("mm: memcg: move legacy memcg event code
> into memcontrol-v1.c"), the static do_memsw_account() function was
> moved from a .c file to a .h file. Unfortunately, the traditional
> inline keyword wasn't added. If a file (e.g., a unit test) includes
> the .h file, but doesn't refer to do_memsw_account(), it will get a
> warning like:
>
> mm/memcontrol-v1.h:41:13: warning: unused function 'do_memsw_account' [-Wunused-function]
> 41 | static bool do_memsw_account(void)
> | ^~~~~~~~~~~~~~~~
>
> Fixes: 66d60c428b23 ("mm: memcg: move legacy memcg event code into memcontrol-v1.c")
> Signed-off-by: John Sperbeck <jsperbeck@google.com>
Acked-by: Roman Gushchin <roman.gushchin@linux.dev>
Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-28 22:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-28 20:39 [PATCH] mm: memcg: declare do_memsw_account inline John Sperbeck
2024-11-28 22:48 ` Roman Gushchin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox