From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EBB5D70E01 for ; Thu, 28 Nov 2024 22:48:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 46C036B0083; Thu, 28 Nov 2024 17:48:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 41A886B0085; Thu, 28 Nov 2024 17:48:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 309F76B0088; Thu, 28 Nov 2024 17:48:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 11CD76B0083 for ; Thu, 28 Nov 2024 17:48:39 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6D6641C7791 for ; Thu, 28 Nov 2024 22:48:38 +0000 (UTC) X-FDA: 82836994422.06.D8BE446 Received: from out-184.mta1.migadu.com (out-184.mta1.migadu.com [95.215.58.184]) by imf14.hostedemail.com (Postfix) with ESMTP id 36FD9100008 for ; Thu, 28 Nov 2024 22:48:27 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=IkZP0iEo; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf14.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.184 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732834109; a=rsa-sha256; cv=none; b=S/RDz+j9/vN2yMfcOQFe35dQN5E4haALT+RflsqBhc3TA3QMlYvf0cxqBrj2UHUCgRSC6S S6kMbEcWdDtfg6kf735TI2P4oIYXsKVYyBuWJR0iJhcI081JBSEg+SQmP8fHu5CBjXOUK6 dcIunhwhIHNrd4xxntFs9g1yUaewNhg= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=IkZP0iEo; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf14.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.184 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732834109; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PLXpKhmby6MhlJ9I7MRFv11XFxLUBQGGDIGpiY97KKY=; b=GLxowv237VhaHBI4PoO3gRAGYgIWauqQ+1H/tHPWYtLER7LjqoBwRbf1AaR5ldFk3zsFvQ f+iVdxPqUpqaILsFo1bxz3Z3y3OimqnYbTLu7VG3tIS4P3ojo8hTYyYeOp6Gt5pTwSN+Gy vwEqW/v/gSydPGQWomam3OJCURcqJtE= Date: Thu, 28 Nov 2024 22:48:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1732834114; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PLXpKhmby6MhlJ9I7MRFv11XFxLUBQGGDIGpiY97KKY=; b=IkZP0iEo81kS3Xn2ZctYcc0GqBjl8YXcDaT0BE8wIsvu7s5jyvcZb3TvYt4W9BGN6+xJN/ nnmZkXEeSbV7rGV3wgMUsbzzB6G62LhlAGRrryTA6zVHrtkivlWW2TjdeXyL45SwJVCPTc anFcjv7qnqrhEv1nKiEejdhgYCpYHmw= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: John Sperbeck Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: memcg: declare do_memsw_account inline Message-ID: References: <20241128203959.726527-1-jsperbeck@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241128203959.726527-1-jsperbeck@google.com> X-Migadu-Flow: FLOW_OUT X-Stat-Signature: cfhhzj163fnhkpums71p1u961wx6es3y X-Rspam-User: X-Rspamd-Queue-Id: 36FD9100008 X-Rspamd-Server: rspam08 X-HE-Tag: 1732834107-516877 X-HE-Meta: U2FsdGVkX1/hTpWXVF5fpEyueMGwXSOLX3wcZflVZ8Gpei2EBSKsTd1v95SSAx9ziPWS3y6FML6W4Ex+ShJ5jPgCTAAPoCRf6mVYWTrld3P2DAENaoFE4GOVxJM73SXA1e8Zx7zl50qF/30ieQNhb7V4IWBDU/K6JdY9IkrjIQAWmxmr0xSO7uhEgBCjh2igyiyjwJOfLvrUEqK/N22InguhzuUUToqbBZyr7IglN7p0Xxktpwz8SM+aw43yA62iB11ihRKIWLqjiauWfiKpofxrabZfGdoCsIFrv0pLrvawMebLJmn+AhtmfZJJnJvi5+EaUOL1/Xd20v9LWWI8sXAaa+T49WN8VYOeWig6ootn7Vs0UY+LgSJa/fzqoPWbNb36YJW036rMTd0wevBmDY3Vukq0wf0u8aMM4u5aD69HZ4V1TvzJ7TR8AjFxWYJkhwarMgysSl98lD+PaSIRlGxluCVhiHTKRJcTjFgGho+Rtt1PR21iBWUNVciZ84dt6ZqYnszn7VBtd3IDKEYb0tuTSGWdARKtdhI5eFBiNWt80xhYyVdETraF7gam1/f9KkqMyg5K0LcXz0PVZOKyuZkRrYz1CslDPgq08D5Bzq2uluVbxLiRT+T4GG6gCWlY8E3hy1UQqAyweQAcDNCLPpBtfR/+u8209f1nw5S9Zqr86lyl7KTC18UYdMqEDz/PWT8KbGACPnBtks+soPe2nWwnZtRUxSxJ5zlnHngzsaICnwRkwPC/bbWA0bKKKReoG7yD7u0Hvk6ejQZ/XVYZTFIUBAYV+2SLfdKUVRCn0ltM8l055rpJITUTkbMhr2mrfplKgpM95Q+gjLfWgEEvH75wOJce4werFa8mOMMSVR5QVn80smKVc/2BwIHkHRHvt6smt4p2QvUw/KEmHzDka8XN5xcrqeceLJo0lxzFoUW0TU5e5DHQMcmV6sX1QoR3G4tn3ISYCdv163jQeAd rUlws49G FelsA0qyZQty7m2CpE25emtML/VOClMi21Rdt2vaN/w4j19VMydwe3HDt3FAELUAxq1nesTq7zkBmDu4r9hKy0+pCLRz1BRKQFi6ReILexr3xSWCsGTxalXxskPFApPMj/geHdW7mmesPMN2zCOp4kq/uCJ8zNLbndL8pd+61rai9FuRIBR2yPGNkYVcTPp1O6LO9OWroOR4oySRzgr26KNah5BYts09GRyrG1ezpfg3Xr3T4yj2l5L6k8Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 28, 2024 at 12:39:59PM -0800, John Sperbeck wrote: > In commit 66d60c428b23 ("mm: memcg: move legacy memcg event code > into memcontrol-v1.c"), the static do_memsw_account() function was > moved from a .c file to a .h file. Unfortunately, the traditional > inline keyword wasn't added. If a file (e.g., a unit test) includes > the .h file, but doesn't refer to do_memsw_account(), it will get a > warning like: > > mm/memcontrol-v1.h:41:13: warning: unused function 'do_memsw_account' [-Wunused-function] > 41 | static bool do_memsw_account(void) > | ^~~~~~~~~~~~~~~~ > > Fixes: 66d60c428b23 ("mm: memcg: move legacy memcg event code into memcontrol-v1.c") > Signed-off-by: John Sperbeck Acked-by: Roman Gushchin Thanks!