From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8326DD70DEB for ; Thu, 28 Nov 2024 21:12:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8B4E6B0083; Thu, 28 Nov 2024 16:12:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C146C6B0085; Thu, 28 Nov 2024 16:12:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8D6E6B0088; Thu, 28 Nov 2024 16:12:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 88CA46B0083 for ; Thu, 28 Nov 2024 16:12:20 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4118A1A0917 for ; Thu, 28 Nov 2024 21:12:20 +0000 (UTC) X-FDA: 82836751872.05.BAED3CB Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) by imf25.hostedemail.com (Postfix) with ESMTP id D36D5A000C for ; Thu, 28 Nov 2024 21:12:12 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=SxqNqvgp; spf=pass (imf25.hostedemail.com: domain of david@fromorbit.com designates 209.85.215.177 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732828329; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gZQjgHCOdKGOLIMC8jx2ghuoSXfBYmvpjKyrW4dIslk=; b=DWQTGvJJWY7MzkNWUh2FqupD3CyQr+aKtcZ/w4QW2jisbnPHakifczn0VMA9wjeuML7lfs P8//Ogqi6YWUyhGqITt0VDFEZ23OOiuPJRLpaPH0Mc1ffxYVbQxpowcGxRDstJSiqHcqfp 3UfB7NBcGTNeK0ZLl05oLhRHZk9Go40= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=SxqNqvgp; spf=pass (imf25.hostedemail.com: domain of david@fromorbit.com designates 209.85.215.177 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732828329; a=rsa-sha256; cv=none; b=uKUwBz7QR+LzgsNMKfbT1ULQGfGxMp8yzRjup4iX0hsfDr40fBwAt+g4MK+inniKsFJrpB X/XBtYW0LeNabz5tOtYuaan68i+aFrtRgmZUGNkuhsVGQxCtH2Jkmj8xV2GbYz+ilVSDub 9n5FwpW2GmIQxzbbyh82KiY13g4Fnpc= Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-7ae3d7222d4so842090a12.3 for ; Thu, 28 Nov 2024 13:12:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1732828337; x=1733433137; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gZQjgHCOdKGOLIMC8jx2ghuoSXfBYmvpjKyrW4dIslk=; b=SxqNqvgprXaJtSAypqvMjeZxs2lyk/7ovlg3uZi0Rgz3kdbTOa/2tYlGLhIzC0zdPM eIKZkYM0ggg4cL2krrOpx/Gg4p6MqnaSJBNF5oY29WHYcHtjZW+BhjZcGtC5qY8Ti22p WAV/RAIXDZmKzR9UTs6ms0YLlT+tXUWjBwrTTyw1I3wR//3O5MW0EZF1qyPKFYCmcTMw xx6EKhg5dtx6lVnTHsZcARR3PL4InbZvRISKsT9NnIKhsyRPPk+eyrc8xMKOeQMn6trP vCJlh+mFy/QF+hk0mxe2r/vx4zohnI5ewFr/y4i/XfDBMao15L4Tv61ZvbdpEdWnv4Jb peVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732828337; x=1733433137; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gZQjgHCOdKGOLIMC8jx2ghuoSXfBYmvpjKyrW4dIslk=; b=o2mjlGBjo3I8SyHQvyd1LGrrw7VUkgtC4P9VG38vWultVO55QnGstcZBsGFe1Ok15Z puyhF52CwIiOotYAB13gSMCtxqT9s67WfdlgsdmzV9r9flPVUr/eIhDbWOlu0Osq7CiM sCVJrwuwO13tt5obNz6aHI63bmXOEa7+n0H1+I5HQBEHEWuLqcfXPaab15p7XzrW/4jg fJ8gNFm2MJm7+XNHlEUnQm8uQ+2Tqmx+Q+rVIeYQxhTiFjcSgAiGvBCHs6akxYhd1AcD T0Y+8copDhno8IJvbdWHX3yhlMbU5ynQW938vf3Nyf8LctHzsvEb0evNmauVFq8HuhZV cbMw== X-Forwarded-Encrypted: i=1; AJvYcCUjoFPiyC/rgrNWVcpRsB//HMjsxTyY0FHs82TWq+7vAIRmXuj9LgknIW9rw7ILb+tGy4w8YuZ85w==@kvack.org X-Gm-Message-State: AOJu0YystS8AYvgLeM1IpDuZ4bfVEagArytx7j75cfpS+zzITSDNxZYi tPDV/jcChyXLhdjfTmu0JHkARQ1hohOgiONQmR5V5moSRZ2XvoAhmnbMR1lmo4I= X-Gm-Gg: ASbGncuXnrwV5eqBl5KhYhI2s1Axxhwe8Raj8u7Ttg+uuTsyWzXkZshLVKonO/CUYnN 0D2O7vJR1JjHyiCXthIx2UN3A8w1eilCuDjo5HgCtBwKZ7acbk61cXVKSuFg/IxNcVi8v9KWJvJ tezYv/ccAoRaOB3Zi8P39xRAIh0YL0WAUKzsxIrNCEQI3Sop+Ltmo8HuhtdBac6OSfVwknD55MF KRc2X+q7N8nOUaIPWLj6uk3eu9Njax8tLDh312x/5OjYICjWqbYZG1RWIJyQNpS7ff3ZgGg9fTo 3sCQ1HZlxNy1P4k= X-Google-Smtp-Source: AGHT+IH6amO2slru4tjcta7Dz2nO85K3hdLLPHfnkg7IE2FAO0Bdpfqa+QOZGZFc1id6LQ57hv1jaA== X-Received: by 2002:a05:6a21:70cb:b0:1e0:c30a:6f22 with SMTP id adf61e73a8af0-1e0e0b8cdabmr12970905637.40.1732828336956; Thu, 28 Nov 2024 13:12:16 -0800 (PST) Received: from dread.disaster.area (pa49-180-121-96.pa.nsw.optusnet.com.au. [49.180.121.96]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72541761474sm2025702b3a.32.2024.11.28.13.12.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Nov 2024 13:12:16 -0800 (PST) Received: from dave by dread.disaster.area with local (Exim 4.98) (envelope-from ) id 1tGlo5-00000004Fmx-35VV; Fri, 29 Nov 2024 08:12:13 +1100 Date: Fri, 29 Nov 2024 08:12:13 +1100 From: Dave Chinner To: Alice Ryhl Cc: Andrew Morton , Johannes Weiner , Nhat Pham , Qi Zheng , Roman Gushchin , Muchun Song , Michal Hocko , Shakeel Butt , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] list_lru: expand list_lru_add() docs with info about sublists Message-ID: References: <20241128-list_lru_memcg_docs-v1-1-7e4568978f4e@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241128-list_lru_memcg_docs-v1-1-7e4568978f4e@google.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D36D5A000C X-Rspam-User: X-Stat-Signature: q1tqsfd49quxwgcm3o6fxyxgpdj94oi4 X-HE-Tag: 1732828332-616168 X-HE-Meta: U2FsdGVkX19R6aVLgUC+Tuc4Yua8BFCNnPoTag1LJ1HiJhykQsgGFr0rArCk6xVBEgCt744piI26N5Uy8SrxmVWRbR61KmCKqDMwrZX7kjalwKqp4dxwX+3rEVhrL5IblNl8XQF1kkQAYwXHon/sFnDpurBbRMZ/GKUoRFvHkKs3HhX6YVUpXnVgUjeRxMnu809skMHdGHfshl1Ju/CUiqfWuHGCYI0c47dEpe96rTKvBMoJw7eU/JADpYF+xL6EqSJAsvD7LtUpK7qXKYFLGFm8zg1+y5TtUXddPOJ3HoBIrxiWnW9U1TIRIz5JjiADa03ZgE4nNLMVqdipFMq2xnFu8ndukIo+xPH/6v2MZlKpE6zG8CohhLndskKn29MAocXnJMcDOF3mHLLaqpYhUGxaGmAyNQkaWMx+jae5TdCtAl64Dd5jRug6fCrgwa3HiT6o1vF1bFmRjaplZrnMOF0pJw2QJNCRjWwttvE4p21S8LF3cFqY9cTG5GqxQaAM43liP9k4ntjwCe1BnpYq+GvaPdSoP/XlyexjbHlci8u7wP7lP6H3lamLOq9NgmTQZjmlGYBOy38Xwiy2Z9NfMaaIz6rwsaE3BUFjggjFSpnZcpMiDVIR/LJDf2opvGkVucerYWVsmfVCI44AfBEsOGkhHSrxwJ46sl7UZCRx52LzVknGRV9PdRiQY8bQIzylpWD2FVzi+Czy9ADHku1M7DlVmbYqolC5giTlS99aLNK8TFlq4y0qU/C/hffr1WM8HabFtF0wKIeUozrJHHbcAT9Tu2bVT3wZPID51KUnCQVf0w0OIUX7dgJmNBRPeEI2lXiRyA8ihSVbUXZccD73aAbWDi9zp3qWShAOMGNauKp0ShkmpFP7UMxNwg/SttBMA71gei5uQyS0HjUYTGW/0TQ3jVKvo+GZeD6mKn3aNaidlLPgUTsZV4FmsQ4Bgp65lPPVthTUQ/BmwFXf2AL 7lcR3QTZ yPKtaCxuhEjlZ1OgZjybyiW3PZATpBsVqFLO7UmKLGjI3fad0qKHeLT/LD1/s36/B/pP7cWOwgiLdRjLPyGS4ql1Fld69CA+HZODf/UIo2cGcz/G5YWn5SkxlotlTm+jv2yGodS0VpAq6uJDIgXfDvOgvLr6xp8/EJvrefArZYk1TBhq6MBd1o2MI7Sv7tJgj+ed1rgxfXy4njcCkZrpujnkdwfE8+Isa72X1EtV+4zQJBIa7H016M+xbTw5fPkABE+Ag3pHPfqcC3xgNNVcPh4gKkoYWgUvZTKNjkLu2rjHvu4iqhHEImyP1qHKQJrqSGttZYXq42rdG1ky3L3gGjeCHhdgiGYVOq8pb6prb1C4e7pNv46fTI3FFi7TQupZ4VYiW0B+oJ+VAJ9S2nSISVUJHz9CyBti4YXX5byPYcb+jfq6u8TGotnpOPkW+f7O7quv5pZIm/ofJzsm3moMdUMGpOYnh6t1+D1yQ2SnGgGIP6MEZN3Krlb4ZSfW7MWWAx+doQiw4UtLsQDquVBClPnaDqw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 28, 2024 at 12:12:11PM +0000, Alice Ryhl wrote: > The documentation for list_lru_add() and list_lru_del() has not been > updated since lru lists were originally introduced by commit > a38e40824844 ("list: add a new LRU list type"). Back then, list_lru > stored all of the items in a single list, but the implementation has > since been expanded to use many sublists internally. > > Thus, update the docs to mention that the requirements about not using > the item with several lists at the same time also applies not using > different sublists. Also mention that list_lru items are reparented when > the memcg is deleted as discussed on the LKML [1]. > > Link: https://lore.kernel.org/all/Z0eXrllVhRI9Ag5b@dread.disaster.area/ [1] > Signed-off-by: Alice Ryhl > --- > include/linux/list_lru.h | 48 +++++++++++++++++++++++++++++++++++------------- > 1 file changed, 35 insertions(+), 13 deletions(-) Looks fine to me. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com