From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90DDDD70DE3 for ; Thu, 28 Nov 2024 16:24:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BDBE06B0083; Thu, 28 Nov 2024 11:24:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B664C6B0085; Thu, 28 Nov 2024 11:24:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9DE366B0088; Thu, 28 Nov 2024 11:24:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7F8106B0083 for ; Thu, 28 Nov 2024 11:24:32 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E2794ACEFF for ; Thu, 28 Nov 2024 16:24:31 +0000 (UTC) X-FDA: 82836026238.17.CA3E4A7 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf28.hostedemail.com (Postfix) with ESMTP id 6A064C000F for ; Thu, 28 Nov 2024 16:24:19 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Lwx97+64; spf=pass (imf28.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732811064; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AItm3NvzzDvmWyA58LEOmeT/SsjS5V1o9D+FQFxzrEk=; b=LnoRgL64UDiTPlQGWcRYixc7kd2v1uFGik29/ix0nSIUnOeOYDHhj8A3rtVGNdvSBUTTrd mq3xOfaSWHLjDXIcCSUTGNgFJMfHPFZE3RQY3lLBPT9hAfQ9UoHO33y/6TrnrYE/bJ1ERa r5NYldKIAP06PGWswnZV8tHmeZInpf4= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Lwx97+64; spf=pass (imf28.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732811064; a=rsa-sha256; cv=none; b=C0drB2mZmFQ0hUMLTDDrFLuXxRFaYQ3acOuo5SABf1S9sVGhy56xSynCCrvXJ2qkHTEEAp VnAchlsutIrQISYtliccbqMJ2riUtCx1TlDvzmaMW2paJT4N87ecl7PWFtGGt97WzTtRq1 2+S8kSNCH+lLp0g9l9cbKP8AIQMSC6U= Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-53de8ecb39bso1223358e87.2 for ; Thu, 28 Nov 2024 08:24:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732811068; x=1733415868; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=AItm3NvzzDvmWyA58LEOmeT/SsjS5V1o9D+FQFxzrEk=; b=Lwx97+64Le31A2+lKfJYuttqAZmA0DSQWpQLjFpvi21WtKycHb4QuouvP/a4Of3iMk Cb6uf6Fo9LjAUnmlmOnJ19cmO+U6VEbIGxiNn7Uu86uZNaPx+xLzKI5CF/SGv5GqngP7 B5W3mZL6+34TDl7eqhQuJK0VXpdDyrzFdfh/BCjPpv0dp4J027Wr1NqYQIg37Cn0lJZh USOORHXmvbfPKdxUWWBCn/ocJ0VEDdnuWozxgs+x2Ea+HUKxlkBYenaNcAbtiCF191aZ hC9hlTg2FQHhQ+JebyIaYVA2VAZEOI0TI16gRq0vB+Put+hwvtoUVs3op2Ap4qbiGoSh 4lZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732811068; x=1733415868; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AItm3NvzzDvmWyA58LEOmeT/SsjS5V1o9D+FQFxzrEk=; b=GK7tpam0gimjZO9E79Z+smS5yAAmRdZTJUmSkmS2z6skxlXzY3Wrs1C5mwYiUauCdq xc5KEqhre9XXXuhdMde2NBLUvsyuYEp8TvqTzm/Zp8OdkZH14Yh+gbUfCWMF1WaXT6L9 FBUvnKMrP7o/B+8iBizlTl3ZZuLU7iC3b6CPUjTgO3fqfR6kXRo4Ze7MQCGBAiVvxIi8 mhDgQ8f7Sm6ElVzvUAbtRUs2bw4Xhip238tDQHpTL4ltaFE+hW6DOxDACqxIpMNULPa7 Yc0FgxjO0zMFiWr0redt99TqW+NDIaKSnlyYPGsNMIWr5BP3i7HRbHrYVk0wewP6ULwI COGg== X-Forwarded-Encrypted: i=1; AJvYcCUbUKTVmk3JCPRbfGSAUJnnBXqxUimry9cRXw/Xx3DRZ2hiCDHDbtGMnQEeKOqNQv7EkWYtvHG0Wg==@kvack.org X-Gm-Message-State: AOJu0YwfuaVFK7ln/LqnZUVi6/epyTPV+2VlPkxDp7nDXBo/xTOrSFa1 X7u02OoCPKaNPua8C0mhB51NV5UR/WNsVDTRfuv98DzQTocwaUBd X-Gm-Gg: ASbGncvrQ5rBwO94d0cIqhPhDVE1YlSbJVwFQktg9BkqVuGmOAijkXMkqwOpu95qVWG M80L0I4oYuwkhUYQe6LlkMGHrvQ6SZSpMmjKoZXh7vH8MaG+NwMjcD5NdiHQtPkiw2JdzVAqODx jAB7U6sph6O4HGR3gCphPJbYV8BTmlIOreVu2+UtDNPRDvL/b40z4td9O00vaHfIIcnJ0Jy0U5d M7CwwlFkwLszBMve2TYj8xelj8/d5IoIB2S3zHbGqKkTlmSDpQT8GfsKjJP8wcd9E6ToMOng94G zQ== X-Google-Smtp-Source: AGHT+IH0pDy/8Q/yEDCk/6/yWnhjHJJVD6DteX7tExEGpoLNyoXJue9k8D2trnyp5eS8Rby+NVII3Q== X-Received: by 2002:a05:6512:2822:b0:53d:d0a5:aaa9 with SMTP id 2adb3069b0e04-53df00d1b43mr4659348e87.20.1732811067433; Thu, 28 Nov 2024 08:24:27 -0800 (PST) Received: from pc636 (host-95-203-21-235.mobileonline.telia.com. [95.203.21.235]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53df64310d2sm219032e87.48.2024.11.28.08.24.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Nov 2024 08:24:26 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 28 Nov 2024 17:24:24 +0100 To: Vlastimil Babka Cc: Vlastimil Babka , Suren Baghdasaryan , "Liam R. Howlett" , Christoph Lameter , David Rientjes , Pekka Enberg , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Paul E. McKenney" , Lorenzo Stoakes , Matthew Wilcox , Boqun Feng , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rcu@vger.kernel.org, maple-tree@lists.infradead.org Subject: Re: [PATCH RFC 2/6] mm/slub: add sheaf support for batching kfree_rcu() operations Message-ID: References: <20241112-slub-percpu-caches-v1-0-ddc0bdc27e05@suse.cz> <20241112-slub-percpu-caches-v1-2-ddc0bdc27e05@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam05 X-Stat-Signature: gjsfgf5pntow56r99sbos3jccpkmkm1t X-Rspamd-Queue-Id: 6A064C000F X-Rspam-User: X-HE-Tag: 1732811059-671548 X-HE-Meta: U2FsdGVkX195iwir2HKrjJSFC1xB1RDsaEm0vFnt0kPKNMUeDeIdMcg6xaXTUGVmlFeJ7+VtYv3QDXlejxb3izTRwnE64q3TMszKfqaD7iVyQrLg19obHyqGD/xgIOsZuL8oCQJGAcvjPGItXp4oSrbL48wqo9bsTyFSwcyBFnB1riS+w5iX17L15Jr50HHv16QvmCEH///g0Y361027tssCVy6hTzd91D91CuZRh+3B/XTVp9UPC05eYGFamPTPJV0SqIWt6CB9pBCBH0bDz/3IjuL80md2Tw/9MtzLAkUAzPHpvGksYae81Rn++iZRIrhMPDWMCIKYHim+fPX3uAOdfMyRRyw90VrmZVDE2YoUs3FMwsE2gPso+naOllFANy64ttBPKkFDw/889uf0JXdmAU/FqkeksgilykVkq6HrCjfHU1uswd8gZe4ML4FyKgKdvYGFmYnnRYICtGHos6zKd4EgZ4P9Q0hPK7oZ14/xlK4Ux6xbFIGcpy8VpscGbEgiCLgxEqxde1T7Tu6Wmc7UXdKuinjXzKFh44GTQkGd466dCU+i9Dc7vZpTsvlRCqbwHE+zob8cxa0X6MAkyiavpuQu6m7XsBQU96pEF3h/KUtDlbNHf5tJmYE40YBmeo5lRVp3Zs6HQ5HHMqdyYvYlu5wHkAyy7MuZylwnUm+FXoDd/hhDe65RNjJODx/Y2n1+2ONGVZBhs1zHZFYPcA5KNoHb8InAnmDSskYGKWF96QjhlEQjcDa1LH8GQgqc8kmZvIzA7l9zSDXzLvwWfG43vuS8JgYZtgN2BNTWgUch4uRo7/caQGmoPNhJT7QTiVt/vtSgB+1JurKTroCvPgMHD75I0qSFl6NdWJaHmFZ65hShtcnJuojU6nEORBIcQ6wReTzA0UXtGnnnDMTRr/ITDuBsiQfBVwZl41NjOvKnrsgdSOAusx9fBT7TDGxAwMnIerEtNNeWCbwgZqj DgjqVjrA zeT/RYlSZc40oLz2/B41DBqMhCBJ2gERjkIRnFf09jVnaTbGeEwkKpGVTYv1BMmNUmcfZrmfsneNQruXoabIrO3RxuWc2hiRWh2O46xVS6bfEWDkYT1dlCmsFUUAqsYQQJW5kIjF3QGRF5IVGKu5WzVYKFBfBBKIfZ9EX0T82DLECPBd9Seblu4DEE8db34PEVgivSayMVVBlhsAoBdrlTYOKSv7bnTLbUF4T6VxY+ULzDNX7I03GaO0OCj+jtM6Y8ew4NbN1Rn+NbBigKZ+pY3YfkrWRNjvC3L+JgLLcDGu++j+PSTX6rF/pYOK9d98OjACt6EmlEZ6Ek38GXOqy1sNFNqiePGipKT4fDWi3Wv9kJudugLD6PB/248Wv2kGITGWytUjQwiKTrsIiWca2JSIrKpMOmLpU+FhnkoWlknIdR6WJ+0QBxwzDqZqbvs257ePkiGsLSJ54phd/jjov48oMsfrnt1aHygVPkz7DdMh7/UgpbGTjaWJllLSKs+lmrnU2sB5zCv8AqD0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 25, 2024 at 12:18:19PM +0100, Uladzislau Rezki wrote: > > On 11/20/24 13:37, Uladzislau Rezki wrote: > > > Thank you. Let me try to start moving it into mm/. I am thinking to place > > > it to the slab_common.c file. I am not sure if it makes sense to have a > > > dedicated file name for this purpose. > > > > Yeah sounds good. slub.c is becoming rather large and this should not > > interact with SLUB internals heavily anyway, slab_common.c makes sense. > > Thanks! > > > Got it :) > There is one question. Do you think it works if i do a migration as one big commit? I am asking, because it is easier to go that way. If it looks ugly for you, we can use another approach which is to split the work into several patches and deploy it a series. -- Uladzislau Rezki