From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70249D5E39F for ; Thu, 28 Nov 2024 05:43:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B79C76B0083; Thu, 28 Nov 2024 00:43:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B29D36B0085; Thu, 28 Nov 2024 00:43:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A18C46B0088; Thu, 28 Nov 2024 00:43:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 834D26B0083 for ; Thu, 28 Nov 2024 00:43:45 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EFEB41A17C5 for ; Thu, 28 Nov 2024 05:43:44 +0000 (UTC) X-FDA: 82834411674.19.69FB1DC Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf17.hostedemail.com (Postfix) with ESMTP id BDC9240008 for ; Thu, 28 Nov 2024 05:43:37 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=SHB88Wus; spf=none (imf17.hostedemail.com: domain of BATV+8f1f2c69cd16170b7569+7767+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8f1f2c69cd16170b7569+7767+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732772618; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KwOilkyvsWRIg+rSVQRJ19Fkv2nNhKGizjf472lxEeI=; b=XaLOPyQvB6WnIDyG0lpFCU7bJQVVhMrD6tzVZU4R/yU2mfnWUzbMB7JQaEP7ZMeHk4zMok I/S5px4kCJQYnki39BZt9Ff8bpe6Qw/XC7OgWCf6lozgX1plE4o7HiK/E4QdSJQeh7w4Wx a7cMznMoZ231dsd3orfl1pIFXKWyRP0= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=SHB88Wus; spf=none (imf17.hostedemail.com: domain of BATV+8f1f2c69cd16170b7569+7767+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8f1f2c69cd16170b7569+7767+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732772618; a=rsa-sha256; cv=none; b=TywzdD1OMgRphfsR5+JYD5fSVMS5u7wVhARwomL4qP9P5ZoMRTxQdtgw323Aju/wZ4LL08 FUNZqTqlaPkgbAudmsAW/TZxAud0c8zRBKgPQ4fJokJ7xXDAe/GWddW2VFuilhhB1HUdz4 K4rH5JEFnMZr0vNSR+6Oou+a38cKkOs= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=KwOilkyvsWRIg+rSVQRJ19Fkv2nNhKGizjf472lxEeI=; b=SHB88WushSxBQxj/5ON4lFxtYR tfms5WkfuGvdo3JjMsH7iSj5QgIN4oNJdiru1ljGniVmIac+TTSUhmK3iLd/kPzNErN+otaaYgQ8M QDFlTYMxWhMB1bkPrxABPGVzjxUIOzp2VNjZn75V6Un72GqvVz6GnWQEr58wYkmDosHqnBviJfUCQ vrBtDm8sGgNPvYn+/6be4pxJM7dofCkHUIoQiu4aRYejIE2ibVM1Cgkm8j4nXem3l2HXrUfi3V0Tr wFbeJ+XNAi3fik+am5fZaImsYWVwUVldjYV/9WcydkXrF8TZWpSl9adqkXlez27JJ28ltzSHCsl/R 3WT172xQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tGXJT-0000000EkGL-1rWv; Thu, 28 Nov 2024 05:43:39 +0000 Date: Wed, 27 Nov 2024 21:43:39 -0800 From: Christoph Hellwig To: Bharata B Rao Cc: Christoph Hellwig , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, nikunj@amd.com, willy@infradead.org, vbabka@suse.cz, david@redhat.com, akpm@linux-foundation.org, yuzhao@google.com, mjguzik@gmail.com, axboe@kernel.dk, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, joshdon@google.com, clm@meta.com Subject: Re: [RFC PATCH 1/1] block/ioctl: Add an ioctl to enable large folios for block buffered IO path Message-ID: References: <20241127054737.33351-1-bharata@amd.com> <20241127054737.33351-2-bharata@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam05 X-Stat-Signature: kwu55txfpm5bf7qtcby7thy6r4y7zjs6 X-Rspamd-Queue-Id: BDC9240008 X-Rspam-User: X-HE-Tag: 1732772617-725021 X-HE-Meta: U2FsdGVkX1/OygTlELBg+m43HThNrWNkRXhH4NHddclijo+vanp4q5zrHgjifBZ0S56/LU8FmI0V6U/WCTSEh1Q09CnTlX3z5BuvXZlUIZ0vwwhWzOZAtv3209ORibxmg1MH3uUTOlBp11eKAT6fRAafYtlSi81bQsDOC6/jEjjeG08POFfDMMTHCmRJ95sqLvCTeEeVTvk9wj0EE66BFjuzmjeZftD1B0wJdTuT9JGLqJLQ8TVYzY+JSyaFHYJ9X6bfXm0nie+w3vjdgvwm31YbXSllhm2Orl211I6C2lFmH7otYCNli7Pr7seo6+78e3WngQ9QznDh/J2ypuSEGXhhEDULcy6WYM7YyOzWnK0yzfXHFer8/HyL/J15IllWOIB4xxNq22DLk7Ry6pDzr5Jqpy/WfgDFOQ5lGdhcHRHexCA+LaPwIt7ZXddTYC26zshAWWRrMD+q6enJJ4awGC+ip379Yf7jSZvY6a1Hz8fIPhMMLMe3wYT8jkvqHquouCmQF7iuGtCfB7uYWgxpP4u2v6fFw9X8PSuIVBmJCwqysyrBZQQMSZylP38+FQl78JkQYGRBIAtZyTh8o9k3c6llz4uEMmzfxSSna82KTUpc+s9hAC4256k1OkrTenKtsMQ+O8g0XfykCZQhEecDM3y8OkPOlgopm24tCVMxwiVvUOvXYeSsW+EeS4e4FnJoAZekdKHJKfPaE6mW4lk3n8LYJHD88Aa3j7lIL1rLJVR81dU1amgtmsbTJS9dTOVWpPnF8PIsLiLNCh95TlkOwkQ1PQVnupukjhWqReSbcT+QWvgDwaHHaEGD1td3E/ICVg+wWiIY+E/I0RfoPyWBQGYL3SvEwuFF/IwvNj/Q8VLsXQBJUCxl3e+KZ5sSg8TiBKrO9hWBH207WOcx1SBn6jTN/xU6qoUPb828iJjGu0wOnL/38dBFYiMYYaLK97T5Gwk4Nyzbxd4fzlXLp0b 6tOZ8Cuj y8z4WhxUZ14oVtE/Kh+nveaGmIjA+LxVwrmMIWHcjpSU2AcMBqIqrLqapiMqztrNNGz0DAdZrXRl9eTpFFosmgSsIiHxnNiJA7fHRxYIGi45TGDFueUFwFE8iC2kuT1iYtePG5iXEkIGC8VwIRpKtaPxBlV+deGaBOzhypG4qReTftGQEExWmokpjPPXJ9tmmmQ3q7SaYBDHQcHdHBNf+MxUWWnEsjRLxrg5gr28tyoIv5YqWgT9o35AbhKHrX7rnfyQQtT09cxwjOnQRQ/1q/FLmR+hVrqkJyqjR+9GaCfumo1qSSr3w2hgGDGaOWHCGnUqEJOGHC5904mtzdBQ8ky4gRJtbuTfrQeX9SRbYKzFZDih0+4Z0vS4f9/VxXFdnqhtA3DpGpokYJHS8mlR3RbU6bbd8ysHJpFBAIJEAWEKKTXdzpNWlgW9GFV/5CJW9rp1iROpossVyz6TuxNQvS1//Noii63crxRjQPy2PpwHMDw9A4WqU8QW51ZZbsmZ6zNTUj4mWIS2wbOx52LOphvuPzEemx+EOR7GyxFrrdT9Rga7aTQ7z7CMNFhvscPtwg2RpjtfPuXniKomzcloQmWQRnjEzQPx/fAzkAH8ECAGhDmIO48toDanG+lF9Q9VUYZR8Xu5Zsd+OW4VjfmbTkoZDFwqHV3ZX7sRs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 27, 2024 at 04:07:02PM +0530, Bharata B Rao wrote: > I believe you are referring to the patchset that enables bs > ps for block > devices - https://lore.kernel.org/linux-fsdevel/20241113094727.1497722-1-mcgrof@kernel.org/ I actually thought of: https://www.spinics.net/lists/linux-ext4/msg98151.html but yes, the one you pointed to is more relevant. > In fact I was trying to see if it is possible to advertise large folio > support in bdev mapping only for those block devices which don't have FS > mounted on them. But apparently it was not so straight forward and my > initial attempt at this resulted in FS corruption. Hence I resorted to the > current ioctl approach as a way to showcase the problem and the potential > benefit. Well, if you use the ioctl and then later mount a file system, you'll still see the same corruption.