From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CFD5D6ACE4 for ; Wed, 27 Nov 2024 15:00:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 285C56B0088; Wed, 27 Nov 2024 10:00:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2354D6B0089; Wed, 27 Nov 2024 10:00:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FDF06B008C; Wed, 27 Nov 2024 10:00:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E7CFC6B0088 for ; Wed, 27 Nov 2024 10:00:26 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9BDA881589 for ; Wed, 27 Nov 2024 15:00:26 +0000 (UTC) X-FDA: 82832185758.01.28DE261 Received: from fout-a8-smtp.messagingengine.com (fout-a8-smtp.messagingengine.com [103.168.172.151]) by imf03.hostedemail.com (Postfix) with ESMTP id B6BF32002C for ; Wed, 27 Nov 2024 15:00:21 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=tycho.pizza header.s=fm3 header.b=cflNpNiE; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=BVxSiHKe; dmarc=none; spf=pass (imf03.hostedemail.com: domain of tycho@tycho.pizza designates 103.168.172.151 as permitted sender) smtp.mailfrom=tycho@tycho.pizza ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732719621; a=rsa-sha256; cv=none; b=VIoYExkRIOKt599/n7mX1TyUwWRD6DmPFYQRV7yGg4QkBIyhkoQKqOVRkb0CtgW8H/c8aw gMdFrjYcmkA33qgh7EEzNo1xuWVRoeRLHcypR4Jgg8dbAJru7UdlAO6jJ/3CZ8SFDnyTc1 Nm9q3ASUFs/Hw3wiN1L/WLXNTynMXJI= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=tycho.pizza header.s=fm3 header.b=cflNpNiE; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=BVxSiHKe; dmarc=none; spf=pass (imf03.hostedemail.com: domain of tycho@tycho.pizza designates 103.168.172.151 as permitted sender) smtp.mailfrom=tycho@tycho.pizza ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732719621; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rdIuwMAQ6Gejsm7b5qViee1kStyXKxOtBCpCokGSvD0=; b=mjM2/5sa+ZiLWMaD1migWgWrs01yLerMX14urSm0esrSWysrNyDng1Q6V9LJTJOCmYKTG3 G3Joja3AVWgP+xWHjAaedxjhMdHezOwF3Us0w4JkGmGBZgHfkh/soEwdiYZYxZwZccNdRN Lq87RlET+1dTBKa9E5IMVTNqJ3cRzgw= Received: from phl-compute-09.internal (phl-compute-09.phl.internal [10.202.2.49]) by mailfout.phl.internal (Postfix) with ESMTP id 6177413802CB; Wed, 27 Nov 2024 10:00:23 -0500 (EST) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-09.internal (MEProxy); Wed, 27 Nov 2024 10:00:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tycho.pizza; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1732719623; x=1732806023; bh=rdIuwMAQ6G ejsm7b5qViee1kStyXKxOtBCpCokGSvD0=; b=cflNpNiEwHtAQBw2zgCv4gadWK Q/YQjdsizsTuzoGPOn7+J/9WALRxliMimt/T1fwa0KXaTMza+ZA2K/Y8hcAgspjc SzA0mKedQQxSdeuq2LyFwXrHa0uqxM426HBZb1gqId+VqvsocBl1YonmrFaJ0u9J f4e8/IPUQxHNzASrhpHQx7Il0egtQBsuw+0WfwP0PFQ42pL7kdtMMxp+D29W6v2F CAAbFlC/Y/eDQoodCD2c8rhuirYk2D/QL1ByFsmyMcUHpwYy3Cp+/98sP9kTfYQY Ho8zMrWEtHknCX4Xcv/AWF+2xvU4X1NSeT55gP5t95DM7Rp7DBZS/rKpAyOQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1732719623; x=1732806023; bh=rdIuwMAQ6Gejsm7b5qViee1kStyXKxOtBCp CokGSvD0=; b=BVxSiHKe+WTKqTYCFwcCNnjBMd5UTbjDwb2Pq0niLaFLmlsMnTX VViUaEZO3PeSBDGbXdlpKg6VGxgmpdQd2CWpGsMqmHJDI4far0VCga+W/VLYPrJ3 vwQiPWjfn+2yuZkavsRVZg+1zg5fzirWLwy0nMl6o8lIvIFIvKJqNo9RL7DL6QbG ToT2aN/+03pSBwjn3QJBCzooYZUfKJ/Zj6gnPpqd9YwG3Ce0hCjpx498dx1TRx4r r7d6YWC6z+1WXVfsapfonzkidsz6wiz5NZ1j+/4VxKd6VulnMeEnZThpHJCzjoaA rXImPYEZtF2/wk6qL0pkmw1kFrOZK7HRgYA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrgeelgdeijecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecu hfhrohhmpefvhigthhhoucetnhguvghrshgvnhcuoehthigthhhosehthigthhhordhpih iiiigrqeenucggtffrrghtthgvrhhnpedthfffveekvefggfdvvdejiedvhfehleejtddt feegleeiheektdeljeeigeeigfenucffohhmrghinhepshhirhgvnhgrrdhorhhgrdhukh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthigt hhhosehthigthhhordhpihiiiigrpdhnsggprhgtphhtthhopedugedpmhhouggvpehsmh htphhouhhtpdhrtghpthhtohepsghrohhonhhivgeskhgvrhhnvghlrdhorhhgpdhrtghp thhtohepvhhirhhoseiivghnihhvrdhlihhnuhigrdhorhhgrdhukhdprhgtphhtthhope gsrhgruhhnvghrsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehjrggtkhesshhushgv rdgtiidprhgtphhtthhopegvsghivgguvghrmhesgihmihhsshhiohhnrdgtohhmpdhrtg hpthhtohepkhgvvghssehkvghrnhgvlhdrohhrghdprhgtphhtthhopehskhhhrghnsehl ihhnuhigfhhouhhnuggrthhiohhnrdhorhhgpdhrtghpthhtohepiigshihsiigvkhesih hnrdifrgifrdhplhdprhgtphhtthhopegthihphhgrrhestgihphhhrghrrdgtohhm X-ME-Proxy: Feedback-ID: i21f147d5:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 27 Nov 2024 10:00:16 -0500 (EST) Date: Wed, 27 Nov 2024 08:00:12 -0700 From: Tycho Andersen To: Mark Brown Cc: Alexander Viro , Christian Brauner , Jan Kara , Eric Biederman , Kees Cook , Shuah Khan , Zbigniew =?utf-8?Q?J=C4=99drzejewski-Szmek?= , Aleksa Sarai , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Tycho Andersen Subject: Re: [PATCH 2/2] selftests/exec: add a test for execveat()'s comm Message-ID: References: <20241030203732.248767-1-tycho@tycho.pizza> <20241030203732.248767-2-tycho@tycho.pizza> <6c68dddb-84f3-4b73-987c-8334b2301d9b@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6c68dddb-84f3-4b73-987c-8334b2301d9b@sirena.org.uk> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B6BF32002C X-Stat-Signature: zxmiw7gu5oip1yu8staxpo8u9xsa1hay X-HE-Tag: 1732719621-39836 X-HE-Meta: U2FsdGVkX198BouZITUe7JGuqPskveWzJe+WsntSZy6LVDAoptLCTTh3gKMcWGo3Tj4Yi5FGrcDHLJWj8/7BVadmzmZZraWbgCBOWrIn407Mlrq6WQuvY9F+YQknLQ8Ogk5jGNWpYwE9eN0qULpBQOs/dGb/6NrvsQHwDm1HbDrGN4uQ9qAF+5KJaKflPnpUGFMVcDQqAuqLay0EMVGTxtxS2n/1TgjHQcsJrzU6EGtibxhlQwBVX22kitIDA88wyJa9SlzqO9HPmT/Ojw6BSqyElCFarGiIzgWnVCOwkpQDyB8y9O6p2xsBcyy+HBZGQ51O00ZYx5Nsps8ELgPPjFFDdPvAI8wd148QvD1/EBHX+WryqxnmSzi5QKOYxWPrC2XXRe1WZtqNaLzYiKemYQXuhbFi17Ir6nctboJ+oGh+mLdi1jZSSj9M+FfxornA/wjB4yg4X/eqcYowKed3d7WjwI5+mHI+Dz5frxs9jIXHeI8E8sU/4w+mq3Rao6dIjQerNZrpz/YfjiD1suMGtEvkXx3G85h00XjbaDAP42ZFK388oFzVTGKIVelfpyi9FY8Kar6sLhy2T+wzoo7EN1mjKHkcDaSrQizt1J2SijhyOUityXLSrSyikYf9xeAGTb+JyVhdM8cTyjVimNIcoz/PCn9ZFH6lerqJuot5CeRIw/RpjvuirJ69EUdUA7/E2kIqt+k/zHjl1qjYipfB581RKfH0ua1iBPqOd8asSRmyQx+R9EvvzkczIU53MC9PoqtwyN/L9fWCnMu3FEp8efzBBzS4HMUvb/gnPeJWxhgHOO3dD1PlKN438jPkXocMuPePpJYwjGUbIl0Hv6/BbEpIz5jh3CBhRZhBgKM+UMMMxTng4FjUpyE6Cc0jGSi5/cvZQcF1kdECFlXxjqoi/rlK8BhFto7UyCVYEFkPcXSJW1Vj4DPRwQMTQzAVDoBmbd2FRuUbB7Au87onhl4 A7AxRHu5 c9knqhu43bOcyHOvhKP/V7CxU1evkxUXkIn56osRA2fdANsdZvlg3K44DEazho2DBzJKvQmBxy1fK6tnde8X/Bid0+Kt7M+JpwkMxvx3fUUGiuKJxIygOLvitYFOlqYLTA8JI6b1dQjm4KqSIAG/j7ipl/9AOGbjXRK7r3E2WfkFp7+t2wQ1Heoq+5vx7PJP42xcCw/UdmUTUiiHwj4nx+qoPn5ciwNaUcH3UdepIzFC2YlOAFM6oG3PkgsxsD0BgdiDZDVMX52XF1zfobiZrkUS2qC4/7pld0NxYTipD15dGcof4dCDmn162CvrdeLjxwtP7OaHA3XOHMoSyKdt/aKd2APcqci7aMCB/kzfKqiXrFDhobtxawRqVEAMLBt3//uMs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 27, 2024 at 02:25:29PM +0000, Mark Brown wrote: > On Wed, Oct 30, 2024 at 02:37:32PM -0600, Tycho Andersen wrote: > > From: Tycho Andersen > > > > In the previous patch we've defined a couple behaviors: > > > > 1. execveat(fd, AT_EMPTY_PATH, {"foo"}, ...) should render argv[0] as > > /proc/pid/comm > > 2. execveat(fd, AT_EMPTY_PATH, {NULL}, ...) should keep the old behavior of > > rendering the fd as /proc/pid/comm > > > > and just to be sure keeps working with symlinks, which was a concern in > > [1], I've added a test for that as well. > > > > The test itself is a bit ugly, because the existing check_execveat_fail() > > helpers use a hardcoded envp and argv, and we want to "pass" things via the > > environment to test various argument values, but it seemed cleaner than > > passing one in everywhere in all the existing tests. > > This test doesn't pass in my CI, running on an i.MX8MP Verdin board. > This is an arm64 system and I'm running the tests on NFS. > > > Output looks like: > > > ok 51 Check success of execveat(6, 'home/tycho/packages/...yyyyyyyyyyyyyyyyyyyy', 0)... > > # Check execveat(AT_EMPTY_PATH)'s comm is sentinel > > ok 52 Check success of execveat(9, '', 4096)... > > # Check execveat(AT_EMPTY_PATH)'s comm is sentinel > > ok 53 Check success of execveat(11, '', 4096)... > > # Check execveat(AT_EMPTY_PATH)'s comm is 9 > > [ 25.579272] process 'execveat' launched '/dev/fd/9' with NULL argv: empty string added > > ok 54 Check success of execveat(9, '', 4096)... > > The output when things fail is: > > # # Check execveat(AT_EMPTY_PATH)'s comm is sentinel > # # bad comm, got: 11 expected: sentinel# child 8257 exited with 1 neither 0 nor 0 > # not ok 52 Check success of execveat(11, '', 4096)... > # # Check execveat(AT_EMPTY_PATH)'s comm is sentinel > # # bad comm, got: 13 expected: sentinel# child 8258 exited with 1 neither 0 nor 0 > # not ok 53 Check success of execveat(13, '', 4096)... > > Full log from a failing job at: > > https://lava.sirena.org.uk/scheduler/job/993508 > > I didn't do any investigation beyond this. Strange... but this series has been rejected by Linus anyway, so probably not worth investigating further. Tycho