From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C76ED3B9BE for ; Wed, 27 Nov 2024 04:22:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C3B506B0092; Tue, 26 Nov 2024 23:22:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BEB806B0095; Tue, 26 Nov 2024 23:22:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB3536B0099; Tue, 26 Nov 2024 23:22:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8C95F6B0092 for ; Tue, 26 Nov 2024 23:22:26 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 008F74032D for ; Wed, 27 Nov 2024 04:22:25 +0000 (UTC) X-FDA: 82830577914.27.E07932A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id B16F3160005 for ; Wed, 27 Nov 2024 04:22:19 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="vIQ/OWTz"; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732681342; a=rsa-sha256; cv=none; b=dddd9iFCg4iUglKIA06Mw7RD/8gsLOhUCMnd9YLH6q8GYm/R8kPFEoKGZAsKl2w9WJwXHp k2zP1H5Ri/y226k8PmnGoP6Yomcl3N3PAeQOFoSPyqcceOz3fG+/jMBYk8+nig0nabDy3T Tm4F4mPz+Irx+HTfGetZUmyxYWjS7IA= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="vIQ/OWTz"; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732681342; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lsl6ovAWE+1J5VPRu7emBoNaP80Jn7k3CUy4+NuzBgo=; b=29Ybz9n+9KC1CvmWu2Wlm3Q2GJaDd9exZlfPmu41pPz6nrNbzZy2jNAhsjw89KkyLQqljx TjqinBcnnMQK/bJOZtzC13BGI7SSZ01qPu6SkcaE6pJmGFtaTTrxvUiKw62O7BfJ1IF89O 6ryBCrg5ZhyWNGRYmdgPqhGwARPNdaA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=lsl6ovAWE+1J5VPRu7emBoNaP80Jn7k3CUy4+NuzBgo=; b=vIQ/OWTzOJMV8aZvPso4/T2Krm FcXIfiRo7iY8snv8wTbCWgP3cH/xrv3DDF6C543FPlzLfkcqaXvgVMv6S278Upt10mQsfPk3z+gpu oAcdtXtn4LHDRQgxG+00C29MHmBr7j68+dcjugVjBw0vH+ejTzetn+bdnZs18TZAZND+i5iv7DTXv 1n1R8UVlTE9vKn3awOZ4GQ6n5X0QLkTZnmWSmzazfZfdZ39NmlWyigGF4+qNfUIAWSBzgTdSRCVQe 2J3xAj5hn2hnlogdDDBdQr36cnSBojfyj2C2U+KrJroGFx+c4wJktJHb9+iz2my79ldVI5vUNqJZ8 Qpwqg4vg==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tG9Yl-00000000sPD-0Ish; Wed, 27 Nov 2024 04:21:51 +0000 Date: Wed, 27 Nov 2024 04:21:50 +0000 From: Matthew Wilcox To: Yuanchu Xie Cc: Andrew Morton , David Hildenbrand , "Aneesh Kumar K.V" , Khalid Aziz , Henry Huang , Yu Zhao , Dan Williams , Gregory Price , Huang Ying , Lance Yang , Randy Dunlap , Muhammad Usama Anjum , Tejun Heo , Johannes Weiner , Michal =?iso-8859-1?Q?Koutn=FD?= , Jonathan Corbet , Greg Kroah-Hartman , "Rafael J. Wysocki" , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Mike Rapoport , Shuah Khan , Christian Brauner , Daniel Watson , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v4 1/9] mm: aggregate workingset information into histograms Message-ID: References: <20241127025728.3689245-1-yuanchu@google.com> <20241127025728.3689245-2-yuanchu@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241127025728.3689245-2-yuanchu@google.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B16F3160005 X-Stat-Signature: drk1jhccnrghffh7sk8u6xrbicujwik3 X-HE-Tag: 1732681339-854288 X-HE-Meta: U2FsdGVkX19kMbvEdx4hxHg4V9g9H51FDkzrcu6DnOYQ4bhyh2YtzfZS+iRFqNwj6eYf4TBF7JMgXZXsp/mybOZ+lEc3S+mihmhXLJlYubXzC+z72ucqaRTcIkK0+CuI+cdBmLYxmW76Aiwf1kMBzE3ou+6xwpxJj03QSl61gFp9VtngqKVf7ZKnotBaz0wkftGFeK0fVVGOjDEQAXjlT5Su0VbugaS4YQuQCI+vKfKoGMUBVfeETOkepeTVn97zQ/r7JnpI6zC8mUHorubuZhI11+YLiEgrJIchdA+idAlhrdnDOjOgckt4nhuJdbCz/xjDEEo1wP6neJBjC4tnAyl3tmINlOHJVEnBCRVPKc7qhBfbl2Id5zRKempvQgThvXVWTwA54xT3KckalikZfyt3I6GmX21BUIhK8upqGhcpiWVCzGazh5g9T0M7jHe1rY4Wq8ESGTt3OYdN40HXu+G0ZRnZl+m1rkDsErHZqIZkFZYMRuZkhRN0yh9nw7tA4GktRwdZe+7Y4dY8dn43PKIHCq2OoD24P+NpEgFJba36zBfIFInphIllxHArpQL2xyLBtnAi3aecfmsbu/ofz6MVIrguMdF6fwE9B8QoYO2UDhn3xSBzAbOVzKq/53WrcQBKCoSe+8Mq6ZqRE3CvS7TD8J734paVmtLbBl/6F6eyzbJ4XHPud3wfzmkNFLYK2Mx0NAYZ5k6rJU2eGL9mvoiC8hAS9X5AonwgMRuJJ7yn8vVYX+b4tW3ryLfQNB+WANFD6XQ3lcJkDI5SWCTKIRJzS5QeW//cZnYVoZbvrVrwxoHOXolM0BuCVdyVCWZCbkTfI0SWhV28CRsPrCxWnaW+qUTwjN0L3VlDHgNNA0bTOX8v5zwg0Wnuz2eXufSqnDBHdIbEtmtH8aEqfYUdmELbuiKpKQ1BnqGtg5GGzZC6eu0kzQo9AuRnL8XumExXCGjziJGHzwcbm4OhugY dDSJ/b7T eNnZYZrr9NS31wP7TG/Q/Ve53cm6TvXVLFmZWiHd4/XfFBLJo0dRoTdhKCHbfFZSxuK6E3/6T1gTd/RYxjYa2hGU61Kdyp4EHcS3lb4GSVmOUcMAWInTkbbuCzASVFyCjNUT180XKh3/BzFFaAY4dygZ/cAfdISqKd8CY8Xw2RkfQbWyI0ewes0S8MeZc4CgTgPzwP638DOmKemvIK0a+/OLGI1t4l9bjop6wzbs7l45NjG4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 26, 2024 at 06:57:20PM -0800, Yuanchu Xie wrote: > diff --git a/mm/internal.h b/mm/internal.h > index 64c2eb0b160e..bbd3c1501bac 100644 > --- a/mm/internal.h > +++ b/mm/internal.h > @@ -470,9 +470,14 @@ extern unsigned long highest_memmap_pfn; > /* > * in mm/vmscan.c: > */ > +struct scan_control; > +bool isolate_lru_page(struct page *page); Is this a mismerge? It doesn't exist any more.