From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F22E6D59D6A for ; Mon, 25 Nov 2024 20:18:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 848256B008C; Mon, 25 Nov 2024 15:18:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F8F26B0092; Mon, 25 Nov 2024 15:18:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BF846B0093; Mon, 25 Nov 2024 15:18:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4C0E96B008C for ; Mon, 25 Nov 2024 15:18:49 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E0A4280D04 for ; Mon, 25 Nov 2024 20:18:48 +0000 (UTC) X-FDA: 82825730652.30.2735D83 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by imf16.hostedemail.com (Postfix) with ESMTP id 4C48D18000D for ; Mon, 25 Nov 2024 20:18:43 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=TVL8Tsb1; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf16.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732565924; a=rsa-sha256; cv=none; b=h7ZeQr/ickNfaJ2vtX1UQRUyaMyr7CYar8nqoLlCQ2E91dzj6Ilzmpe7uyqsDv+jW3E9+h EAGrF3ERXmzrJf3E4/zpFerSWGDF68mWhRcyxUuZbwukYvUUB3LvAeW6IY308sJW3z18UA wGkigfrzezn82eGgCYCE+sgZl2yuOI0= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=TVL8Tsb1; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf16.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.53 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732565924; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e4EY5DppAwA0h8a9qcqbq9Vb3NGzr0pQtsRmicZxTlg=; b=WZv/6ABLan8/x8NkhhPje1J4bYgsk9t18g2yOU4EOdxgmZ8WvPgOr0fSn/LPmqJDAtlPIQ x0ATtAjMTQTdMAP4KrfoegWk6Sim5QB18BqX+rC1tqv2g2dK7AvONUQOlN4RuugzrNQDLe aXoMyrktM0IYAu9w93OWhjYHcbkl2dc= Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-aa543c4db92so278745666b.0 for ; Mon, 25 Nov 2024 12:18:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1732565925; x=1733170725; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=e4EY5DppAwA0h8a9qcqbq9Vb3NGzr0pQtsRmicZxTlg=; b=TVL8Tsb1vIrz0igOV7m1JeYF8cA24bvVewiJWn6hwfPgn5RjfuDXbR1Jat3DWmBeG4 IlAT1wHA6M+POXxPgdZeHTotv3+KgqMZJunp4qyHvnxpRqqtMQECjTkJkLhB8SQ/FHoT oc0XUbRFbOuohRwhK+tfBzopcL8E1CKaPfZaOzRPL5NlN3V5FvSRIZRE3qW6A948XtpZ QyKgy/FqTPLwIguQ/7kKWkgmYa0jgwnqVkRv/p4Lo0JEF8tIBqd9pLxNFVEh0DQF/moM Ms/Rk7hzL/6iy94LbIWr7clxJGdEvg2O1JUhgP6DpTbA/rydu/FcdpH9pFMziVDfT6T0 2EBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732565925; x=1733170725; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e4EY5DppAwA0h8a9qcqbq9Vb3NGzr0pQtsRmicZxTlg=; b=hzY2ez1tWyz+FKYvt92cFGyY53u/6b0eoCZCgjrFL9mNfZqd9DbQrd31FGKAsJN4mz /7/IGgPmI0RYHgOl6e51hM0LbL7xfGQPIS2wVXvs3HzWny07mZWgckkisrvzHx1I9Vkv Fg4495jV8AIx3k6mw5VTtSUiZkOsJTsTLKVHtAV7d9hTzQnWyDfHQXkMjcdv9PtrIrwq u6eV1FKciO4Bb1+O55onk8GGtlGTvC+AM5sSVe4Eo14QqRdq/hJk/JInlA0BBMoDQbnO sO3cJmcnJ1FO/Xm09POnZzmJYVsesoM0cBXNhJBv4FZiGmH+zeJGP0qDikv3kQ8rR7NR HQlQ== X-Forwarded-Encrypted: i=1; AJvYcCWYFyE2mtQtw/Yk710LOaldapnLxhEM64p69G5TJOVsGhNEfuGJ+E4vkjzPQ51P4h5ONaF2FK1dWw==@kvack.org X-Gm-Message-State: AOJu0YxiWUysuecgU4FUM2x7wpzjpwqBkuPc3VvzL7cz+cmcW/Vi0EdS E9mYf0sun6ylc8o/lKXUJx2CKa8QMEkAqoW/X+12ldJwTFdDPLeOt2+Arki2emE= X-Gm-Gg: ASbGncsgl2v2qR14YEO+D0oVdCSeGvmhk49sZMGGALC+33Ndpmd7SUwmrbeNBWiV8vM j5gdclkuXY9sfSpNOEA0MZ4uhRIMTZC3JrSiUueQr5MyXeBJ/l88+cpJcXv+sSEG4htjCJgF5vZ u/VhSGkKOQbJmCuD6zDpsYxJPQZnbUas6it4zpsO7vTDz/I+UddKVd3hK2AaGa2qI24Rcgnl1Gr JGVnC38RrWFd/UFJU0dudGhWWcJohCeUhQEbvLnh6XrY4SGcEgHv/Keagdt8Y4= X-Google-Smtp-Source: AGHT+IEjmidA5pwfdhfSFgiKX1B0pCEagcknIY2hHbH/vUENtn6//aEuZmHFWCyvUlJlIOg4H24JoA== X-Received: by 2002:a17:906:9c2:b0:aa5:1cdf:7c02 with SMTP id a640c23a62f3a-aa51cdf8321mr997893166b.3.1732565925297; Mon, 25 Nov 2024 12:18:45 -0800 (PST) Received: from localhost (109-81-88-120.rct.o2.cz. [109.81.88.120]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa545385bbcsm259975366b.185.2024.11.25.12.18.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Nov 2024 12:18:44 -0800 (PST) Date: Mon, 25 Nov 2024 21:18:44 +0100 From: Michal Hocko To: Junjie Fu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, dave.hansen@intel.com, gourry@gourry.net Subject: Re: [PATCH] mm/mempolicy: Fix decision-making issues for memory migration during NUMA balancing Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4C48D18000D X-Stat-Signature: wzqcywty94aecpk8qw8zstunoi83juzn X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1732565923-663897 X-HE-Meta: U2FsdGVkX196VbuzuwyI16lk8rCooFtWagPE/jemtfuCBzr4cs8VQyy57K1k8bAJDjIhfS3xzXIIYuElbM/vdEhI6fpZhlmW9zMnEXb0N0LEmRJtsAhzquKagKUmz8KtYXmlnxNjY/WYeqjzf9kwxyIf43HrsfbsEIELYQ4DM55DWSqEy0XxrsZ8n+XtY63QgGgoCRfq0DciFnynmeVoN4/mFF9P1Cg37BS8csEkKJ+/cdHzbtaHxD/h8tOUV1dHnilfsqN2AQVsoSpD+vY5DqLIo3F8xe7Rpwnpg5fHJZdoraBmqlUXnG2As/UTQcc2+e29crpX5AkzbSqE4A+3lXrWS3jF+p8+DpErgT5TXdVNPHPCaqBS64CLQYU5/2iO44LkEYECjVfwd/37E5Lk+aCHdcN59KxJRVhSaWXGf5wzsmrLJD6cbziTPZkyoUGWX8sRLB1sPu6+wbEtjrbFyv8zFCAgtL9gVY8bX1mgzU1tO4KHyADMwlk2cAfDu+N0TmwoJF1WlUJ5VWzDx5NK/gl2ZD5UVi+VBiASYEAz5W+SfhaKA2HsBpjTnO0DUa0hDTZAuJXjmU6QIqKaFDbNkBjSEkX18ClnV7FR51Jfq5pn4YjbFU2n3E9k10/pvwT/DMQkzcfmkUick8RHK0GRfyvxe2qvOXoXZZIRkuqlNSA2qjQPk5N2MXo+XW3exU6wHvLCv8r7zzyZL4nFkl3hv6wYvGu12Du3B+R0SOpVl0SgVNa9gOqaG/YSn3iKa0MWLBgO/n3WB3tmMlhCvJHTlCDFnKf8S2pbCEu+3pD2r/a9OzERwhvKYKlD7h6uStjM697tsJa56zunCKYfCp9zjTmN86Ak8Bu2xPALCuOFi4bz+i1cFPZy1GKapUbJsuKX8Ueso33uZwYYekvDUvD4r9OvIgrKRJZk+qTGZjms5rHkIxNFibkMUuok5QATpAI+RI77aWXfAAEtirozlGT E9JfWF9s oVfELowh/mw+x30BMKvgVM73pLfGgW4dJDYZffnPZdRDewea+szkeH8OttzBNWuAMKvQqAL6dw2hDMqty1W8HQ+H9m2ZEy3kt6BCi+2qc5ABuxIq+VCNCmVQabkvU0nedfvR8mi49iaMH1tf2nXy4Sf2nouHl9vShv0VexA1TLdVQGs9J5VSDSmquKShCMRmYn5Wvn/CI7q5x7C94t4e7vz3wBBB0L3xAG+m3DpzIqKbK9BKvgp8RR1p/Fea9ogzwVvQOGxvW1+AHtpEOXsT5/qNDugsZYkx5GUzg7Ctd+HMKxI6iZzkDiqVRIw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.428254, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 26-11-24 03:45:01, Junjie Fu wrote: [...] > I apologize for the oversight when reviewing the code regarding the process > of setting only the first node in the nodemask for the MPOL_PREFERRED memory > policy. There is no need to apologize! Really, this code is far from straightforward and it is not easy to get all the loose ends together. What helps though, is to help reviewers with the problem statement. It often helps to state whether the fix is based on code review or it is fixing a real life or even artificial workload. -- Michal Hocko SUSE Labs