From: Michal Hocko <mhocko@suse.com>
To: Junjie Fu <fujunjie1@qq.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, dave.hansen@intel.com,
gourry@gourry.net
Subject: Re: [PATCH] mm/mempolicy: Fix decision-making issues for memory migration during NUMA balancing
Date: Mon, 25 Nov 2024 21:18:44 +0100 [thread overview]
Message-ID: <Z0TbpP02utF1lBzJ@tiehlicka> (raw)
In-Reply-To: <tencent_52B8009E65148BE7B93C42479E6E642C0409@qq.com>
On Tue 26-11-24 03:45:01, Junjie Fu wrote:
[...]
> I apologize for the oversight when reviewing the code regarding the process
> of setting only the first node in the nodemask for the MPOL_PREFERRED memory
> policy.
There is no need to apologize! Really, this code is far from
straightforward and it is not easy to get all the loose ends together.
What helps though, is to help reviewers with the problem statement. It
often helps to state whether the fix is based on code review or it is
fixing a real life or even artificial workload.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2024-11-25 20:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-23 19:09 Junjie Fu
2024-11-23 22:15 ` Matthew Wilcox
2024-11-25 11:33 ` Michal Hocko
2024-11-25 16:06 ` Gregory Price
2024-11-25 19:45 ` Junjie Fu
2024-11-25 20:18 ` Michal Hocko [this message]
2024-11-25 20:41 ` Junjie Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0TbpP02utF1lBzJ@tiehlicka \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=fujunjie1@qq.com \
--cc=gourry@gourry.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox