From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2382D59D7E for ; Mon, 25 Nov 2024 22:35:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48D496B0082; Mon, 25 Nov 2024 17:35:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 416A06B0083; Mon, 25 Nov 2024 17:35:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DE126B0088; Mon, 25 Nov 2024 17:35:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0E5F86B0082 for ; Mon, 25 Nov 2024 17:35:51 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6C273ACF60 for ; Mon, 25 Nov 2024 22:35:50 +0000 (UTC) X-FDA: 82826075892.25.C910A2C Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf04.hostedemail.com (Postfix) with ESMTP id B4A0D40016 for ; Mon, 25 Nov 2024 22:35:43 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b="M/i8Kx2k"; spf=pass (imf04.hostedemail.com: domain of gourry@gourry.net designates 209.85.160.169 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732574144; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F0LEVVmh09qWTmRbUUXnS8M397YMXluTgjzA1Orh4xQ=; b=VfgG4mtfumzn2tyT75+ZQDrASdicTaSd5Z+6mw9Wa9E9oWlNzMT91+G14AIOnJcmhp9AB/ 7QCvD2+0z/gbgC9fIK2rHf8B6QDHgNN0cqWR+eic8RpvdZztZlfNy7c913Ey9OhFDBAgv6 GqXtrcpMGA7CMME/+iGra39lj/hSvDU= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b="M/i8Kx2k"; spf=pass (imf04.hostedemail.com: domain of gourry@gourry.net designates 209.85.160.169 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732574144; a=rsa-sha256; cv=none; b=AeG5I/WR4Bt0pAGgHmTSwoPmoZCnnqYGK2PvxAjNa6bFPjIxRGT2sQChn6HnlYO8tbV02P 1OGqOEmoVaDNOS6iseDgh0LRwmAh7wNIt4XpndL5ZAB0aO9JasqxN866FOpDNMEVuqkv+8 pKHqbRuekO8O82fvMJUXKGhU2qjUd50= Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-46684744173so23788371cf.3 for ; Mon, 25 Nov 2024 14:35:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1732574147; x=1733178947; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=F0LEVVmh09qWTmRbUUXnS8M397YMXluTgjzA1Orh4xQ=; b=M/i8Kx2k+KO3OzjjGtaDaUKD1biZC1HLtjHN6Xv++cosOJSLIpf0yRhT+Xi1AEN6sF +Y3ubP6MzIOAoNeChGQzTwLw4KQmYPZoWPGifvezMIYLHIIKSRyfX3x73ae+xCY6sLi3 vEhYlVmfnaiNXWIqyerDYO90EuOrwSOx62Ciyh9Ve6b+GiPdQamZNXwmrnr9juqQAgj1 mYk2wMSUnaUAnb7/g1qeKnizX1XE3wUKt5C8YyEEnKBgHERSAJzCLODpx628emYguZ9V TYYh/k+ATn5/royYFJ3eTpfSinNXwd7WCNI1lv/jI7CuIpqxdGPrXNR2XLc0k46Do+nC 9QOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732574147; x=1733178947; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=F0LEVVmh09qWTmRbUUXnS8M397YMXluTgjzA1Orh4xQ=; b=QkCpiCdrhJdAxxx/X+qYc+MdLUQsLivm5zVGXqjHgJa7rKgrwaiUDNsx5PjZrZ63Y2 /x5ascRsK3j0NzKG+3/Hu7g6bhE3MEMPS2f5GbemKRIV5uo6SoSSieimodxc/mVcc5aq L8AsIlghk2ZPMy3Zhlmrvf20gSztUxT/1pUALpeA40Y5Bie+x/+lr2nvchEWUsDwZkM+ MGzLpdXaBC8ePjauFNoqiaTfAqcNa42o9XI+KvTYtHKHQR6H8N4u8h46m0Ao4BCki5eb iLtJ4q1FNAGxWUWhdn747w1khVg7FAHJQYpn5bdZQuCHNTSyM0SbiSLX/pZWDrZew0XL lPxw== X-Forwarded-Encrypted: i=1; AJvYcCXynULIyd2dxw8YV6ZWdmMJWsKhx/ua1/PkH4+heA2wZZahZmpGpuI/vRL7ECSoRJ2TBKlUvv30FQ==@kvack.org X-Gm-Message-State: AOJu0YyVSoRwJo6RcuFqsLOUqgLrybQPyqEBj4Iy+1QYn73JoPJNtobb Fr7B19xwuNScn/BhMEWe4ByR66SwhGKWfZbSKMlBF5joZJBypwEP73+UkOc1ET0= X-Gm-Gg: ASbGncst4gzTY9UwTL/cSf81D7T0EgpFts15GnNli7IdjtARIVGatt3xrEGV6rYG438 jUo1D/xKtVuirMj93+WkI8Ywomu2AzWWx72EHjSGJH043gqeT74yt3QmgVq0JchJe7jXoWVT0Ea /8hXhCd3xLeGgok94i19ERkAweQzlyHOB8jl+aKVN3uieiQnCMTE5pqkh494Afz0g7mh19k6FW0 /Tn42hjVPLXYzs/t+lxDjrTFCBD0kr6MROnU8CzBBh6wXIspYIjyIFcCd41KRzMfbPmacJmV57S lYK3jxci46vfEswO2BfmmiMRIdWiwCGCKqg= X-Google-Smtp-Source: AGHT+IH7fIwbkI4uH8JkSw8OIkc51k/5IJgozs97dQO+2GrBwa44CknCf+8EgNq+gOdx+sWFIvRlIQ== X-Received: by 2002:a05:622a:1917:b0:461:1361:eb14 with SMTP id d75a77b69052e-4653d5225demr239121711cf.2.1732574147447; Mon, 25 Nov 2024 14:35:47 -0800 (PST) Received: from PC2K9PVX.TheFacebook.com (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-466a47fa3f8sm2743791cf.69.2024.11.25.14.35.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Nov 2024 14:35:46 -0800 (PST) Date: Mon, 25 Nov 2024 17:35:31 -0500 From: Gregory Price To: Dan Williams Cc: x86@kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-cxl@vger.kernel.org, kernel-team@meta.com, Jonathan.Cameron@huawei.com, rrichter@amd.com, Terry.Bowman@amd.com, dave.jiang@intel.com, ira.weiny@intel.com, alison.schofield@intel.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, rafael@kernel.org, lenb@kernel.org, david@redhat.com, osalvador@suse.de, gregkh@linuxfoundation.org, akpm@linux-foundation.org, rppt@kernel.org Subject: Re: [PATCH v6 2/3] x86: probe memory block size advisement value during mm init Message-ID: References: <20241106155847.7985-1-gourry@gourry.net> <20241106155847.7985-3-gourry@gourry.net> <6733c9d135589_10bc6294b6@dwillia2-xfh.jf.intel.com.notmuch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6733c9d135589_10bc6294b6@dwillia2-xfh.jf.intel.com.notmuch> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B4A0D40016 X-Stat-Signature: p15d9pdpasqu4exrcytuzri1xxzrjbs1 X-Rspam-User: X-HE-Tag: 1732574143-282609 X-HE-Meta: U2FsdGVkX19meyIoN/XuUsb++A814vy37tCJ0dHSmQBiUKCBKOLvZ6qo7l9ka8WaUxhOG5cobndbXgC0bhC1hewVasLuRdf2/9Rc6RIS8RFlZCd/bXXQah6uCPzkGfQ/8GRCDnE2KO0qe9EtpYWnlPDwIWE+ISG4SrhQ82Q6QO0FXrrpYbt1Y39R1cGszsPvh8GXIdeLOoPIh5jcAYlX3qILnSpclSM9HQ4WPO/jHd/tjDZ/VsEcpm17ARJxD7TtFPXTuPhdz+uHMYSl9gGOiAG+vnsVG29PIhedJ6RZ4iaULHoSu5QIM/9qwVSs6SzBXwGmm76GSw5RGTdn6Uk3dDHdnp57a6/XCRO/vNwqaKpP83hx0GMyS4x8guEsaXqws8aIJA61qFwW3BGzDnT39Shq7IGY75exxeee6WijOXAzb+rj+mKUC/7LrcPwIvugO6snmKOZHA5uoMs4J9hBHx3GQn3TCDxy5O8Z7bBoqvLoFitwx8FcCzkrEkCW6uva1jr9TJKWy6TU8qg8RfMB1JmiCxHnYNRE7Mnp6K8oF57B+8iAikOkGNjjB0qam+NHEImeQl4mQRWB0ZMNcK1Ngo1840mINe/wH8IfHUNhwrabLC/fEbzHAaJeWMexfZO2RZSJrBgZQ0cQA3LPTPSljtSor87s2W3GLhkrsonDP2gF7tQrirnWs2RPa1h36KLXVl9Ti/4rWC1yoO9uDbYbm2Vhn/ANAhs2zC/0+Em+PBMjHeMHFuedqI223IUctGWmwcXFtGiwoXtff/1u5xrrBekuqcFdLyLLT8aGbwmA8H5meKKBnfHGD7BJ9NVbpCb5sMWTn7uUU0xnvyRObfRnt2Lq2ipN3P1G5wKykcQVygShj2qeMWHxSEZMau5nZXOgp5V/XKtP/aHHwoW5ghgNroJdiYOJfGwvsnjaU/l0bA2sA0oGtzGtUOguPVQMhnHwbbKSsmi+kCNQ6uuMWpM HjPeNG0j CKSqOjzzpGfXQ67TBl6+Kn2nepqQRHPRZaM0QJ8tXJVkw8JadNygYSTGuGeflPCikYQqNnifwVNnIPWg9wBIT408INXSaSgMi1Rr+5u2cF82AZkwPUOVY/dAFodx4OXK3tadOAH1I6lQDUlU3zKYXyjl4kSVuOIScX+/Oz9rv4czRSofSlcUOzNvNzYsYFhkJqCznjxn9rgJj06VsQv3ZalF+lOyho+1MSZmBevV6CIf33a97IpLAYXfkgHuBa9yaW2EGX+2Y/Oh8z3+8W+ssJyC7uU13w1Yvyq3f X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 12, 2024 at 01:34:09PM -0800, Dan Williams wrote: > Gregory Price wrote: > > Systems with hotplug may provide an advisement value on what the > > memblock size should be. Probe this value when the rest of the > > configuration values are considered. > > > > The new heuristic is as follows > > > > 1) set_memory_block_size_order value if already set (cmdline param) > > 2) minimum block size if memory is less than large block limit > > 3) if no hotplug advice: Max block size if system is bare-metal, > > otherwise use end of memory alignment. > > 4) if hotplug advice: lesser of advice and end of memory alignment. > > This seems like documentation that also belongs in-line in the code. It actually is, just ahead of every check instead of in a numbered list :P ~Gregory