From: Gregory Price <gourry@gourry.net>
To: Dan Williams <dan.j.williams@intel.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, linux-mm@kvack.org,
linux-cxl@vger.kernel.org, kernel-team@meta.com,
Jonathan.Cameron@huawei.com, rrichter@amd.com,
Terry.Bowman@amd.com, dave.jiang@intel.com, ira.weiny@intel.com,
alison.schofield@intel.com, dave.hansen@linux.intel.com,
luto@kernel.org, peterz@infradead.org, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, hpa@zytor.com, rafael@kernel.org,
lenb@kernel.org, david@redhat.com, osalvador@suse.de,
gregkh@linuxfoundation.org, akpm@linux-foundation.org,
rppt@kernel.org
Subject: Re: [PATCH v6 2/3] x86: probe memory block size advisement value during mm init
Date: Mon, 25 Nov 2024 17:35:31 -0500 [thread overview]
Message-ID: <Z0T7s7_j0_FCtihr@PC2K9PVX.TheFacebook.com> (raw)
In-Reply-To: <6733c9d135589_10bc6294b6@dwillia2-xfh.jf.intel.com.notmuch>
On Tue, Nov 12, 2024 at 01:34:09PM -0800, Dan Williams wrote:
> Gregory Price wrote:
> > Systems with hotplug may provide an advisement value on what the
> > memblock size should be. Probe this value when the rest of the
> > configuration values are considered.
> >
> > The new heuristic is as follows
> >
> > 1) set_memory_block_size_order value if already set (cmdline param)
> > 2) minimum block size if memory is less than large block limit
> > 3) if no hotplug advice: Max block size if system is bare-metal,
> > otherwise use end of memory alignment.
> > 4) if hotplug advice: lesser of advice and end of memory alignment.
>
> This seems like documentation that also belongs in-line in the code.
It actually is, just ahead of every check instead of in a numbered list :P
~Gregory
next prev parent reply other threads:[~2024-11-25 22:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 15:58 [PATCH v6 0/3] memory,x86,acpi: hotplug memory alignment advisement Gregory Price
2024-11-06 15:58 ` [PATCH v6 1/3] memory: implement memory_block_advise/probe_max_size Gregory Price
2024-11-12 21:28 ` Dan Williams
2024-11-13 4:14 ` Gregory Price
2024-11-06 15:58 ` [PATCH v6 2/3] x86: probe memory block size advisement value during mm init Gregory Price
2024-11-12 21:34 ` Dan Williams
2024-11-25 22:35 ` Gregory Price [this message]
2024-11-06 15:58 ` [PATCH v6 3/3] acpi,srat: give memory block size advice based on CFMWS alignment Gregory Price
2024-11-12 21:41 ` Dan Williams
2024-11-12 23:47 ` Gregory Price
2024-11-13 0:12 ` Dan Williams
2024-11-20 19:20 ` [PATCH v6 0/3] memory,x86,acpi: hotplug memory alignment advisement Fan Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0T7s7_j0_FCtihr@PC2K9PVX.TheFacebook.com \
--to=gourry@gourry.net \
--cc=Jonathan.Cameron@huawei.com \
--cc=Terry.Bowman@amd.com \
--cc=akpm@linux-foundation.org \
--cc=alison.schofield@intel.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dave.jiang@intel.com \
--cc=david@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=ira.weiny@intel.com \
--cc=kernel-team@meta.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=osalvador@suse.de \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=rppt@kernel.org \
--cc=rrichter@amd.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox