From: Matthew Wilcox <willy@infradead.org>
To: Junjie Fu <fujunjie1@qq.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, dave.hansen@intel.com,
mhocko@kernel.org
Subject: Re: [PATCH] mm/mempolicy: Fix decision-making issues for memory migration during NUMA balancing
Date: Sat, 23 Nov 2024 22:15:56 +0000 [thread overview]
Message-ID: <Z0JUHBJ5MOKF1n-k@casper.infradead.org> (raw)
In-Reply-To: <tencent_57D6CF437AF88E48DD5C5BD872753C43280A@qq.com>
On Sun, Nov 24, 2024 at 03:09:35AM +0800, Junjie Fu wrote:
> Because the definition of MPOL_PREFERRED is as follows: "This mode sets the
> preferred node for allocation. The kernel will try to allocate pages from
> this node first and fall back to nearby nodes if the preferred node is low
> on free memory. If the nodemask specifies more than one node ID, the first
> node in the mask will be selected as the preferred node."
>
> Thus, if the node where the current page resides is not the first node in
> the nodemask, it is not the PREFERRED node, and memory migration can be
> attempted.
I think you've found poor documentation, not a kernel bug. If multiple
nodes are set in PREFERRED, then _new_ allocations should come from the
first node, but _existing_ allocations do not need to be moved to the
new node. At least IMO that was the original intent of allowing
multiple nodes to be set. Otherwise, what is the point?
next prev parent reply other threads:[~2024-11-23 22:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-23 19:09 Junjie Fu
2024-11-23 22:15 ` Matthew Wilcox [this message]
2024-11-25 11:33 ` Michal Hocko
2024-11-25 16:06 ` Gregory Price
2024-11-25 19:45 ` Junjie Fu
2024-11-25 20:18 ` Michal Hocko
2024-11-25 20:41 ` Junjie Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0JUHBJ5MOKF1n-k@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=fujunjie1@qq.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox