From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34CF4E6688A for ; Sat, 23 Nov 2024 22:01:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 815106B0082; Sat, 23 Nov 2024 17:01:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C4DC6B0083; Sat, 23 Nov 2024 17:01:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 68CB66B0085; Sat, 23 Nov 2024 17:01:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 49CAD6B0082 for ; Sat, 23 Nov 2024 17:01:37 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E7354160C17 for ; Sat, 23 Nov 2024 22:01:36 +0000 (UTC) X-FDA: 82818732192.18.4A741EC Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id AF8EA10000A for ; Sat, 23 Nov 2024 22:01:32 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=miJvszto; dmarc=none; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732399294; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VQAlmEJeN3UupymFJIVdz7z6mlrCIkMM22mcn6/6TAo=; b=HusESIZWGRpD9RCSiRcULigUyp5TNow7WK1Ilkdp+OxQQUqRVsQ3tjDbmW/qoNwsE8nJv+ Em2Ru0GvSx8vHwHYBB4Kxcx0vOyMQj0rBbXWu9gqc/o/rwEsw+wEB8a3YeD6CDech03jli Gd6ByzYWxR4mtqYXlEfCCPF7PPsGYTc= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=miJvszto; dmarc=none; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732399294; a=rsa-sha256; cv=none; b=1mH979xb7iTqw4wXCDuBH6D0QD88P6eTxefVTCNeg5lQOMEDEjNyzfe0cXTv1HUJ+CMTGL W2R8I6hOLDHqH1rRTKeO1uBbz60fgMfGN+E+R2iom+ausu630zmj4uAggAuXoCW7rJlU3Z hZB7vhVgd5hYq2cxMkLSttqxhbdmNSg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VQAlmEJeN3UupymFJIVdz7z6mlrCIkMM22mcn6/6TAo=; b=miJvsztoQZsdcENufr3Tb8L/Ag R9Vv8WYiqSaonaV/loGtNzqRkrzer8ucNVzz+E8Xd2+cLL3CIhfoRkjts4WayX3tbplkB4OnywcAi 4PuSchLjfusLFGPu+eJR40hZahvPx47eWDOqezcBUTbVcZ/Zofx+sIb3MNP+SqwA6iqd3jBtC8gSg 6/DNdXyBVbZAJ2lERRmI1p2ripKAOoqFRhfo2a/BehYySw0SRAl3HtOSah4D3s6gRJFK9I2SZsj+N YFbQ1WHZXp0+l7BhNNGvnBdo86t9/2PW1TTntU5dewsjZUkH0vgfZw4gcE5Fz5hZyBIoYj5xXWUqB yP8znscQ==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tEyC5-00000009gaW-0Dk9; Sat, 23 Nov 2024 22:01:33 +0000 Date: Sat, 23 Nov 2024 22:01:32 +0000 From: Matthew Wilcox To: Andrew Morton Cc: Linus Torvalds , linux-mm@kvack.org, mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [GIT PULL] MM updates for 6.13-rc1 Message-ID: References: <20241118193001.6aefcadd7426feafedf824e1@linux-foundation.org> <20241121214229.8fe091954f9bf0d26f54ed88@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241121214229.8fe091954f9bf0d26f54ed88@linux-foundation.org> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: AF8EA10000A X-Stat-Signature: oy8w78j1sfmjxwp7fwnpq9pi18ge6zp8 X-Rspam-User: X-HE-Tag: 1732399292-599381 X-HE-Meta: U2FsdGVkX18+sFNQYVYiY6AFVL66WpQKCCi952+rdXx58F2L/7Q0NADsMPGAtsNxAiph2R2ktgwRcH8a/saH2jdEPf8gqIiQ0xcYBRvKrUbCR/3Y+gRPgqZWbzdsFEs538yKhGFANu6Uqz6tubvwedJcW8H+p6ZXXMYk/J68yxaL+9ZtxS5cIbt+uFbB4amIMBT6/NGoeTU5u8XXuzuGGFkcNXWnzz7bjljdcbrru/wiSt2PzXNhusnR+7KaDRaU9O5YRx5YB8nuw2mbs9njvQKowTJbQOtd5Ol5d2OFumsVHovwJXzs2P+acXSyuBAEhLL6O5nG/kcIbJ9hDUdZoputq+vACbUzsO6QhbE0XoZ65pE9swihdzoC+wGGw1HgEhOZOVAgk4i49VDfgTbHMP8yh/xs5W/xIMs/txWpwQwWDIgJ2NO6wEeA9/T9JQsRP7jAE77Jb3JP79gyeGo8rLGFIfkVEwBRZdhvqps3oFLqkp2tWO+I+9+TqmpPTjqfTU3jARsHaZbYlddIEn/0WMzzLCl3ELYY5jUbQQ38It3BUqgAT/VcYv78io0KB2ELhNgYZB/brdGC9sQ2wNFcgkomvZhfDxGdN4fy6uD+s+CMGsb6lx2gvDR2gCQZWUxRM33Y0jnDnDP8/1OlrHgFZkMC6+wstipqF9OcumRBbw2SUolK/ywIxVVvW9Znpwkdft2qNuPI0p8AWMkLIirRT1QR2Ek+ccFVN5T8RppMJN6p0LRnORfJxYlnUJN3WpabQ7aiXehZsrJyltsIUz8Ka6cLtJS7WCSr3vYWOTtmKt/Crh26BS6DQ+C0tnL8p1mlV/Oq23pAFd00nfTGMs3si5nWlvgEB67imW41SAsR1+SVWN+MJcsQijDMRL09IMq/F5rPiiG7En4cv4T2YOvbGUWazL5ZlC6oWdQTvMQDY45bjvE1jjgHST5MKzRA9jUAb4JsoDcp4eNZ1tAH37W PBsMQkol ea2OyAaQrsst7MoLKOUPTiTFcWFHhczDamQeojPDugeazUymTgpQrBU1t4SPfSrztmjV2WXJ8UVRcoFqAGCKLHTJ04tO4nhHDUS+eouXo7WDPPbzSUm/gtTC+6wIriwS0+XRvUVbIOJM2GOUAiC4fXbQ8VzrEeWbZm0dL/bwYfi3QNCaeXKR0RxDCWs3qJcGWY119CQcCBb2rTfYwXsAQGFdjOe+eAbgBiHBl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 21, 2024 at 09:42:29PM -0800, Andrew Morton wrote: > It isn't only Huawai people. David acked Gaosheng's patch and it snuck > past me (again). People keep on getting tricked by this idiom and I > think we'd be better off with some nicely named wrapper to help > readers understand what's going on. This whole discussion has got out of hand. The solution is to divorce page and folio, and I think we can get there in 3-4 more merge windows, at least with a CONFIG option. And this is where &folio->page is USEFUL because it clearly marks all the places that need to be fixed. As I've been saying to people all along, while folio_page(folio, 0) and &folio->page are the same today, they have completely different semantics. That hasn't stopped people from getting it wrong, but some people can't be helped. Don't bother coming up with clever new ways for people to get this wrong. Let's get this project over the finish line.