From: Matthew Wilcox <willy@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-mm@kvack.org, mm-commits@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] MM updates for 6.13-rc1
Date: Sat, 23 Nov 2024 22:01:32 +0000 [thread overview]
Message-ID: <Z0JQvEK5jcOSaKsB@casper.infradead.org> (raw)
In-Reply-To: <20241121214229.8fe091954f9bf0d26f54ed88@linux-foundation.org>
On Thu, Nov 21, 2024 at 09:42:29PM -0800, Andrew Morton wrote:
> It isn't only Huawai people. David acked Gaosheng's patch and it snuck
> past me (again). People keep on getting tricked by this idiom and I
> think we'd be better off with some nicely named wrapper to help
> readers understand what's going on.
This whole discussion has got out of hand. The solution is to divorce
page and folio, and I think we can get there in 3-4 more merge windows,
at least with a CONFIG option.
And this is where &folio->page is USEFUL because it clearly marks all
the places that need to be fixed. As I've been saying to people all
along, while folio_page(folio, 0) and &folio->page are the same today,
they have completely different semantics. That hasn't stopped people
from getting it wrong, but some people can't be helped.
Don't bother coming up with clever new ways for people to get this
wrong. Let's get this project over the finish line.
next prev parent reply other threads:[~2024-11-23 22:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 3:30 Andrew Morton
2024-11-19 4:35 ` Matthew Wilcox
2024-11-22 5:42 ` Andrew Morton
2024-11-22 11:23 ` David Hildenbrand
2024-11-23 20:30 ` John Hubbard
2024-11-23 20:57 ` Linus Torvalds
2024-11-23 22:01 ` Matthew Wilcox [this message]
2024-11-23 18:49 ` pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0JQvEK5jcOSaKsB@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mm-commits@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox