From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9ABAED75E5C for ; Sat, 23 Nov 2024 17:02:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1C9A6B007B; Sat, 23 Nov 2024 12:02:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CCF46B0083; Sat, 23 Nov 2024 12:02:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 894566B0085; Sat, 23 Nov 2024 12:02:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6B14A6B007B for ; Sat, 23 Nov 2024 12:02:07 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E4EF91A1726 for ; Sat, 23 Nov 2024 17:02:06 +0000 (UTC) X-FDA: 82817977452.29.AC419E1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 5F4961C0005 for ; Sat, 23 Nov 2024 17:02:03 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YbYJmpIk; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732381324; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q7pTiwXFRCHeq9RoohiLO/XjDHdz5wqm9X4ST4ceCus=; b=JBcrLATYGAo4f2V8zBCgHuchKUjGjxUKQVziZW8geDx50LC12c1oIPMYofhQBxS4IKXwU5 CgVggwdmC14aYXXNMz9ML8aiI7Vo/dauCps65ikqmI4rZJpdSmAqTjgrG+9PQlVOCblKlN njmUM8uMKf2aq53kwz43WM9cVD1MCCI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YbYJmpIk; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732381324; a=rsa-sha256; cv=none; b=sDqvi4WqWn0yRMfivtlp/pi8B9Mt6XrwS5CjXR6ONRyoTtCMYZe4jvmaHn/71hi/fPETqp jOt/z5CJbKrWHNG2V8cuxILIiM6bq7A7mWLtKuCg5mp6ebYV36nCp2PVRl/r669n6RT431 BJbyR6oSg80lVHzoZepQyHPoTHnPAhs= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Q7pTiwXFRCHeq9RoohiLO/XjDHdz5wqm9X4ST4ceCus=; b=YbYJmpIk4LEruXT9q9jYZKENPl vA/5Ou99f2fM7lM4sJfgEuOF7jLcuRLlMdiG5s8xvj7Q/bAs2Qa+pFpXeMDcJm6TLlrCB5iAMyo6c lcpmlu8Td49O3Om6jeD3gpYn46VGBzhwCJalc6WAWvgc+T+7ItfcwHU2x9VTM2ISkaMRGnu7wx9sn X1jGmGw6da4vjnb1tsxfBO7mREvUEbI2z6YVqLWPfL7zX1k3qiJS4WzKq9NVlSmip7F4cS/6qTrPH zzNjCdMeujScYyNK0i7U00F6hdf2p5oiJH4rtSCdm6qBkCPud1Mee1HjblgkwnuwgfV6czl6AFlAx jz4uqvMQ==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tEtW9-00000009PKr-2Xb1; Sat, 23 Nov 2024 17:01:57 +0000 Date: Sat, 23 Nov 2024 17:01:57 +0000 From: Matthew Wilcox To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Vlastimil Babka , Axel Rasmussen , Steven Rostedt , Suren Baghdasaryan , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [PATCH] mm: mmap_lock: optimize mmap_lock tracepoints Message-ID: References: <20241123060939.169978-1-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241123060939.169978-1-shakeel.butt@linux.dev> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5F4961C0005 X-Stat-Signature: 7ixmooxe915pee67zuzjrbebi9uerf4z X-Rspam-User: X-HE-Tag: 1732381323-349821 X-HE-Meta: U2FsdGVkX1/QA4N+BcidqVrqt8dOeqtJh8TQ5jrgiEEvc5N6Q8686T76t40eRpjUTZL49n3C44VhTTXXWi6m3uxod9uueYEpN6Z38A57AlM5n0gDcvK8dwxxEP1SJ/70atQ696ZBK93llVBo8j/RTFVY/z/uC/gje8f9nrZZ0xS3VRMqLi7PlU829CEnIQI+KRYJx0Dr2C1dpAwQgrvziWmHn1ThTErKuXDhRYsYy5Y4N73gQayUl6pan3HRcu091lL9NrKD0iR7aSNBBARJPkAbsxpfa1a9E2uOx1bSGX9E8XTvsfilujm9wGE+J0hRQSQS0mjYmvkYhNhhtMV3D4aqD19VUEl7NzL7jqwdWc7Eu8YnUYRZr8VSmdvcDZQtV1fXR4NZSY0IAY5jnXaKuMlvjRMtQrm6WRt07NZi9Mx04JuQvlXSUnkeNpA2s6v9FNPN+pIN2/8WEbFkEj2ctsbvRvCWmYuY8YGF9ZHPF7CRtpWJKoVrpoqF3rvvJRAC5eLozHPmUm0gTuXEwnOibX8VEgpnF/89Q26toanA9H+kNRFR8U9K/sSNvbFNWhc5tIlKiJ2VRIDHkH2vJOkvMJZ6Q/WsvJggopg0U0yQZXNW0bBlVhrGxhcSm4xU49g5kE41yfCCuheJX4F1or86JneTMkzahKhdi6AKllC6tCnkid30KualNJj8TeZCjgSLzrwivg0z6ze4EIxMtfHoMQocbWwWOoLHClfWz9reoFo1QXI45u/IrtlnSvVU+D3RpGCVHGWWZ6QYvhUEUPghxVKcQk4ZDg+m30EqLB43ruJlnk6JZt2+RMxuGHrjXQ4BgNWpyJWysp6lCx3fXeUrHOSFbheCAVHkrV1IhS73QqX1G0FqrlZZ3pt240VLV1B1KelI9pEXUZoIpEW8ENsfCZv/C+VrX1jPpXCUb4KC9mBoiqQHAnN3HP/mf/3W5wqwk65ztDw/qqWZODWrDSG 4edNYN/u AAGHuTH9z3FsMIGqRt+npNBMw/kW8mKX+eo/gbzJkoSmMFzYsudqkRrDPIbZKXU0ArEtjntbl64Q3boOTkTefpZ3/UV1VlHPNJV8M2MVOkYRqIX4bxOHAO6pRndIOJcH7gYBZF9Hb5OFhsVuzPJHDrCaPXnB4fHS+xZf1URBq3YqPki25JwQsgDpcI4UZ77/VrBmgdOeCDOZrv5W/JZQQ6HYnkybEWY8e2tEE0LMMKBCMm707HreUwhZ5sAJQSAYIGlAPGD4zReTMxqyfE2X8Ro/beA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 22, 2024 at 10:09:39PM -0800, Shakeel Butt wrote: > TP_printk( > - "mm=%p memcg_path=%s write=%s", > - __entry->mm, > - __get_str(memcg_path), > + "mm=%p memcg_id=%llu write=%s", > + __entry->mm, __entry->memcg_id, > __entry->write ? "true" : "false" Is it actually useful to print out the (hashed) pointer of the mm? Wouldn't the PID be more useful so you could actually associate it with a task?