From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2EEEE6918E for ; Fri, 22 Nov 2024 19:30:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F24B86B0082; Fri, 22 Nov 2024 14:30:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ED4BE6B0083; Fri, 22 Nov 2024 14:30:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC30B6B0085; Fri, 22 Nov 2024 14:30:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C4E4D6B0082 for ; Fri, 22 Nov 2024 14:30:19 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 3FF2A1C8426 for ; Fri, 22 Nov 2024 19:30:19 +0000 (UTC) X-FDA: 82814720856.15.FA9A0B0 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id CF1FE180003 for ; Fri, 22 Nov 2024 19:29:38 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=KUzvgbhN; dmarc=none; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732303724; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ztkprX5jutqocexXLVcqCzsyxKcO7uHAEhhsDp96C+s=; b=qxIoPBFfVFqzV9GRezvZvvfY2hmIbSV28r7bzvNl+m0OqUDBrBsTpJVazxO3XKQm0zL26H EZX9DD8IT/TWilBak1fPBGfGT7MG609wpUbQFsrZ4nSUMz/y8o7tAgS3bLa+SRFSkCMfxj 1Z7cFlwQJr8sTMYzV1VkhemKQ0LHSzE= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=KUzvgbhN; dmarc=none; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732303724; a=rsa-sha256; cv=none; b=V8eRYax7RH4kyfNlJD70MBQkD7HO0F7lFLuAqTZgl/tARLOYC5Gw7R6d4jurKhMMVJSLCj ig3xzhGf+a7Yqp8JxwbPU7eiVdO5ON5t3DWX8+L2dJ98z5eQ3cQmRMQTiY8dWERVzGF4GC 9cVI/aUz6LkzW6MUQUUQ0HXBOlqDdoM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ztkprX5jutqocexXLVcqCzsyxKcO7uHAEhhsDp96C+s=; b=KUzvgbhNAlUBEtmaF9e4fBqURz bj0bnFo2mdNxSrXng3M5tESIzY+Xfb82vMLtJggPntlwQz5KCvMraF69t/rhIjlFLuXR5S7tvgD7O H/d72p7KYqb4jVL20MxK9IUW9VNlWzF/ltkWuIdfBdjiik/JQwArwsOMATy7FHrUiK0waEZG8+/6d gkygLH4TOPF8Xpe1TOtXcyoGX8p0/IKZlMv/b8toURshIUMP/J/onyX5RRqOZIqsxoobqLuzX+PoY z3YI60k7aNV4MKiyDhxG32b7TF3ZZWJ4zG1dthPjm8ZljWQFPahIK9qt1WO0QoyG9G1Gw2S7pms5h aCDtvD5w==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tEZLx-00000008CQ6-40BA; Fri, 22 Nov 2024 19:30:05 +0000 Date: Fri, 22 Nov 2024 19:30:05 +0000 From: Matthew Wilcox To: Boqun Feng Cc: Alice Ryhl , Miguel Ojeda , Lorenzo Stoakes , Vlastimil Babka , John Hubbard , "Liam R. Howlett" , Andrew Morton , Greg Kroah-Hartman , Arnd Bergmann , Christian Brauner , Jann Horn , Suren Baghdasaryan , Alex Gaynor , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Benno Lossin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, rust-for-linux@vger.kernel.org, Andreas Hindborg Subject: Re: [PATCH v9 8/8] task: rust: rework how current is accessed Message-ID: References: <20241122-vma-v9-0-7127bfcdd54e@google.com> <20241122-vma-v9-8-7127bfcdd54e@google.com> <6740c786.050a0220.31315a.5363@mx.google.com> <6740d8be.050a0220.30b282.4f2e@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6740d8be.050a0220.30b282.4f2e@mx.google.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: CF1FE180003 X-Stat-Signature: bm1jgrfaj81yosrbxb3izf8ahw8hyi7y X-HE-Tag: 1732303778-700726 X-HE-Meta: U2FsdGVkX1/81yY/nmEshrC2Zu6RypO0UYj5DZa6twHPQVtz8ooU5I0rRo8lsxFYfyOtso+8hOOvOhOi8XTltJCNBC4HzyrZbm2B23WU3e+E2pEID5oj2PZI89GT5v3gCwbdGdvq3rKZKE+GsgyYStNthCRCr1UF9UAOYH+qmO+XMmJVki++eugncx3hjSrzaHsgkAR3kqOBYZ0buWRdp+hxahN3r1pG7oqbQqnYFZJhoOCDicpCn7iOY8vnomX0SY6GGYticj79pmAH6eGYVZ3YDSh8kdDG58QyGuzc9HnBrCwVbU+lFd1uscrqlXQVHnXFCkEmNaJnLCe8Ujg0eYRzxUPaS9m+zXJZ4XZ6NaRzxC+ng8owRI7mP51qtXq5qshpN0u+AB2RTT+VgxTAtQA+v726nOcy1ynp7KpJveyd9BffzZjBMog+k8jet/MnllgQgCUo2oS56teBBVu+2kWAIk8yMxK4EWTgrg6mZMbGZkdhfjlrkhnFoulZAFKGkaD/f3MVp12Q1Rz47g8B2zhZhESj9qCdsogTnU3br+DSQIYrap++9Spf+xjXaXWIqesr54VHDOQ/E79F/0H+eB8hfrv6pFtTLFA2KIdDB/WLKww9SKaHFJiqWhsLk3JChtlg+jQ/px8stPMcWi+CnJK6eJC22tWxbL3p1cLqHAEccdUZCe9rxyhIF3IAtbx5N4RuyOY/D4ova92bo/wFWYxzto12UqXuJsHJPZJjGe8ChNMYTQ+7xvWydQdlCKeYBDiT50/mPiOCzT5uxp2AsJGojR0TFDFbhFYFaIvco1qfZPUP4u/bDoUBJQmEyEKJzOhwuGd5pP2kNFzYPaUl0jahUy6hI6TbmQqquRFCKonxlqtPh6mWUNSTRNdWpGItHQE7bOIdC59QCSBqDoirxmuvvDnNuCHbZN0mqWW5VjCqhJEbevGsIw25l46dOnIXUGsf8poghy2EvLo4PWA aOFF8m7e eNUvKrOAln8LPjLR66SVZa4i2iIXAmN59VLSPykQpiA8ffnKlfihFS4MuCfWyClstexASFWoXd2yyj7aFKUV+Pzo6OFl9u+TNaU9ONzbNQm68oqbdKNlLYtnwoYyhhcS2Oa0bv+l0G5H+n568e1yJBa0LR/32wswKgSgMGBTcQ0I0XmR8QsFaEQG/7unIGsuKyIAIGKPyQYhSIPA1uXYx7B30awWs1o96a7u1Xr0CUmsqCZM35ZeiodRmVKnfMjgucbVAyVnqeG9u5kz5yiuUJ2dh6Hc+eCgiBxHmSzj5i5G8xPE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 22, 2024 at 11:17:15AM -0800, Boqun Feng wrote: > > I don't think this is a problem? As long as a thread exists somewhere > > with `current` being equal to the task, we should be fine? > > > > I think I had a misunderstanding on what you meant by "operations > that are only valid on the current task", you mean these operations can > be run by other threads, but it has to be *on* a task_struct that's > "currently running", right? BTW, you probably want to reword a bit, > because the "current" task may be blocked, so technically it's not > "running". > > Basically, the operations that `CurrentTask` have are the methods that > are safe to call (even on a different thread) for the "current" task, as > long as it exists (not dead or exited). In that definition, not being > `Sync` is fine. > > But I have to admit I'm a bit worried that people may be confused, and > add new methods that can be only run by the current thread in the > future. I agree, I think CurrentTask should refer to "current". Or we'll confuse everyone. Would ActiveTask be a good name for this CurrentTask?