From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F513E69185 for ; Fri, 22 Nov 2024 18:03:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DACA16B0082; Fri, 22 Nov 2024 13:03:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D5CE96B0083; Fri, 22 Nov 2024 13:03:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C24606B0085; Fri, 22 Nov 2024 13:03:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A5DB36B0082 for ; Fri, 22 Nov 2024 13:03:25 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 260E8141846 for ; Fri, 22 Nov 2024 18:03:25 +0000 (UTC) X-FDA: 82814502624.28.4123799 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id 6788C180020 for ; Fri, 22 Nov 2024 18:02:44 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A+5Kb+tG; spf=pass (imf06.hostedemail.com: domain of jkangas@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=jkangas@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732298450; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=779BNLH2N6tx2iOCEXW0cNJ7EGBdC88+huie7WxmWzY=; b=zn0J3illn0NlDHppjJWb9WnAUGj2phTAjkUd8FITghjhXO1inxC+n1JMTNjTernEwE4FCH meRRXfLHjWumSeOFkytiKoVsyMKqJ/efw6u2VCBBDebcqBfrs4o0rQo376qtenoorDEw3L yWLPeEqsh/6ZvWotXNsvOMqM6hULBmk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732298450; a=rsa-sha256; cv=none; b=1c7TKK1h7UdiZgfnGAIwdmAmTecgiUL/BKFgzh5YXtQ3XXM8XUMs4TyRSOGEzsLbopxzsX /U6IZdl9WkTP4nOsBr9zljntycs+1j5VX/g6gr8aF6b8Qe/gKzDwlrez5l37WZE1dogFYY alOe4fklt2oeMfW8UgiE1kO4HDzawaY= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A+5Kb+tG; spf=pass (imf06.hostedemail.com: domain of jkangas@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=jkangas@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732298602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=779BNLH2N6tx2iOCEXW0cNJ7EGBdC88+huie7WxmWzY=; b=A+5Kb+tGNK4ndm3XARsXF+5OKBOXS+kRjsaHMouG9H8qCUT6uy5Z4McMkj7H86s927GuKB O//JcGnkUAarCBh9TOnJcZxFbLEMgTOJ8FATh/SJRFQMNX6ueRE/NdX/ixG/DMOFIYCEAS I54JT0I79cAu2NaYXKkpVdCMio+gFf4= Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-264-OhuM3NulP82e15VsAM7jjA-1; Fri, 22 Nov 2024 13:03:20 -0500 X-MC-Unique: OhuM3NulP82e15VsAM7jjA-1 X-Mimecast-MFC-AGG-ID: OhuM3NulP82e15VsAM7jjA Received: by mail-io1-f72.google.com with SMTP id ca18e2360f4ac-83ab4cadf05so239445739f.1 for ; Fri, 22 Nov 2024 10:03:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732298600; x=1732903400; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=779BNLH2N6tx2iOCEXW0cNJ7EGBdC88+huie7WxmWzY=; b=EvR/5Hzrm/QByjE6a+Q6lTwTQSKp8jOWXkAacpN39ROWoD14vDU7gJGpk0WFOOJiTL DmgHxTpuViZDOG5Pel+OGyEaZjYSv8n+W5gkBmxgIJ8bkpNClSSTwyp80hWA1zUzyasb 7wssG6ZJbPtcrOoJCo/8O3inWOnUQSv6uH07G0UOcv0yXZ4Wo+qh05AOyo5pNU9lFUSA EOxHjEhnKnNaz1DPAUs49cheQ6HCVxhsaHN0uCinm0TCSsN52pFntMv+vj/ihiQiKqPP UMLMKjXb8+BixhH1O8yZgzZpl5l8OhOmvbCSMzBBOFw2iQlRa+NYATBm3TOhodP0Hnw5 9qHQ== X-Forwarded-Encrypted: i=1; AJvYcCVN+cLjw1lw/AvVue6aH6x3My7lkfKA3IFSK4KJ5bM99KBRK733VkSQJLpSChYbZa7AK0RUHfadLg==@kvack.org X-Gm-Message-State: AOJu0YwWmeN6z6i3CcG+Le/47Jk5bPGmosFN1Z2kEymkcfyX6M8EplBg 4Mv6z5n+AW76AX8VD+17Ry6LBXsoRWGzk8IC7icnlRhxPyZTl+GrAnjoIIX8tYBOM3hhcHooFuA bjEdVYC3M1y4qJHjiVkEEyFsmuF8x9RsgKXR2YwrHrnnOHHZk X-Gm-Gg: ASbGncuc4C0ajH+W+R99wAgJyCTnsG+JM3jZeIVjq71KJhPCSezGqKb0eixSBZu8jNz 3C4CBQqwUCGWt/6cNSCxilQJycb5C/51qIEv8xRJ2/2qiMWaIRGQpvRDYK1fUGA0c9vDTv8veUw iPh55dq8g6SBKsofUe11EPiJdF6TZ7HZb8Qhn0v7lHCZeiZDGQ7/EmIc6AX3kW/MSwNKHw8C0KE fnqtL/Pu8+SwdxFPamlalomXVIjxDd4yvgd2SGjxem/p8u71zN2qErw7iMj+jGZzHSsGxbOvTvK 1qU+aQ== X-Received: by 2002:a05:6e02:1789:b0:3a7:1c51:f83d with SMTP id e9e14a558f8ab-3a79af1fe69mr43580655ab.18.1732298600091; Fri, 22 Nov 2024 10:03:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IErqQFPFZV9N9lMqdDfIln6Z9aT0JfSm6HTQGuRe4rEyAA79sNqU7IwmTnAMzFQ6nOexwbdpw== X-Received: by 2002:a05:6e02:1789:b0:3a7:1c51:f83d with SMTP id e9e14a558f8ab-3a79af1fe69mr43580205ab.18.1732298599649; Fri, 22 Nov 2024 10:03:19 -0800 (PST) Received: from jkangas-thinkpadp1gen3.rmtuswa.csb ([2601:1c2:4301:5e20:98fe:4ecb:4f14:576b]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4e1cff35be5sm726492173.155.2024.11.22.10.03.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Nov 2024 10:03:19 -0800 (PST) Date: Fri, 22 Nov 2024 10:03:16 -0800 From: Jared Kangas To: Andrew Morton Cc: ryabinin.a.a@gmail.com, glider@google.com, andreyknvl@gmail.com, dvyukov@google.com, vincenzo.frascino@arm.com, kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kasan: make report_lock a raw spinlock Message-ID: References: <20241119210234.1602529-1-jkangas@redhat.com> <20241121222809.4b53e070a943e100bb6f7ba0@linux-foundation.org> MIME-Version: 1.0 In-Reply-To: <20241121222809.4b53e070a943e100bb6f7ba0@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: jRisKjXro516ubDacbpJbooo35wVY9hxWkaVPOHWpEc_1732298600 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 6788C180020 X-Stat-Signature: 9dmdrz7ki6wba5xrju9zkiyzwwnjxteu X-HE-Tag: 1732298564-313336 X-HE-Meta: U2FsdGVkX18EgfbsMQQf+TvpDjaYJpXZtQEJuBh3l9qHK/0BJfzjd9XYfzoLLhku5jKYAvHWtdnlZZRq3Ja6WAyz48h2MTASoEMkSmRc6mVGCGTFDFlHvASkZimQ3envrf+nDzVNiuI2YK6RmNHF/GZEtDUoVSvziHevXmSRDT5wbjBLhLU98MaRdKWmxLAeM9S3X7i6DR2R46tqyEdxeTMYQFpDdkBLMiCe9i9JR3M4gQMb1d+FPdscs2QULg31cZE4h5Zm9qMAXutb+QnPtBdjCqYlVuker7Pd48gAU+fcKsCGy3pOgVdAw3mhqQY6/Nrp5RaRwWQMIm6HM/rOx3gCvCkcC9hzKVrPo6z+h506JCgfkQ9jizd5FZdkSJCLeaQbk6P43cD+z3NlTaDb5e2rAizMrNurrgnNALTPltY/002SkgD/DOYNp4rsvcCMe5W4gMXu7WysSl2Vxch0JapwIsIMwLHguFGG0F2HYXuidwpkSa2xKVk8x+WJCLLVZ7ACcZQ6KPe5I59Ia09qZIT8iZIGYpM/MmDNnyCiMlXEyaoMaQabcW2BL2WrUMHrU4MDhC7X5QBQsa4Ycsr2zQMsxWJeJLDxtzz8jgnPKVXU/yVYPO3K6VjElJBS4qMqHOppK5q4BBbAwxOnz6hLTpp++dUK1cD638pGRyCL2DskyUHwXwF7vW4k7MFgtdl9ZaN6MS4Qr0Jfsk/A3yPRupb3aNe0/eeYp41BxENSz3gIBD3WoDEberqF6CvfLBZVXxg2f27O0EyVQoSnNfWTKxhuN3fRPCmLIcxi8EFuEVD5oGXG5AcQNIgbPWxsiQLn6c+9+2ctHvYUTnlBiBK4p+gxl0uZPlSWqDVKH0HeER9ofCTv6SrEkrwhtH3ECR1bx7igWp5bMQ+RRZVBSN+lRM9vjzr9OGrhtFaZFW6ucVXYPoN0OGXyj0dYK6wztFoqEacVDlo0BSNmYfGxfkh 3nUMeG// YZKlq9XpsXUe7AwU8bbdarM6f/q6ahI5sACOJ+9rX19MGZJqTPhbyCC9CuXcvw/CJ6edV8eGn/QBeZk7sOI3GoWkL2axDQ9g9v/JvO1POF655hGx/cRH03q/7oupMYDdOXX9QvBkZvEnwPUryEbeANT/4kuu/ICMKhMtD8eT+K+3mWgAVCSxV8bQZ2QfvR3Eo0Ag83hmm1jMX2+aRbz4H2E0dhxpHS3URgGaekdgCAqPAMjS6w861COgM541Mvy2ENvPZLPU39PtcjP2NJyR70O9t9x9msKf+Vm/NiZ4Ux5LReztp1dvM9MMpobQVhZ8YQXLQB5go2ku60AKkJ+XKEj9E7PtqhQn40ml7GHWKjeVCmtHo73FZVt4UniK4zzFWCYDI6zrDYBL436Ks6ck8DRTpOWfC1v342iEYOeXSn0zQ3RtmCDmJFTqDh46UXccAuQpBy+JepX2+veejVIfCZ8wEVWRsxAnmajFM3vo4vEYzNIyvRKrQ+Xhig9zVXLOSS5Jl X-Bogosity: Ham, tests=bogofilter, spamicity=0.001906, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 21, 2024 at 10:28:09PM -0800, Andrew Morton wrote: > On Tue, 19 Nov 2024 13:02:34 -0800 Jared Kangas wrote: > > > If PREEMPT_RT is enabled, report_lock is a sleeping spinlock and must > > not be locked when IRQs are disabled. However, KASAN reports may be > > triggered in such contexts. For example: > > > > char *s = kzalloc(1, GFP_KERNEL); > > kfree(s); > > local_irq_disable(); > > char c = *s; /* KASAN report here leads to spin_lock() */ > > local_irq_enable(); > > > > Make report_spinlock a raw spinlock to prevent rescheduling when > > PREEMPT_RT is enabled. > > So I assume we want this backported into 6.12.x? Sorry for missing that; I think a backport of the patch would be appropriate. > If so, please help us identify a suitable Fixes: commit. Fixes: 342a93247e08 ("locking/spinlock: Provide RT variant header: ")