From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4D81E74AC3 for ; Tue, 3 Dec 2024 18:45:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 599A26B0083; Tue, 3 Dec 2024 13:45:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 548196B0085; Tue, 3 Dec 2024 13:45:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E8D36B0088; Tue, 3 Dec 2024 13:45:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1E3796B0083 for ; Tue, 3 Dec 2024 13:45:15 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B6BD4160C1C for ; Tue, 3 Dec 2024 18:45:14 +0000 (UTC) X-FDA: 82854524928.30.D42BB99 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf28.hostedemail.com (Postfix) with ESMTP id 102BAC001C for ; Tue, 3 Dec 2024 18:44:55 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=akOhsOoZ; spf=pass (imf28.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=charlie@rivosinc.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733251506; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DX1q4LbNfnO54nY1P9OjyEL2atntmm2otrVNiRk5aiw=; b=VdZf08O59qmq2e/p7QvzijRNhlo5TrpURBXtYEmGyCB1mWHXK2RIx+e6yZgo58l6wm+hs6 4s8np3bTHgTI7Tk/qWS+J6kenzfrs3BvuYuEYQtqNkfPWogWSzyw2Ukgwld0/1ZHEGukFq vGJC3QbOt9xJRhqemVjNZA28dw38/2U= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=akOhsOoZ; spf=pass (imf28.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=charlie@rivosinc.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733251506; a=rsa-sha256; cv=none; b=3z34IkjWnLsctdIVxUS86RG+KZpWiKg2/mMUzcruIbB2L0hRYhlN3p8uMYs1CdFsaEgnPn djM173R61SbKL94+sTstKzfwPoPLeK31yRrNsG0qEk8Rpau8foxnWX7NzsPHMS8n2ful2I 8/Gtp+K7GtPdRmczwOBDHiVKb+5gol4= Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-2ee86a1a92dso2638466a91.1 for ; Tue, 03 Dec 2024 10:45:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1733251511; x=1733856311; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DX1q4LbNfnO54nY1P9OjyEL2atntmm2otrVNiRk5aiw=; b=akOhsOoZoGP5cdw9FxGkMn8azUuLdzB2dG+J+MGhgxHym3t1USX4lIqgBmoSLZA/YI ImhgKI52P/R+Z2A0q8pHr8K5eLhm2EZVm8YpNU91r+Mv2OCafKZaB6dctI/5WkmcQ+sD EoSt8epQUHjvgJ/37AY+5P4pvPVM/jJB/3l7K3esR0FqfO68LgdYr0O0A8UzLwe3Dr5Q D/iQ/5lXa1rKZiABlK+PH+zd+gw3S5CCW+pXDA9RXNjNefc89vCd79BOV4LLfDKyGNaG lKywLabklcik+tGqOTfGH6pJmMVo6iKaVtr1ms8ig7y6dX5tva7eelTnfOWJ0hlit/J9 msxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733251511; x=1733856311; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DX1q4LbNfnO54nY1P9OjyEL2atntmm2otrVNiRk5aiw=; b=bgUQWD/TO+HEl4ohpHJ/7muX915eIvbUU+lj2j8zy0vShzAnvMEwyR5XiiaWj245xh HXGGWhTrXEI5Zn0670jNNnjWFLjPDufIqw8UxgqKNBHu9E4cviEy+EQH1tKBNvrpuHOC zbnkV2T91G7OgUURb6pSpxeiJ93YEHDCbkLqafvzIKrqPJgzG7le1zylgto9RrjXfRfB B6/SpCrf0fkYxCDypk7ZQqtEZqFe/9Jz9Ubn+JmUXdPYiazsVnq/qgBW+q6NxLmxl3Zc K2g7njmLzr+g2ykeQTO0kWGvzevcMlAdk6r7E3Dn2RLeA9WzRIRv/QLZY5sp19ddQZZI AheQ== X-Forwarded-Encrypted: i=1; AJvYcCUMSdAvLetWX6PFpPHn5bDm3dKCcKYo2v3s61hafPWk1N6zQ88XkFSp4uxIhIRwarotu23rs4XDPA==@kvack.org X-Gm-Message-State: AOJu0YzKqJ2XopwjGpn7JPladBbOUzbSAvAcaAe4yT55p6uLxXTFkoa+ OO03j5UWY0KyOcZGWiR2602fYWRqBRc1JS+aFj4PoKvBftwJTx3y8w0SFif/LYE= X-Gm-Gg: ASbGncvmqPFzKefVsjLJUsQRJ/SH7iHFOcyFQtT+9V0Y+myV7qHf6ZjegASNVCWr9hi UsKVLfR+noHCzM+7KebfflV5mMMsTh9iaqusUD4rMacoi8OlOI0mfa9RuCp7S2d29iiGZwHkZc2 8rclFv/jYI08YHtoxlyzkrpRGBEQQcOmhEDprs3OSA2c+crLcPfmza1ahwvtgqh7Lq+Ybt+gcHT efQVDFkjNvS6N2BshkJIhZ0oKrrfMcfVxSE/EAjxbE6tA== X-Google-Smtp-Source: AGHT+IEhsEsYF/DSzp4oikyjn6fRzE2euETCh9znl9SEgHM1n6BH2uIgHofOP2OdcmmDuTYZp1vciQ== X-Received: by 2002:a17:90b:4b06:b0:2ee:bf84:4fe8 with SMTP id 98e67ed59e1d1-2ef01262060mr4728642a91.30.1733251511178; Tue, 03 Dec 2024 10:45:11 -0800 (PST) Received: from ghost ([2601:647:6700:64d0:eb46:d11e:11bc:ffc5]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2ee488af41dsm9151463a91.28.2024.12.03.10.45.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2024 10:45:10 -0800 (PST) Date: Tue, 3 Dec 2024 10:45:06 -0800 From: Charlie Jenkins To: "Dmitry V. Levin" Cc: Celeste Liu , Oleg Nesterov , Paul Walmsley , Palmer Dabbelt , Albert Ou , Eric Biederman , Kees Cook , Alexandre Ghiti , Andrea Bolognani , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Thomas Gleixner , Ron Economos , Felix Yan , Ruizhe Pan , Shiqi Zhang , Guo Ren , Yao Zi , Han Gao , Quan Zhou , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] riscv/ptrace: add new regset to get original a0 register Message-ID: References: <20241201-riscv-new-regset-v1-1-c83c58abcc7b@coelacanthus.name> <20241203121948.GA18179@strace.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241203121948.GA18179@strace.io> X-Rspamd-Queue-Id: 102BAC001C X-Stat-Signature: 11szynn1isyjc38dkrop5upk5hi1wdrc X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1733251495-630500 X-HE-Meta: U2FsdGVkX19Km8q/Aovv5ULsoyXJF0zuBT38KkekHbJ+bdJfqDAXowByHrfIlUZ+ZyT2QnK79sAvahfUsv0r1TdnqIeN+k61k9K9w46eO6RfebaAPXCBTcqhTV3yiqr98mFBg4W8JhxrdqqimPTWPAAiujY/bBXnilk8VhqNsSzkdg4M9fJYOtIl0LxrzA82kGdSGjbiB5VIy38co8AIn02WNWxzPW7AyLj9L6QxTcN8HNjYqAm0q1FR+HRJfmEKS+ozyveBRn0KCLr7YcT1/IuYXZtbMLbtzf4vBFfreb00gTYMBN/YIQaGt47BQg4umfyrOjF0KyfayhZT7IIzc8s6sPrgMZU20KjizZ1IJI8sg73kD09ALBt3wXK0rA78cwpvzVeQl64nMAtleiHmeoCTHmPTRPWmr/HR58e4DfyIgRimjm93OjmZ0tnn1p1dm/tdmpI/6EcsXAxKYGP86yxuhfUTxESbqo1kySEaE6+PQixiGsRmwhIkptKPgKU/DJ2Uj/FdQzO5EsPYeP93gy2IhIa8KzFv7jS6fd3QTbqZ6+E2IJ43a+OHOfM/g1rjqw4tkAqnzfPN1U8WuwFBSs8EnOS6OFfQUusO+yErwcXWD+6m4CSLgszPNs0iadzJpd+4PNTJioauXj0EiUBNk63iG1d2vjYXbLrB9fiO88AaIlRbxwfu14ze0bhzwDr1Gv0dyd6Fp9xguXaxsuuNiiJ7i2rvkwHdRxrrAG/E1vxuHWWrxk+jTF5H8z6QheMVjkyPhefx/cZ/UewJ8xEbqcNpnYAuK4MUXcTkaC3hfK7nXgRGRMCoFWpvfBQw1YdKo2jb0HIQSMkMogbC+fJ7aT1YN9eELKb7Yh8kDzqjBlCbdG9nd0KD4qWJk8nG2Cgpw/Hj9lkz8oOmqBlCbI9vt7hARdKUhRcTofjafWavkjNVaJQXO+wwoIE+PR0ry1zOrZspX6/66CibdP2xig5 x6Bq1csQ acqXURW6Z2Uo2BNkx8PUP5G63mEwsRpZ9smjm+hFVQW30YP+TAr6uAUzp519q6kM3DMjOZCqp8DAPpe1M+9wlhpemPi/RoTboqi72RHLgFToB3ltLDIA2yh2T27CRWgTATQuE2JOlQwMJDEFPYg72HVRscYHD608W9cVJD+KIArz9hxYB9Llora7tPgMcQnBwvkbDv65O64Dai97jPklDcaTWFKaR8DU5jxlKUhCbZNnn8WtV7XkzgpAYKAl1dkeiUj+lTeMpQ8Lf99vnbp+ckAneSEfLYRKOKp4AP61UCUyuNCXCJ5fMI7ZLPp4K1ToLGo10Php9typw5JTPoGnSPLIAqrigYAEhNHtdyZY1kHlNnKVSW3CT0y2riK32YrkcqcRoqV4ARzm4J49glFsRoVMD+bbGyV1x2wL9J5Cgkm3VzwZa3BvBCz4is6RNPOW9in+ZJlS68rOisXGeqKSFYcu6tA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 03, 2024 at 02:19:48PM +0200, Dmitry V. Levin wrote: > On Mon, Dec 02, 2024 at 09:37:04PM -0800, Charlie Jenkins wrote: > [...] > > +static void ptrace_test(int opt, int *result) > > +{ > > + int status; > > + pid_t pid; > > + struct user_regs_struct regs; > > + struct iovec iov = { > > + .iov_base = ®s, > > + .iov_len = sizeof(regs), > > + }; > > + > > + unsigned long orig_a0; > > + struct iovec a0_iov = { > > + .iov_base = &orig_a0, > > + .iov_len = sizeof(orig_a0), > > + }; > > + > > + pid = fork(); > > + if (pid == 0) { > > + /* Mark oneself being traced */ > > + long val = ptrace(PTRACE_TRACEME, 0, 0, 0); > > + if (val) > > + perr_and_exit("failed to request for tracer to trace me: %ld\n", val); > > + > > + kill(getpid(), SIGSTOP); > > + > > + /* Perform exit syscall that will be intercepted */ > > + exit(A0_OLD); > > + } > > + > > + if (pid < 0) > > + exit(1); > > + > > + if (waitpid(pid, &status, 0) != pid) > > + perr_and_exit("failed to wait for the tracee %d\n", pid); > > + > > + /* Stop at the entry point of the syscall */ > > + resume_and_wait_tracee(pid, PTRACE_SYSCALL); > > + > > + /* Check tracee regs before the syscall */ > > + if (ptrace(PTRACE_GETREGSET, pid, NT_PRSTATUS, &iov)) > > + perr_and_exit("failed to get tracee registers\n"); > > + if (ptrace(PTRACE_GETREGSET, pid, NT_RISCV_ORIG_A0, &a0_iov)) > > + perr_and_exit("failed to get tracee registers\n"); > > + if (orig_a0 != A0_OLD) > > + perr_and_exit("unexpected orig_a0: 0x%lx\n", orig_a0); > > + > > + /* Modify a0/orig_a0 for the syscall */ > > + switch (opt) { > > + case A0_MODIFY: > > + regs.a0 = A0_NEW; > > + break; > > Did you mean applying the modified user_regs_struct using PTRACE_SETREGSET? > If yes, then there should be an appropriate PTRACE_SETREGSET NT_PRSTATUS call. > If no, then regs is ignored, so why would you change it in the first place? > Yes you are correct, there should be another PTRACE_SETREGSET. That was a mistake in modifying the previous test case for this new patch. - Charlie > > + case ORIG_A0_MODIFY: > > + orig_a0 = A0_NEW; > > + break; > > + } > > + > > + if (ptrace(PTRACE_SETREGSET, pid, NT_RISCV_ORIG_A0, &a0_iov)) > > + perr_and_exit("failed to set tracee registers\n"); > > + > > + /* Resume the tracee */ > > + ptrace(PTRACE_CONT, pid, 0, 0); > > + if (waitpid(pid, &status, 0) != pid) > > + perr_and_exit("failed to wait for the tracee\n"); > > + > > + *result = WEXITSTATUS(status); > > +} > > -- > ldv