From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF869E64ABB for ; Tue, 3 Dec 2024 15:28:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3081F6B007B; Tue, 3 Dec 2024 10:28:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B91C6B0082; Tue, 3 Dec 2024 10:28:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1596B6B0083; Tue, 3 Dec 2024 10:28:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id EBF646B007B for ; Tue, 3 Dec 2024 10:28:45 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8DF47120BE7 for ; Tue, 3 Dec 2024 15:28:45 +0000 (UTC) X-FDA: 82854029958.11.268269B Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf06.hostedemail.com (Postfix) with ESMTP id EB84B18000B for ; Tue, 3 Dec 2024 15:28:33 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=XAEk2pKN; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=hL0q6hs9; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=XAEk2pKN; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=hL0q6hs9; spf=pass (imf06.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733239714; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DdefS+7y1zYZ+8Ncfrn6ijUx/CqLKtjsV+1aqpjQ8F8=; b=t7im/2PQNHJ6eeyKDXNmGQHD+xcijInctdPq0NMab2MdIZAkD3VDwjox0jm8zt29vSZ2af cBNbZpGCwySkvKBisMeoucSCUr/NUYvUKKNf2Xq8I4XXhTVCtDIURPidsgq5RoGyin57NO Q5gJUH5ClXNkpRKWgzqoPEMMwtzEppw= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=XAEk2pKN; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=hL0q6hs9; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=XAEk2pKN; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=hL0q6hs9; spf=pass (imf06.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733239714; a=rsa-sha256; cv=none; b=2CtO07jqatatXSd4Pt8tTbs+qEcLbk5ujQLeUXynFKitlTa2hvTZlIBUgfd3LGahC8g53b t4N+haRQrbMZPEsExHZ5UbIw+Nv1iB1VPQGZVvhlv640IIETtuHNmt8CURcEtBP/hXSx3s tBRV/upUZGdbqwws3RZvh8F86u5u6IE= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 932DB1F445; Tue, 3 Dec 2024 15:28:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1733239721; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DdefS+7y1zYZ+8Ncfrn6ijUx/CqLKtjsV+1aqpjQ8F8=; b=XAEk2pKN78oL/pIhzHC/tYeozuVf3WBPlyYbju1kMtaiGje6htK3jeDDv0VduqEZqGtnkK WU4pNqm43lWkOD/kPV8Ji3t6qC6qgB+G+GhSGP19l+y44w+61KYwbHmIBVJ5lUVoiJrE0+ 3D5bxer9+AgVyMXO24l+CdqyBdVSXQg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1733239721; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DdefS+7y1zYZ+8Ncfrn6ijUx/CqLKtjsV+1aqpjQ8F8=; b=hL0q6hs9ToGpJ6OcoQBDs2DWj9KKvT9wX1OZaFKOMzwTKnGbfHlCN2FDuc0QDMhie5Yjoy zkt9+5ikgaRNPnDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1733239721; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DdefS+7y1zYZ+8Ncfrn6ijUx/CqLKtjsV+1aqpjQ8F8=; b=XAEk2pKN78oL/pIhzHC/tYeozuVf3WBPlyYbju1kMtaiGje6htK3jeDDv0VduqEZqGtnkK WU4pNqm43lWkOD/kPV8Ji3t6qC6qgB+G+GhSGP19l+y44w+61KYwbHmIBVJ5lUVoiJrE0+ 3D5bxer9+AgVyMXO24l+CdqyBdVSXQg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1733239721; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DdefS+7y1zYZ+8Ncfrn6ijUx/CqLKtjsV+1aqpjQ8F8=; b=hL0q6hs9ToGpJ6OcoQBDs2DWj9KKvT9wX1OZaFKOMzwTKnGbfHlCN2FDuc0QDMhie5Yjoy zkt9+5ikgaRNPnDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4558913A15; Tue, 3 Dec 2024 15:28:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id gUr8DakjT2cFSAAAD6G6ig (envelope-from ); Tue, 03 Dec 2024 15:28:41 +0000 Date: Tue, 3 Dec 2024 16:28:39 +0100 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton Subject: Re: [PATCH RESEND v1] mm/memory_hotplug: move debug_pagealloc_map_pages() into online_pages_range() Message-ID: References: <20241203102050.223318-1-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241203102050.223318-1-david@redhat.com> X-Rspamd-Action: no action X-Rspamd-Server: rspam05 X-Stat-Signature: 8eyf9exmui7i1u8htfehp66d51ufyypz X-Rspamd-Queue-Id: EB84B18000B X-Rspam-User: X-HE-Tag: 1733239713-10749 X-HE-Meta: U2FsdGVkX18DYN3MxCxH7N1quKbjX/u+zI9iQNnl/JIGa8IhDsNJLnq7x0z875dBRU+4wrr0rYiZ8YrFNT/g4WKqPH9x+A/HXtLr7mZzUjbTb3L8qwYB/mBV9c8NgjBaDqfwXkUTQBr5CSXtfIC2SJ5I/1JRxpEpn9eFINY6n+Tz0xk2vb/SCCKXLT1o+IVeGDn0obpzFTg0s3nTFN9hWWGD3yUc7jbCoUzvJTRokba3IXdi6l/TtsIJuNX8NJJ9qtWcNx/HLE6ASb3TodY4gX0cbK3YnXFVCoH4szrhczy1XFHa1vo58hep42AzMNxBigdGaxKaxCtHpXMWFvnGowCpQymAMPKUkCuRV97XwSarpLnnTt5AvnGZbbcDht+pGT4dBePtNNS47grMtphCyBvqUilk0950qID9b/jo4lh5Xi8xBaeDAAd2RK/WrUd4DhEhc2GXBoJq3U1RWfSIZzxJJVCpGo9QP7kY5hsQbN2iQo+utUCuSnYneenWmiCXgE54pVlt+lIJSdzLA3PR2qPVS1MNGcW2LXsIViwpkpOij8nIlYHtUeoKYdTsFGyCHxbUQmhxVA7Ym4osBVeSF+MZpnX0WpR5Bliah6GMtwKYcbXGH0FaRZtX0dd7wKTsTa3c63VkhXA5Ct/VS/+WVqBNGpLhbiR5CVDKZGgH2TQwK4aVk1C/LvMryOwqESK41ZI9TkAVrYWwEIgzKMSyCrEoGbffiIU+SiOWxbfbYYW7riggCjAGM63Mh8nffoyxAeUKTAJmg4CSUyLRgKlRklZHoBqYJ7qTQtZR1xIsQRg/NS/Db/mON9BDtFx1D5BVqvUGpQ3BG1aY/Ov5eJyMo5HJBD8BD5uFbgirldzlBKeHTHcMCN4GT8UmomJ48KaTQsoPQu1aZ3RmlBTs5Lf72JkTHMByu6LvFlsFmJY3CLAdrBWT2EcA4h2mo9VRyacRaGUkOQyqqdwBnlVO9Wo rLZxXNXS YHslPXIWvIaCCCkDycYaXDbG7SSc37hXDoDf6dS/Da/zY7+7/8n5g6U06k7Oax2wLjgRWL/rvfuj/lKoAo0op62TpUQ6HEXhYwth+RRm/0tHnNv1UhZaiKWKO0JmuolK2KykyG8qxA5qDKct6KEIka2teA64o7Mq1vPHeTMXf0vtPPY1zxEM/zQyY9gqRD733EpWVeAvASSZNgZJh3dvQVqRcF8g5YbGeNRO97jrP0BBNbW2+ZbNcDA+N9uYAzv/6Ldg7TM9BhVk3Jp5R5wn3qMrT4TT7+OvD9/TiX+4qrQ3spMdb8w76w7HlZPw9hUkyfvWq2RdDHRqoiZUjHtQdKpOkQYuencbWVntRgYTtromEmmUNPpJPLJJltybsOXYKpdMOnyzZ1hpA/Y0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 03, 2024 at 11:20:50AM +0100, David Hildenbrand wrote: > In the near future, we want to have a single way to handover PageOffline > pages to the buddy, whereby they could have: > > (a) Never been exposed to the buddy before: kept PageOffline when onlining > the memory block. > (b) Been allocated from the buddy, for example using > alloc_contig_range() to then be set PageOffline, > > Let's start by making generic_online_page() less special compared to This got me confused for a moment. I'd have said "making __free_pages_core" less special? As that is where we were calling debug_pagealloc_map_pages() if the context on the context. > ordinary page freeing (e.g., free_contig_range()), and perform the > debug_pagealloc_map_pages() call unconditionally, even when the online > callback might decide to keep the pages offline. > > All pages are already initialized with PageOffline, so nobody touches > them either way. > > Cc: Andrew Morton > Cc: Oscar Salvador > Signed-off-by: David Hildenbrand Acked-by: Oscar Salvador -- Oscar Salvador SUSE Labs