From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37D02E64AB3 for ; Tue, 3 Dec 2024 14:20:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B861F6B00A3; Tue, 3 Dec 2024 09:20:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B36186B00A4; Tue, 3 Dec 2024 09:20:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D6D76B00A5; Tue, 3 Dec 2024 09:20:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7997E6B00A3 for ; Tue, 3 Dec 2024 09:20:12 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D57D61C6FA2 for ; Tue, 3 Dec 2024 14:20:11 +0000 (UTC) X-FDA: 82853857170.16.407A008 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by imf16.hostedemail.com (Postfix) with ESMTP id 4EF5D18001C for ; Tue, 3 Dec 2024 14:19:56 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=U77WB8XM; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733235597; a=rsa-sha256; cv=none; b=zErq2y/r+susO+LuVUSVRKk2CtmLdd5Mw+XBe+phCdgPpH76kgq/8YGid9QIUojKN9CH/B HhW6WUOODmia9Jzf6b76d0HD8q7zhWkpfaIcRl+KdYU/vTgpBJWdByQWjulyHmLhA/Fe1O fJ0ln256B4pmPLD0j4eqQpGpuYZtVH0= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=U77WB8XM; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733235597; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IxXMiFUbeGDlhh4meUiARNNY1McnaisHCDkS3C8CP0E=; b=D+4yZVbLjWnPSRE/Z6m5nA77ywHeO3G6exW00YuDNXTdOjSfCJJg7rVLSW4ycv6wePKLFF fGQTDlVyPztLarXCN87zSExWibjvz840/TVclwNtzVlv7V4tn0ONizDLFjWU/ex/18r1Mt lcxE6FHghM5rRMIlT2oGwunYLjWQ2wo= Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2ffa3e8e917so62752371fa.3 for ; Tue, 03 Dec 2024 06:20:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733235608; x=1733840408; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from:from:to :cc:subject:date:message-id:reply-to; bh=IxXMiFUbeGDlhh4meUiARNNY1McnaisHCDkS3C8CP0E=; b=U77WB8XMXXRmBLcpTgXHKfo6Cpsz8UbGlb43ehle7iTuVm7vHIGutg4Q47XBldQm3P aIeXa0+fC/MGhBfvX1PYfc9waE7CiUJWMc7Gkb/tcJlBLa3BOFE1N+BZR45Tt4S7z0wX dfZ+icsaGLzpOv5HumQbLLFOkbu3TSXS746sCZnHWYRwKqWZbQ4cSWM/v548VCs15HmU xtGKe17UrcThi+2x55dfoWwCoOdosKzRfSU1tIs6d5OIo3hzNzeN9gkjbTtybjY40hD7 Ce/JsbaEbJXMo8l23fFksviDOsq7Hf+BNiCyrINNZL1CH2slaUb3XNCMop/EgHvfm35V CynA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733235608; x=1733840408; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IxXMiFUbeGDlhh4meUiARNNY1McnaisHCDkS3C8CP0E=; b=XUop2qHB4ZY0CpGw1LSJQV6ZkD+A/v6d3Zr4Iew5t9VWtK/R4Wrie23+ZW1ujCrp7g 8ByoAzzzYMF46Ab6NEW/s0BDMzo5//jU//sBTkXt2ClMCIAtugtqFt29lnmUR3ATsFEu v+Bu8hxrolHfoFCoHxIOTjz1KyU+47aI0ZWOWpJCR/PLO/rkBUdle/QgKH6iwWTy9QjD YUeiy18DqoY2nAU8oGpL6z6fyHSx9RbvMov18Ckg9ydUBfkmGi+YTJsa2fdwCfkAidbi Nkq3h+zlDDfV658hPv/wV/rD5UC39741HsWFv8ZSzm+iZjOxawqTO9qZoalbcBr6nzir LM6g== X-Forwarded-Encrypted: i=1; AJvYcCUEshF9328LSO+t4OmaRrcufp2koyoXAXH4CW/I7eVIUlyqowy+sfCsv7KDsOgdAOn1p+blKxXbKA==@kvack.org X-Gm-Message-State: AOJu0YxJX/evm+NpZuy+VXAZtB5eo6+Uj+NGTVWcP06JmjppKtaFab24 0CMrbs2kNiagdLjntd5UTwfUGeXncAgQ8HtriZ90EBvkQqlh4wLb X-Gm-Gg: ASbGncu/D1wQInXEWicwkwuU9wtBkpS6n4mSZ17TXUzuiQbGlLDT90gdWFwreAdsBVn Srr7K+Y5uz25c2T+DN7YCRBHsDvGGuzpZyq2TEhpmkY70XPgQTvLGQKbGGK1jWePuyxFRhdvpZi mUYwmeHuYo5ZvegV0I0Wptv2T/iqe3v0KLBMURfn9m5bkn6a/ymRv2/a05EitpFUM1L/3lmTT/1 Fae8zxkqgeY8tCqcuVThk+RcX2rOWslIB44G7erzg0jpl1NSnMHMdCiU+68qX9lQQmPc3YCGS8= X-Google-Smtp-Source: AGHT+IGvdFMh/iLtI3s+dK/8lWWRm6FQvNy2z6QuDSRypjS+I2ayglfe85Q5HSAFObwEMYHS/pFcUA== X-Received: by 2002:a05:651c:198d:b0:2ff:d5c3:61b3 with SMTP id 38308e7fff4ca-30009c0fb08mr17160711fa.6.1733235607541; Tue, 03 Dec 2024 06:20:07 -0800 (PST) Received: from pc636 (host-95-203-13-87.mobileonline.telia.com. [95.203.13.87]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2ffdfca133asm16501831fa.107.2024.12.03.06.20.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2024 06:20:06 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 3 Dec 2024 15:20:04 +0100 To: Kefeng Wang Cc: Uladzislau Rezki , zuoze , Matthew Wilcox , gustavoars@kernel.org, akpm@linux-foundation.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, keescook@chromium.org Subject: Re: [PATCH -next] mm: usercopy: add a debugfs interface to bypass the vmalloc check. Message-ID: References: <20241203023159.219355-1-zuoze1@huawei.com> <57f9eca2-effc-3a9f-932b-fd37ae6d0f87@huawei.com> <92768fc4-4fe0-f74a-d61c-dde0eb64e2c0@huawei.com> <76995749-1c2e-4f78-9aac-a4bff4b8097f@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Stat-Signature: bkh81ifasr3r5pamg91683oeibk5icut X-Rspam-User: X-Rspamd-Queue-Id: 4EF5D18001C X-Rspamd-Server: rspam08 X-HE-Tag: 1733235596-227239 X-HE-Meta: U2FsdGVkX1/u1eWxXZ6ApmdagR4sv88/rr1L14iEwoT5Si9+lj0Ea28BePRqKpNdB7s6diBQHOUwzXjy9aqHUTsTmGGQcvkqyZQZxQ3rAGuXeJbeE3tC1i3Pa5XV+5Cs4LWN4RFwPMU6otBWHwAvwXjoMJsj9aRuDvuz8Fdbv7O7s3ts8ANuMNX/H2aHZxiRrT+0E/RJqy2KGO3zsmUrOuCwLiUix+S0G0cYwjV4Ghe+QRAxJbkjZ0fF57rQa7hUjSQbzuviAj0ck6LiMpyokcD5mrh5XMbojHy5B4ufXVqOx4CoGBzpQiVgfwDxGCnoxcA8E04W3TTMrf9xZOXjhHBlqonfjXFD7ZSGRfk2MQmFBWRTLp4C7UkdcbooVXPWwD/Ks4PuoQ8FFIPDxNkdWhmzh9pk7efMnT+MpG/GLWf45CmXH4j5bYdXOoPQDgdUtXdCjmp67ae4kYdyhAMSssCIKZwIrf8ZkgE2PY9G3Fa5KASkk8r56fMovU8mJxqMOIo7VhBbusisMGnrR/0IV5INPGgTMVsnrO9CftWi+zNVuqxGyBOQBpX8fpQekDfmKYqv2n3ah00hKV9NYCBqNcgxgtlWvj0NJCeL8OqOFVPcwD8YRKWRWwgnqHMH+qsOGOcvTEbzGHy7RjaNR70wFVL3ZM4iHabjbyUALV++s/CUlWCrT4mBvGny+p08mxw/WrXN1zWjX1S7r8Tukn79JcTTsDTp+NA4laugDwOnpwCzRDL/fvTZI7RwMjQnooxUsZjEEYjNrAVC5a3/Cu1SiDufKYQ6RkJIKepFSVjpZnZ3bSIjHv1qjl+HVh+N/kE8qC58KO1b8U6ZVllbK3waoSftEJ8Jyhjc8FUHQYCRHhzvaZLLZW8KOrRLG6kSb57C2MmuuQLvHJxSYI6sXcZy3mU6RJosa8EBK892WWlG8QltY8OWZPNFwgecutsEEPJVC+lLCrf0l2GqZ5yO25K Q41X1gIG +dpvE7smxhZmzGZM+Uk651bTSv0A3YzEv6UfFxNFNv4P8cZ5K9tfqf1l6UVihApI/1o5vsEYOU0Xh5lxKR5nW3lO4UTptHy7jzC4j9W04KbJqduuM/Nk35UydlT0rnTzVEVJJ931DCRUgtEdRzo113puHXmB0wAEZnDxi8ulVeZOAsM/77goGToe/QWTwxlHJjYJu5GiRsqsbDFoA7JJNBNbjUPDutO3jeMfqnWeqQwI0qvLa1/cwlExNYu2Co8RYgfc0oM9+LuHHi/SDxU42FTZfcym+0KILEZFMfjegjPotNnwQSYLnOH7A++W5HnxohuVAsqfHYkpAUFP/P6QePSsLAFkhHlicbrSj1bocE2s254LZKcKI2Ry00MKAVWMD7GoQQsVAtPZ7r4gHpfec22pmD0QGDvT7bStf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000021, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 03, 2024 at 10:10:26PM +0800, Kefeng Wang wrote: > > > On 2024/12/3 21:51, Uladzislau Rezki wrote: > > On Tue, Dec 03, 2024 at 09:45:09PM +0800, Kefeng Wang wrote: > > > > > > > > > On 2024/12/3 21:39, Uladzislau Rezki wrote: > > > > On Tue, Dec 03, 2024 at 09:30:09PM +0800, Kefeng Wang wrote: > > > > > > > > > > > > > > > On 2024/12/3 21:10, zuoze wrote: > > > > > > > > > > > > > > > > > > 在 2024/12/3 20:39, Uladzislau Rezki 写道: > > > > > > > On Tue, Dec 03, 2024 at 07:23:44PM +0800, zuoze wrote: > > > > > > > > We have implemented host-guest communication based on the TUN device > > > > > > > > using XSK[1]. The hardware is a Kunpeng 920 machine (ARM architecture), > > > > > > > > and the operating system is based on the 6.6 LTS version with kernel > > > > > > > > version 6.6. The specific stack for hotspot collection is as follows: > > > > > > > > > > > > > > > > -  100.00%     0.00%  vhost-12384  [unknown]      [k] 0000000000000000 > > > > > > > >     - ret_from_fork > > > > > > > >        - 99.99% vhost_task_fn > > > > > > > >           - 99.98% 0xffffdc59f619876c > > > > > > > >              - 98.99% handle_rx_kick > > > > > > > >                 - 98.94% handle_rx > > > > > > > >                    - 94.92% tun_recvmsg > > > > > > > >                       - 94.76% tun_do_read > > > > > > > >                          - 94.62% tun_put_user_xdp_zc > > > > > > > >                             - 63.53% __check_object_size > > > > > > > >                                - 63.49% __check_object_size.part.0 > > > > > > > >                                     find_vmap_area > > > > > > > >                             - 30.02% _copy_to_iter > > > > > > > >                                  __arch_copy_to_user > > > > > > > >                    - 2.27% get_rx_bufs > > > > > > > >                       - 2.12% vhost_get_vq_desc > > > > > > > >                            1.49% __arch_copy_from_user > > > > > > > >                    - 0.89% peek_head_len > > > > > > > >                         0.54% xsk_tx_peek_desc > > > > > > > >                    - 0.68% vhost_add_used_and_signal_n > > > > > > > >                       - 0.53% eventfd_signal > > > > > > > >                            eventfd_signal_mask > > > > > > > >              - 0.94% handle_tx_kick > > > > > > > >                 - 0.94% handle_tx > > > > > > > >                    - handle_tx_copy > > > > > > > >                       - 0.59% vhost_tx_batch.constprop.0 > > > > > > > >                            0.52% tun_sendmsg > > > > > > > > > > > > > > > > It can be observed that most of the overhead is concentrated in the > > > > > > > > find_vmap_area function. > > > > > > > > > ... > > > > > Thank you. Then you have tons of copy_to_iter/copy_from_iter calls > > during your test case. Per each you need to find an area which might > > be really heavy. > > Exactly, no vmalloc check before 0aef499f3172 （"mm/usercopy: Detect vmalloc > overruns"), so no burden in find_vmap_area in old kernel. > Yep. It will slow down for sure. > > > > How many CPUs in a system you have? > > > > 128 core OK. Just in case, do you see in a boot log something like: "Failed to allocate an array. Disable a node layer" Thanks! -- Uladzislau Rezki