From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13392E64AA6 for ; Tue, 3 Dec 2024 13:51:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 99EC26B008C; Tue, 3 Dec 2024 08:51:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 927206B0092; Tue, 3 Dec 2024 08:51:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A1696B0093; Tue, 3 Dec 2024 08:51:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 57B426B008C for ; Tue, 3 Dec 2024 08:51:54 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 03A90C0988 for ; Tue, 3 Dec 2024 13:51:53 +0000 (UTC) X-FDA: 82853785728.12.187D72F Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf29.hostedemail.com (Postfix) with ESMTP id E353D12000E for ; Tue, 3 Dec 2024 13:51:32 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=g3IgU8qt; spf=pass (imf29.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733233903; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2UQ1aC9i3QKw+4vNIX8jBAnpgfVHP1OgdayEkI4zrdI=; b=hfTXTLuygIOoYENNT2N3ksHWkAJbzlhegdinTbcfx/0yazG+i2UJZXFSQ4PsDi6KfjQy39 MWDoLhM+96TlqiKh85Kw49MmQvYC/J4oPRhvBlJNp3/g/3SDEBtTvY607YOICP9KoGXocj 0G3Kx95qrXE7rR2nE2w25xCwtVtlbps= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733233903; a=rsa-sha256; cv=none; b=U3YjqoIp/71Q5T2EF1icgbO9LFaTx0mCF7QOr2MK0B/Ewuk82Pu4gTmINi9MDLy3Q3J9AB lSUlVOL17tYQbSSdhgDZ6rmM3d5X/IFn7XCwLIRx3NrVMsaXBBbxJ8v7u1fmLh/vL96qG6 VsZSHMbZDZ7mP4d2TmrJbyaksQnnQgA= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=g3IgU8qt; spf=pass (imf29.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-53dd9e853ccso5873636e87.1 for ; Tue, 03 Dec 2024 05:51:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733233910; x=1733838710; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from:from:to :cc:subject:date:message-id:reply-to; bh=2UQ1aC9i3QKw+4vNIX8jBAnpgfVHP1OgdayEkI4zrdI=; b=g3IgU8qtA2y1jGRAXfSxlnbCW0EMavrsdsA8SaCm2bkHcFbKsCX/e+BU/xWsYYK0oF fV8ef7I4CV6UpkjRsyh4gX75TLDxvyMhVu4FkgLO9Yi8fxhZsH8uzGfjDLshRQ4xLWK2 cqMrYvtv5zrvTM1WfvMFGSVBwX/ZCA3nJh3S9CB98u33aKz0oqZAjYv7/VEKhvVsEAmn e/tPQK9Su+A6cg0Gzydn67p4sB4SnJSsfNWJz49uKgZg03XrZGSbb+mF/BTqbGqhKHu/ 0xMrvEs+64UaPGSwJTwwm8Xe8dvYeJeftnMrmJJfMNZ9Lrm49JvTKxuLyZEG/4/NLixo OpCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733233910; x=1733838710; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:date:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2UQ1aC9i3QKw+4vNIX8jBAnpgfVHP1OgdayEkI4zrdI=; b=rX1vlhfhm8YlwcXIS8lvaT3MmnrrqKvK86jKlA1sktgP6jWiBACEYrUUr195GTuQ0x 26FZOiZSuqcEB9WZlwe0omZzBCIwcARaof3dZSFDIqPzG/Sye4M2lklAesf400fwkAH8 9ElDXPjHLLAMqAh1H2gnx/0RgB+xu8a5mNhjvHj+8QSN6zKKvo3UCJeF+7nhaANHJ3vZ vAwpblMFR0VsN5gmPKFbdqv3ji5jKPwrrA6d08EnYzFUALdO8G+N2JrkMwsTBq9CjmwZ 9AgmYYer6PzBAjq5PThthDskr4fZzwXj8HBHKXQ6nX410XIwmcwqVwp8271/TxNKQKQH FuIw== X-Forwarded-Encrypted: i=1; AJvYcCWYBNnS8JVqvs57XQywefOT2pS1wkx+Ux507a/tW/9leytnzaJu+VaEQfjezZT4YtRTQS3TN3knhA==@kvack.org X-Gm-Message-State: AOJu0YzX72SPYBlZ+PivsQSEdikRrq3j4cNwgPcuAb+jYgU+cp59imna U4Tgwdsm9g+oUB0LMHJ48VI6kGRx1x5w6ZZkaRPi1ztqjkXp/vku X-Gm-Gg: ASbGncsfzcoBfgJ1llwH/yJWAK0R5AtSFWqYnxQp4+5GLTE6VzgAVaRiUc3WpKjZubb kPYKNNicZJb4ihplT/u0OhTlP/pErSZg4VqJyoW1j2W7cBGIT1SsHl2Ac4x0Qjdhj6UvviDgCxV tW0pcXREjdTbqbkhai+5pwje1bQBPWJgAHBtguziaCvUu8xU+HzjNfCiFQoH/gqL/pNi7kFcX2F BjlP3FahNugwMCI6CX1tiFMkMTLtvHKX5lS+xU/PwRzxtdxV9+hKIQyaT8AGTRvLDBnZrgFziY= X-Google-Smtp-Source: AGHT+IHe2R4BqO2ewKdCJ+lB2QDGwVDVqPmqwVdmzQ7UffHte6KQqYnDxa+KjcgM65VsESMIec8BtA== X-Received: by 2002:ac2:5461:0:b0:53e:12dc:e806 with SMTP id 2adb3069b0e04-53e12dce87cmr1201667e87.10.1733233909954; Tue, 03 Dec 2024 05:51:49 -0800 (PST) Received: from pc636 (host-95-203-13-87.mobileonline.telia.com. [95.203.13.87]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53e1b5a4725sm53493e87.162.2024.12.03.05.51.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2024 05:51:49 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Tue, 3 Dec 2024 14:51:47 +0100 To: Kefeng Wang Cc: Uladzislau Rezki , zuoze , Matthew Wilcox , gustavoars@kernel.org, akpm@linux-foundation.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, keescook@chromium.org Subject: Re: [PATCH -next] mm: usercopy: add a debugfs interface to bypass the vmalloc check. Message-ID: References: <20241203023159.219355-1-zuoze1@huawei.com> <57f9eca2-effc-3a9f-932b-fd37ae6d0f87@huawei.com> <92768fc4-4fe0-f74a-d61c-dde0eb64e2c0@huawei.com> <76995749-1c2e-4f78-9aac-a4bff4b8097f@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <76995749-1c2e-4f78-9aac-a4bff4b8097f@huawei.com> X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E353D12000E X-Stat-Signature: uy7c6qi3bk55quunw8bp63wdxdpe79q4 X-Rspam-User: X-HE-Tag: 1733233892-438205 X-HE-Meta: U2FsdGVkX1+7ukb+rl7R9at1nDZbO9U6RSPX3taRI2Pe4ZHm9Sd1lP/tc25giiz2e8rFj8toovRQ91ta+VPXgxLEFS5k40UbV5QojIyGAQQMS8kBWztSt93VNzFJ4ezKCAZumXM479JKJe7H+i2B0HJiMpcsArIT+F8ObPTqrptgUiHs3GnSkJZVZNOoe+mEv/G5FuxpcjRylUU9IMcACwVSZcOEejKnFLgK5qdJdTCtn0meG+9Jd65U+kkbaFXO90nLMVmLEmBVCIpe3gIsSAz1g3VZiFvHr3eGg/TnqyVJNVyWoUl5vPXJzSJ1qfTYR4uBotxNynPA3dCQqR0qjlquA3OOM5D/CDdUq9YCEC5Eg7GTZry39phJevbGzPJitOOjbHBXjHCi9VSwp5wvljgJVG2MNgVw2AVTvJwAzyWiN8PWULYUKEa+3a+fwmoQdfdUfDMYLtaryYupvWw3FJe2Nftz08z/45Wskeq7e8L0s2UP/u4LXDpSDOWW+ALU7fDWaEqjZE0nvkelp2a0rL/4mYbHt7VEIH0T9s6gQ0xLPwaC+v4bR6g/jZfcPNB3gCh3/TicAIDhkUiLHgBOlxTVc04iVu5GHd2ELNVJQhcBC0XhySiTY5V0bnAzt432o2vllP5BZmUiD4a5n9Ae2bFAm6LBt2VW7kJeKlkExatNfOCS49JKwd3qFiOIeoTGdX0FtnueWu4ILrmjK2mn1Z6wpfxwfcR7sUxbM+G6TUHv96Y6F3gWa0G7hFbJjL2389HKAMttP8ldz37PRwlsTkdMiisAXnQkg8GtLgXpZxYeTX9NUYpgXQj2uM6wMrS3P9yQH5BHFenZypr7ykFkBhJKUI3UHBTM2AIQR5EukWuNN5y2Gz9GGsTyLqaXeqsTc09J1ue5kopQ/tYEllp7bV96IAAMQEL1lrVkBwM/zGMQwilG5WKWcxFUBqhtuDiSwDmOBeVsSrRfPa5Yxsg 1jjBxMlG Mt/gicO5KXBj7TcFrn5Ezax7IgVuX+8npP1HsLM8d1eZGkVprARsG0TfiptJFUtOT8qAHYS0kNh33k8o6t8XB72csj/ut06ioUol0Rztq9cHIGYH79FgISkr0daCu5q8ctmg1B8WQY/gFaq+3mqZIgl0abhBqkb9EkOX3UzWEGIk9crNcB4OUFrGSo2DnWv5lILUY+aQi3o29RbQVlvpuTlwOpI7LmPB0G7cEQypmEgCwyOcbVYMZHRDhTTLFYX2SjoVw9fANxz8TOOr8Onhwom9VzO4349RcJx0Oh53WGRZzjN2sPqvYdCWlsQ8TVx65M0ywgZYwHgliD7ln5iPDs8k1pXa5sY07x6jBiuT/58N3kF4P9XzGXwr6fG9I8YQp47ImaZ1dT8yOTJDG6VwLaeXJk5yagES6xH0H75xLi+a9WGDchzvoEmOO+SHFNp9NiMY067IFo9toljPgOeM3C2q9wg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 03, 2024 at 09:45:09PM +0800, Kefeng Wang wrote: > > > On 2024/12/3 21:39, Uladzislau Rezki wrote: > > On Tue, Dec 03, 2024 at 09:30:09PM +0800, Kefeng Wang wrote: > > > > > > > > > On 2024/12/3 21:10, zuoze wrote: > > > > > > > > > > > > 在 2024/12/3 20:39, Uladzislau Rezki 写道: > > > > > On Tue, Dec 03, 2024 at 07:23:44PM +0800, zuoze wrote: > > > > > > We have implemented host-guest communication based on the TUN device > > > > > > using XSK[1]. The hardware is a Kunpeng 920 machine (ARM architecture), > > > > > > and the operating system is based on the 6.6 LTS version with kernel > > > > > > version 6.6. The specific stack for hotspot collection is as follows: > > > > > > > > > > > > -  100.00%     0.00%  vhost-12384  [unknown]      [k] 0000000000000000 > > > > > >     - ret_from_fork > > > > > >        - 99.99% vhost_task_fn > > > > > >           - 99.98% 0xffffdc59f619876c > > > > > >              - 98.99% handle_rx_kick > > > > > >                 - 98.94% handle_rx > > > > > >                    - 94.92% tun_recvmsg > > > > > >                       - 94.76% tun_do_read > > > > > >                          - 94.62% tun_put_user_xdp_zc > > > > > >                             - 63.53% __check_object_size > > > > > >                                - 63.49% __check_object_size.part.0 > > > > > >                                     find_vmap_area > > > > > >                             - 30.02% _copy_to_iter > > > > > >                                  __arch_copy_to_user > > > > > >                    - 2.27% get_rx_bufs > > > > > >                       - 2.12% vhost_get_vq_desc > > > > > >                            1.49% __arch_copy_from_user > > > > > >                    - 0.89% peek_head_len > > > > > >                         0.54% xsk_tx_peek_desc > > > > > >                    - 0.68% vhost_add_used_and_signal_n > > > > > >                       - 0.53% eventfd_signal > > > > > >                            eventfd_signal_mask > > > > > >              - 0.94% handle_tx_kick > > > > > >                 - 0.94% handle_tx > > > > > >                    - handle_tx_copy > > > > > >                       - 0.59% vhost_tx_batch.constprop.0 > > > > > >                            0.52% tun_sendmsg > > > > > > > > > > > > It can be observed that most of the overhead is concentrated in the > > > > > > find_vmap_area function. > > > > > > > > > > > I see. Yes, it is pretty contented, since you run the v6.6 kernel. There > > > > > was a work that tends to improve it to mitigate a vmap lock contention. > > > > > See it here: https://lwn.net/Articles/956590/ > > > > > > > > > > The work was taken in the v6.9 kernel: > > > > > > > > > > > > > > > commit 38f6b9af04c4b79f81b3c2a0f76d1de94b78d7bc > > > > > Author: Uladzislau Rezki (Sony) > > > > > Date:   Tue Jan 2 19:46:23 2024 +0100 > > > > > > > > > >      mm: vmalloc: add va_alloc() helper > > > > > > > > > >      Patch series "Mitigate a vmap lock contention", v3. > > > > > > > > > >      1. Motivation > > > > > ... > > > > > > > > > > > > > > > Could you please try the v6.9 kernel on your setup? > > > > > > > > > > How to solve it, probably, it can be back-ported to the v6.6 kernel. > > > > > > > > All the vmalloc-related optimizations have already been merged into 6.6, > > > > including the set of optimization patches you suggested. Thank you very > > > > much for your input. > > > > > > > > > > It is unclear, we have backported the vmalloc optimization into our 6.6 > > > kernel before, so the above stack already with those patches and even > > > with those optimization, the find_vmap_area() is still the hotpots. > > > > > > > > Could you please check that all below patches are in your v6.6 kernel? > > Yes， > > $ git lg v6.6..HEAD --oneline mm/vmalloc.c > * 86fee542f145 mm: vmalloc: ensure vmap_block is initialised before adding > to queue > * f459a0b59f7c mm/vmalloc: fix page mapping if vm_area_alloc_pages() with > high order fallback to order 0 > * 0be7a82c2555 mm: vmalloc: fix lockdep warning > * 58b99a00d0a0 mm/vmalloc: eliminated the lock contention from twice to once > * 2c549aa32fa0 mm: vmalloc: check if a hash-index is in cpu_possible_mask > * 0bc6d608b445 mm: fix incorrect vbq reference in purge_fragmented_block > * 450f8c5270df mm/vmalloc: fix vmalloc which may return null if called with > __GFP_NOFAIL > * 2ea2bf4a18c3 mm: vmalloc: bail out early in find_vmap_area() if vmap is > not init > * bde74a3e8a71 mm/vmalloc: fix return value of vb_alloc if size is 0 > * 8c620d05b7c3 mm: vmalloc: refactor vmalloc_dump_obj() function > * b0c8281703b8 mm: vmalloc: improve description of vmap node layer > * ecc3f0bf5c5a mm: vmalloc: add a shrinker to drain vmap pools > * dd89a137f483 mm: vmalloc: set nr_nodes based on CPUs in a system > * 8e63c98d86f6 mm: vmalloc: support multiple nodes in vmallocinfo > * cc32683cef48 mm: vmalloc: support multiple nodes in vread_iter > * 54d5ce65633d mm: vmalloc: add a scan area of VA only once > * ee9c199fb859 mm: vmalloc: offload free_vmap_area_lock lock > * c2c272d78b5a mm: vmalloc: remove global purge_vmap_area_root rb-tree > * c9b39e3ffa86 mm/vmalloc: remove vmap_area_list > * 091d2493d15f mm: vmalloc: remove global vmap_area_root rb-tree > * 53f06cc34bac mm: vmalloc: move vmap_init_free_space() down in vmalloc.c > * bf24196d9ab9 mm: vmalloc: rename adjust_va_to_fit_type() function > * 6e9c94401e34 mm: vmalloc: add va_alloc() helper > * ae528eb14e9a mm: Introduce vmap_page_range() to map pages in PCI address > space > * e1dbcfaa1854 mm: Introduce VM_SPARSE kind and vm_area_[un]map_pages(). > * d3a24e7a01c4 mm: Enforce VM_IOREMAP flag and range in ioremap_page_range. > * fc9813220585 mm/vmalloc: fix the unchecked dereference warning in > vread_iter() > * a52e0157837e ascend: export interfaces required by ascend drivers > * 9b1283f2bec2 mm/vmalloc: Extend vmalloc usage about hugepage > Thank you. Then you have tons of copy_to_iter/copy_from_iter calls during your test case. Per each you need to find an area which might be really heavy. How many CPUs in a system you have? -- Uladzislau Rezki