From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 510F6E69E9A for ; Mon, 2 Dec 2024 22:34:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D2E5E6B0082; Mon, 2 Dec 2024 17:34:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CB7046B0083; Mon, 2 Dec 2024 17:34:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B59266B0085; Mon, 2 Dec 2024 17:34:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9AE566B0082 for ; Mon, 2 Dec 2024 17:34:38 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 44B08140217 for ; Mon, 2 Dec 2024 22:34:38 +0000 (UTC) X-FDA: 82851474048.27.B6216C8 Received: from out-171.mta1.migadu.com (out-171.mta1.migadu.com [95.215.58.171]) by imf04.hostedemail.com (Postfix) with ESMTP id B8B2B40010 for ; Mon, 2 Dec 2024 22:34:22 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Qn9sRJku; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf04.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.171 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733178871; a=rsa-sha256; cv=none; b=gw07uHW6psY47ScqaOelXyaO4FBgVqjMiRq+4SXUoXGO8QlFi22lb3DUl5+3e4KBeuFfcb ATEX2FHNzbONIQXOcx/dg3gAU5SJEDggjus1aoTXMoADBossxcKLwj8PksvCx3OLCoAh6m vpRaV9ukUNQ5KrHIPXfKj38/ATEZcWA= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Qn9sRJku; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf04.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.171 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733178871; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wvQKDP8zKQB3VtJG2ovDH9nhW9dfc2QHBmy0Thx886A=; b=jmGpP2elazcMktUeV/jUWfjcP96x5sNJdJt7JtuxI/swA/agFwNeSynvKE3rgCR1bHLYRQ OctrVZLQAFl8BUWOyIlG+7D0NQuRTHBPTdn8XwcXF9iortu5DYMXbejxS6a7jvKL3TC4sc 02/zNFGOsbunjQ6eK/Wrp1lY5zWpwwg= Date: Mon, 2 Dec 2024 22:34:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1733178874; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wvQKDP8zKQB3VtJG2ovDH9nhW9dfc2QHBmy0Thx886A=; b=Qn9sRJkuiaVZ0k6XPwSZxxrfT9huo5/iiMggxNOQle/89PswbF2/zCepJ0eF/SoiP4KduN Z8lyul9u5jXHqLrdWiMdt7h03asoatNt2C1OTORDzCWAr000VhtXkXJ0ib/A1blxk8boWH go5ElbUKwXbN4kRqjAn5e43Pm8Af3XM= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , Chris Li , Hugh Dickins , "Huang, Ying" , Yosry Ahmed , Shakeel Butt , Johannes Weiner , Barry Song , Michal Hocko , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] mm/swap_cgroup: simplify swap cgroup definitions Message-ID: References: <20241202184154.19321-1-ryncsn@gmail.com> <20241202184154.19321-4-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241202184154.19321-4-ryncsn@gmail.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: B8B2B40010 X-Stat-Signature: kworf35uiqod95re7om1n7q9bqxuneqr X-HE-Tag: 1733178862-605863 X-HE-Meta: U2FsdGVkX1+TMM57pT7lIPMVToM32SiHMLPwQBMeJ4zeiUWtAmpI65M3ZmdFBRv7DESCK/qWULLIjfthOurWlSA8OEWsBT752EoKyxHCRCmpSM7ZNptiXhXgn+rKQvBfDmOIDu725k38qArX6ofKPv/gOWYCIPYRvqSCAteJwe1emRxDYj3c64og0hDTiaJBWAHTqYU401pKrDfSxtD/By313cUcxttxIfYov2gQkIpgZbPGUi4S6sKgmazYng3Scpc8jTqTUhljieyTwdtMgH/5QjjKRAcPFL5EF5pNcTfH19hPAa0AByNgpTVkqOUr0Cr/i02xCgMtxgFiqWabQwmNXgkf5/MZOn4u1BnQ5n0QgTXKfp2XTCqGjwxjodOk2y+QCd6lJbWiRc2pazzPp0h2+28cNM0V5XfyydYkIFntF7+WIY8xL6s6rSH62YLHohSoVj+Fk+szAutSFd//oDBCC8xg9GHoKMldxvOgBdq4l7MJAX+03T3L/8Xh4WCmH2y+qYl4LTZft4MdOrieQhe+48veCNdlX3ib16684micPBB8qjp0kjC9txlxg7luuxi1xKzUEeUyMXZqnCqNkiCGcBSnX0ZVvss7VLXLXNq3971Znm15jbyk2LcZQGekTr0vKMCZhq5fKoq+thNwIVj68KN4jCLC7JALVr2/YXcDSyqJLSWjGv0aDxE6JWMW+eeKbbNJXLNqhjLKNmflH2AQp2cyqOVry591C30uspYkGjtDE/1x3zulD/Re8sg9q7JmOMgt2Jcydq7BtB1sDbNgE32BC/s+9vzLL2rxENlwh3qDrTenzskaclivBqDWrywfiOfIRLCRKKwS+MZqXPoVVRKQ82+g0wO7Lmt1R8NdoWcO6l9mg9gQ5zf56MdlE9kmxkAusuia5Iu/gq7+4aHO18xaIQXWwYk1Tklh1zGoA7HTozAgc4hPIffedQxdaHa0pfM+yKhZYO+nxut PzQftvCR 3k5FGK/DQHT6Lz+TgHB52ExGhM8fFtoWvWhmwy/Wc4cing0gZbp1h6M+k8Eh8hmIV0VmK/WCUINhtMKe5DepNGhz/IYgTm5FKMs8YiIGx0bcgdpN5zKk7ivV2K3BON0xeDImZgg3GFouOmxqu4vLkNzHI42ir5yaO7vc58JC5X3XX8z0D49mljnumAIvuwx9WKCojgcuG6HMGhpzNo5wkScr9cPcm6aBp0X/483mtlt4hQEgOje1y8taFyEEFEXwc1f8i X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 03, 2024 at 02:41:53AM +0800, Kairui Song wrote: > From: Kairui Song > > Remove the intermediate struct swap_cgroup, it just a unsigned short > wrapper, simplify the code. > > Also zero the map on initialization to prevent unexpected behaviour as > swap cgroup helpers are suppose to return 0 on error. > > Signed-off-by: Kairui Song Please, merge this one into the next one, so it's easier to follow how the end result looks like. It seems like v2 is coming for the next patch in any case. Thanks!