From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84969E69E99 for ; Mon, 2 Dec 2024 22:27:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F7726B0088; Mon, 2 Dec 2024 17:27:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A72E6B008A; Mon, 2 Dec 2024 17:27:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED7C96B008C; Mon, 2 Dec 2024 17:27:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D09DE6B0088 for ; Mon, 2 Dec 2024 17:27:29 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 77FDB1A0355 for ; Mon, 2 Dec 2024 22:27:29 +0000 (UTC) X-FDA: 82851456030.08.D58B2B3 Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) by imf15.hostedemail.com (Postfix) with ESMTP id ECE22A0005 for ; Mon, 2 Dec 2024 22:27:14 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=awzMsTDZ; spf=pass (imf15.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733178436; a=rsa-sha256; cv=none; b=WQMTTtu9GslQILYMQaT9DzUEu8QmXkr0P4l/lazGR77rkyQ+3UP34AtuXUUoTUGRTpMNOP 3eLKS4mdeQcH0Wmoi0ZGU6bN/2Ligu4ltuZOZwrhL0Owxl32fmOZiU3dlKMBhePTOhPg0/ koYc34tZrUGERouExPBoL4/lhZ/XTLc= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=awzMsTDZ; spf=pass (imf15.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733178436; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZHTGhTKKvmj7dDpdv1pQCiZn76VhaFtfYm7VpOCh5/I=; b=d9M1I8Ws0hegCt3a+VI1euD3goeID9owVGRWjmDnmh6z6dtwcnlhnTM0+zxUkpaiSPAcOd HUvvLw+Py5/ctj+7vMnA90ITs2qYQk5w1pl0tEf05MF0dgsEPgopOfUK/p2MqmumPC3K5s /WsDAVo2uXRNBn2vnYfGVFIlh7vzmy8= Date: Mon, 2 Dec 2024 22:27:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1733178445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZHTGhTKKvmj7dDpdv1pQCiZn76VhaFtfYm7VpOCh5/I=; b=awzMsTDZrHUCkLGt3kSJVqPYpz9nScq5R/1ysyaWrHKgHNPsGEuW8c9/vUX/JKAIYoM5de Tf+CUwfqQ8+/PT97dydXn4pbEghIC+DZcc3cEJLIIdUBvStDknZ9Ue2aiZEYoPAfKJY3lN b7SiWf/QKSlom5XfChWwByf3WjbW06Y= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , Chris Li , Hugh Dickins , "Huang, Ying" , Yosry Ahmed , Shakeel Butt , Johannes Weiner , Barry Song , Michal Hocko , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] mm, memcontrol: avoid duplicated memcg enable check Message-ID: References: <20241202184154.19321-1-ryncsn@gmail.com> <20241202184154.19321-2-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241202184154.19321-2-ryncsn@gmail.com> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: ECE22A0005 X-Stat-Signature: 6fi8o97hjh8idwm67d9iixozperp7jmh X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1733178434-393151 X-HE-Meta: U2FsdGVkX1/iHAC8fFxDuphYaMVYWO/dMuzh8EKz2ijy1AUEKmoBgExduLh2OcHEGnObnFmvSpA70tqE2tfYVQeBFZgOFUWESE4POeRM/f9XlHioSlMKFc9yFSb+hFLdhXRoxMC2IeX/+kRNpiSJRMmLZWEGlKORBQRHKGrdWqZbzpN0PNS4fog7zAEQ+38vOES2ONcY7zlzgtAmkVUHEEaN5+eIeeDLIrsuqosJEvGq/exLG0BsZMHCdPNqx3MIvFm3CoCsqEPzhmLmZGrRhxlg9Jt4KM8fjDtH3ArEoPUX+IX8f5n0EK/vslpXy0+vkNp1PIAti6tU3/ikVGN9ATbTHwCMBKE83Fg3FX3UXYfcQVhq1cbo1bGj/YGwgZdJPicUYjaUHmGkhMq5yi79IzRI1Jd0j+A8S3Ad9l6dxlf4fiIP/Ff2zgceupdlh4kycqhoTswlXECjuWy1IK6hGJchupXcyiHX9HTkyVckDNM/pxoxKahSsHMCB+v0mCRAGWokch/zY6hdWo9yxS0qMX4ZJrCVraWVLy3v1xdqQcs3CToFBq4tMuGj6CsWhQ5OndCpDNr4RN+HJEGVNaO0qlaFDwzbiwAuMoDb1GblWJ9GQQ91Gj8WBJONcdP/1gAjC6ETANPjM15DjjT7PhMkofinxVscQcDZqAq3YrVJhdbJ5yl89HZ1pDqqfHlXMhgdCGRSnfQN7GwRqAA9FZwyH5mJlB7rC/0s3pYKlZejP2rz09nKvM5KCCJ4HCY3ljzzAC3vdAltNFlyfJODxVTUy3LmbPLZsxAWtst1t5jH9PgbAK3jbCYx/d4jSmfd5ZU9ZIpVJdOcuGcg3xOs+9+6QYcd/l/Qxm40NBhC2MMAOcziO5O1yuF4G99XdjpdxdsRvb2LgPHn6i3qIPl3ABd/GO9GMob4/tb3IQoFBG3y8HgzXLcyO8bILsU99rzlnuWO+KETBh93JgY5sgVdCJN nbPoetE8 H+hInnt4211BqsDRuGuKjPgBTDgbSDN5xp9HC6y8plg3tgqY/1guhlaMvU4NDL7/KZNO4C7CW48gP+O3meCcMi6IzBXZ9tByPS75/4udYluaALoxxS/v+6iSC8TGzDoWxdEk7tp/9dpMiFFCJ7RPv/6Ar2NeDYbhzkPC8EqnXLnOGhaBar5N/tpz3st+Ipd47dvbnZwDcjnup2BU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 03, 2024 at 02:41:51AM +0800, Kairui Song wrote: > From: Kairui Song > > mem_cgroup_uncharge_swap() implies a mem_cgroup_disabled() check, > which is already checked by the caller here. Skip it by calling > __mem_cgroup_uncharge_swap() directly. > > Signed-off-by: Kairui Song Reviewed-by: Roman Gushchin Thanks!