From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3DA3D7832F for ; Mon, 2 Dec 2024 15:48:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 795CF6B0089; Mon, 2 Dec 2024 10:48:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 744AA6B008A; Mon, 2 Dec 2024 10:48:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60C5E6B008C; Mon, 2 Dec 2024 10:48:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 41A7C6B0089 for ; Mon, 2 Dec 2024 10:48:59 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E5DF1160C81 for ; Mon, 2 Dec 2024 15:48:58 +0000 (UTC) X-FDA: 82850451894.25.BE27CE0 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) by imf28.hostedemail.com (Postfix) with ESMTP id BF900C001D for ; Mon, 2 Dec 2024 15:48:41 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=SCvcF5uV; spf=pass (imf28.hostedemail.com: domain of gourry@gourry.net designates 209.85.219.47 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733154525; a=rsa-sha256; cv=none; b=opc8J5LheJThtZBoqC6D49irVFcTTWGI115VJqt2AtsbgaGQT1sYXOGLuYlPlRYD+3Xz4S O4e4z2hON1vBtEtHezATuJQ213l6aBCa9N1rCiE+21DMNw30nYsiUksZq9PXVVTDiMX1jE 0oOwyVmH5wDsRFK0LHcOZ/TWzTotQmo= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=SCvcF5uV; spf=pass (imf28.hostedemail.com: domain of gourry@gourry.net designates 209.85.219.47 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733154525; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V4p+TEBI7XBsMdBO8dWrGfiuYElGa1lAn8SrYeUTVGQ=; b=kKOIG0I8DOAC7YLEE/bYk+XRFFZipvy6eFb4eX43kBhir3Nikd1JClf9NglaajJg0LHp8r 6CsYV+RRgDWNtnqhQK3LxvE3yfnjj+wCwdUbY7Nza40TIywCw0Ayl4zGxpNVtWvSCQ+bqM lGZGzhHHZdfxdKh8VsjaNc5+kzYQ77o= Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-6d8a13444fcso11714706d6.3 for ; Mon, 02 Dec 2024 07:48:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1733154536; x=1733759336; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=V4p+TEBI7XBsMdBO8dWrGfiuYElGa1lAn8SrYeUTVGQ=; b=SCvcF5uV52rynA968pGcp8ArwORNWeSp9EpzpI5BWbXa1kdXdulpwTmVWIokIzY6sn QdW7lVA5fkFzp+JwG3nS4t1M6kpoF0b8fp91LkTGNhxWWoU5kVLW1wwlRMfRzDRGkKVs vQlDmkySQtW2wtChqGNvy8JE5LSvgQ2b6/YUURkglG7fRIEd4/wLinrZHnRQccbeZEiX CWCdN3uHQTI2xJw6kvw2xhPEoKdOVPLnd/vpIvTz7zzik6coxYUtJrSp+mhfWMiam5Vc GRLkRy2xkTJ5hQ5XwntK6i9gDk+H4j/5Lrdb6CPO1pt7Nsq8ysVNjskc3/7zZ9J4veXW I05A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733154536; x=1733759336; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=V4p+TEBI7XBsMdBO8dWrGfiuYElGa1lAn8SrYeUTVGQ=; b=jd7PfLNfbtydskkjralbUvP5+yb/9Tjc0tKb581S6rmgINrBdrw2zFZdv130xoCKV0 vRMY0AN8g0ooMGZ8bZUbazWbitZavN+O64bH5ORlT+OVMaxAW6MakL36OUJCXOkSL6LM zVmCcVkrNcTI45wKBNy3xC15DE3q1KpQxJV6ARKIxsP2OJB8O13vzRMH9Ud+meVfRkkV j11HmrUfW/oaEez+U98gf4ZROoupQhHK9CReh6Vmp3QTM5+aZuuahMhbepM8mgGCRceO 9kJ6lJ8tJ9HkRxvw8y9inbCgDEXfMRlO494vrq5qiNKFsXYbPWUeHgqRAKxltiVcz+aH pWIg== X-Gm-Message-State: AOJu0Yw8d5WGVxOKuqS2lJ3fluLVVERzWi3YHCbiHb37c9N9KHJBsPN/ PcYf7Bh/NkGroGWT0zxEl4WfKdSpmNmAi9DFYJIsYo8/5wY+vwTLhmoP9fsHGks= X-Gm-Gg: ASbGncvN1HtB/WELwc1fFbHHepeR3GFc8dEiRhdDl1nt3TYpTcptDX9xNiIb6VPkPYV RMWyxBQ/fh1n4E5GSe7fupQCd67PQrTKRwHB+jlw/TNVlOuHGMnAX5G0nZxLHxDik7CcNJgasrb OSTQEKONBS8RduXJsPLsRtNPeadoQ6yX1P5WrYegXlVniTTvAeBvDyNchuDrCvfRb1LCWDvyBbx pb8U6Jcmy+I4M8agXAV3b1YPjAb5nFKkK3J3fE9FnqULXzFQ0DOG0AUDZSRH570byUNiqIu8mlv dSMxFHJbzeMQIDyG03a0BkZWbU1amIQMSJk= X-Google-Smtp-Source: AGHT+IEulJRL9u1e9RepECbKzcJd1o9PSsLDmrn97VXIt8vpMeObeRiPDfAJJDxtOp1H2udplj80uQ== X-Received: by 2002:a05:6214:2308:b0:6d4:1c9d:4f47 with SMTP id 6a1803df08f44-6d864d25b2cmr298319886d6.13.1733154535946; Mon, 02 Dec 2024 07:48:55 -0800 (PST) Received: from PC2K9PVX.TheFacebook.com (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d8ad3e2e76sm6490016d6.78.2024.12.02.07.48.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Dec 2024 07:48:55 -0800 (PST) Date: Mon, 2 Dec 2024 10:47:57 -0500 From: Gregory Price To: "Huang, Ying" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, nehagholkar@meta.com, abhishekd@meta.com, kernel-team@meta.com, david@redhat.com, ying.huang@intel.com, nphamcs@gmail.com, akpm@linux-foundation.org, hannes@cmpxchg.org, feng.tang@intel.com, kbusch@meta.com Subject: Re: [PATCH 1/4] migrate: Allow migrate_misplaced_folio APIs without a VMA Message-ID: References: <20241127082201.1276-1-gourry@gourry.net> <20241127082201.1276-2-gourry@gourry.net> <87plmfeho4.fsf@DESKTOP-5N7EMDA> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87plmfeho4.fsf@DESKTOP-5N7EMDA> X-Rspamd-Queue-Id: BF900C001D X-Stat-Signature: fi7kc14oz87cmkncpq4i5dx9wdycnbuj X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1733154521-10583 X-HE-Meta: U2FsdGVkX1+qzyzez+pUOJYfxNHVFsnYfFARUg/y9fiSbzuStIKkfXbjtwuGI11oYSn192srDRj99+08t7jfV+RwCUkDN0q6xh9galV3AqiSXQpFpnyKx+ZZVs6sBvsQTQmhPaP/0tur8RpD1QmRjT3BAqYa2BHej5iv5pLL1VwSukMhDqrsNcwBUQA9D4pvJqhBI9QgGU6c7R1pbd3+mmwuDOZBE3qqSJwVKjU6Urqw/ZKA6FEESxdBYbmilsEaC3g+/U91jGfVY6FccoZr5tsQgYjHE5Ei+w6To3rkpnlrwGyrKSkFiB8lt7IH54Lcb2hG+xWpPEzCUrZiuVWEyKUQ1pO/4KJX+ZlHygDT9n3VkXWKYWW+bw41hbN/+5wO8rOCELi5WY7F36V+5aL2L8GLepHm0k8gwjyNcKwQNg+3jeE7r5kL3Q0VMoKGL0i+rGfC9uW+jcOf8QsRtJutGl0kshFSeVwhk8FW/76sTbHKjURuQbvyapBcSvNBeChjByY/n4MySRATE+uhmQNO3WNI0ID0J8c6IpoYQjm0HcD+QMZGPjcGrh5/CyzRk0vbdtjjzoa9/SpezDMeImnfL3UavPnto1YKxZtVRtKzPZHZmvaIwn4BRPr2sYjj4cMjBvL7n56w6dmE8aiSJke1nILy/FseyBYuSn2aNn1O+r5KOWa92DbCDEofvYLoY7tpXC9YaHyYZjJPg3ip6e7fqmKqwVRcfKolNYuTzgiz8e7a/OVMTNNUl07f2pUmFVVb558ftQ+u3Eip/W9y4X7S1IaU/1jXe3uSx7OsKcJr5n5GoSO/+VQKj5lPOH9pjacQTxcFAD47RnCRnIFLNjHL39bRf47Tsbdozs++drOk6pSgEp3wBcXxJVzaoXUq7+M7O9md87ST8HlGmEvMGpfIy3UBsqS7HvosIPOFDTqP3KiBHo3R46ygRl39t/v6LQSBZGIA6eyTuB7FdkIIVUN 5/fxHo4G M8e7zhV2HTuqjkQOJXcn/NoY6vY8JIBySWDQJoZvkpMBSQqeIcgka/xHngxTVWvfiKjLysQqkv9kymVSHZnXeVJCwllqbArNJ/UociFjRFv6ItuSd/OXwcI2X2JsyAcVfDZz8nUxMusxidQlDucmHK4hYY46Vkwc84nBCm5Nz/jj5cxWwaWZNpIzQK6rhfabFTgrMpGcYHu/Fr+clCTjVKyfamDrwsPAbyJXzNwhXY2l3co4ie2fdko/XkV0s/kIBDcRaEgdXiIDVh3pW8105++RMrcF5/qdeDu5QnUHvwhFH6WrgxGGnvb8gmqE1Fr0rsHXibPjgM/av6tKDqGEYGiQKfc/TRrNwiiAGlPzaeCd7573tdcPewlObXHAfiWWOB4bP/2eZAJX6+6w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.030174, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 28, 2024 at 07:12:11PM +0800, Huang, Ying wrote: > Hi, Gregory, > > Gregory Price writes: > > > To migrate unmapped pagecache folios, migrate_misplaced_folio and > > migrate_misplaced_folio_prepare must handle folios without VMAs. > > IMHO, it's better to use migrate_misplaced_folio() instead of > migrate_misplaced_folio for readability in patch title and description. > > > migrate_misplaced_folio_prepare checks VMA for exec bits, so allow > > a NULL VMA when it does not have a mapping. > > > > migrate_misplaced_folio must call migrate_pages with MIGRATE_SYNC > > when in the pagecache path because it is a synchronous context. > > I don't find the corresponding implementation for this. And, I don't > think it's a good idea to change from MIGRATE_ASYNC to MIGRATE_SYNC. > This may cause too long page access latency for page placement > optimization. The downside may offset the benefit. > > And, it appears that we can delete the "vma" parameter of > migrate_misplaced_folio() because it's not used now. This is a trivial > code cleanup. > This patch apparently got a bit away from me and was heavily reduced from its initial form. This commit message is just wrong now. I will update this and the 2nd commit and probably submit them separately. ~Gregory