From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26F9CD78303 for ; Mon, 2 Dec 2024 10:37:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 656E56B0085; Mon, 2 Dec 2024 05:37:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 605AD6B0088; Mon, 2 Dec 2024 05:37:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A64C6B0089; Mon, 2 Dec 2024 05:37:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 266546B0085 for ; Mon, 2 Dec 2024 05:37:35 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C90051A1A68 for ; Mon, 2 Dec 2024 10:37:34 +0000 (UTC) X-FDA: 82849667166.07.77D3E49 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf26.hostedemail.com (Postfix) with ESMTP id 9EBF2140018 for ; Mon, 2 Dec 2024 10:37:23 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=NRRzMLVu; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=r4eC7CtN; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=N7td421d; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=AoxFt51K; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf26.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733135841; a=rsa-sha256; cv=none; b=SYW0AH4/fFzbUZpyCAc1YuIZ1/BhzH/RWrHJ50DDhAwFNwWWpCdh8C70HBvzFN7MQapRyR 1EWNeA5+Va/Rtm+oLWn3IDC6z/bFKS4QJeb98Z51Ii9+7JQ1CbVGfzGmw5ySwYbMU9AnZn mgdqaKubR6u4epPoQ3YPcqpUOuHH+9k= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=NRRzMLVu; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=r4eC7CtN; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=N7td421d; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=AoxFt51K; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf26.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733135841; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MoayjsmtHtuWFe/nYuRkVJvWSmW7XjN4TkwXZL4rSEI=; b=0falFVCVO+57LG9An5IYpCudriuDVm6N3UXvbqltU8yVZ/g97TpX8luTi/WKnd1epWQa9k bR05KlCePSbgpwzoAS1IWNtTOH/OsESJGMMxSWIe5Sy/yhue2NX/+mSFDvpKKApHWEJynd oV/OGN1IExrr6qFa3TiC9KJYXQX1pbg= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CC5521F452; Mon, 2 Dec 2024 10:37:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1733135851; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MoayjsmtHtuWFe/nYuRkVJvWSmW7XjN4TkwXZL4rSEI=; b=NRRzMLVuZ6PwRDJgo6brsDQrSfNeL+7IzjVCTH6UaMloQhMk9hgW3pqaKe09rnXVMbzBHx GY8ORgLXkJ8oyLjf5DGen+Ad9sjBAKhsUPknUShxLBFVpWBTk72iXKFhTLB8cR8gGw+ZPw HyYyz+zgbJ2sX22ZGk/6kEn6t+bf4Lg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1733135851; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MoayjsmtHtuWFe/nYuRkVJvWSmW7XjN4TkwXZL4rSEI=; b=r4eC7CtNo31etFtez0MQX8rqTlLli+lA7wDdIchJxFkIYBxe0+OI86zRLRK3hzizU/tDcL Sgtn3U/ULBtXd/Dg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1733135850; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MoayjsmtHtuWFe/nYuRkVJvWSmW7XjN4TkwXZL4rSEI=; b=N7td421du4YjwGN7xEYNuy4h183H7AJfcONB9Vt/ygmUjACHujnPZ4jalScxteTqK4sB/J 1CIJtbrrlWzYgHHo71Vt7x1Q5b0jWUG/j29yMG2ACHhC3EmzbN4uIBmZc1FKVhPiKsl9TZ 7rMGWrs66ko949DyqFm3HTdxvvmV3Q8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1733135850; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MoayjsmtHtuWFe/nYuRkVJvWSmW7XjN4TkwXZL4rSEI=; b=AoxFt51KbRENFVeBbizW5pRWXy1bvZn0QwjgPn6CK09htMLFsrtQsrATr2GBNDd6Yqxi48 3rMmbKsDicpJmCDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 586EB13A31; Mon, 2 Dec 2024 10:37:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id E3uwEuqNTWfpUgAAD6G6ig (envelope-from ); Mon, 02 Dec 2024 10:37:30 +0000 Date: Mon, 2 Dec 2024 11:37:24 +0100 From: Oscar Salvador To: Anshuman Khandual Cc: linux-mm@kvack.org, Muchun Song , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/hugetlb: Make __NR_USED_SUBPAGE check conditional Message-ID: References: <20241202090728.78935-1-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241202090728.78935-1-anshuman.khandual@arm.com> X-Rspamd-Action: no action X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9EBF2140018 X-Stat-Signature: hkth18mn14fmbyit7b1jo8iha7orezcu X-Rspam-User: X-HE-Tag: 1733135843-476158 X-HE-Meta: U2FsdGVkX1/LYcYAbdjaEEbH5+FKWkXY1PW6bScu5t1thG1bWiyaBdHfZBX2ioUH6Ncai6hTnL/XkrJp6fG3wTpQtpxVGnnAIEPsyALz80RCdV6TNWUWvnBjt9ZKoot/+hdaqnVHBQQrtLXrjZ1qB+9DaSmhkQmwCRtLeiZ4bVFapYWSbg27vNqEosPeVJrGXY71kt00kRG4QDEWEtP01OsI0ATKHVvcqOz9gViGZEKjHDVp8id03TjZ5BWV45/5M971lYFadP2VDms9Ue1pWKdRiUVPqIwRs750YrXyGIXWz1hPy0sG00COLp1F+P7Rl2Rw03tp6kG9qvyeticbrjpzPV6mdpVWjEsLb8tryHallz19sPGDWnjsZH92CGMwtr8PJRsGc4m3CBcU2FPNyqZp8iuCoLguqUY2Qi+9gUA46Xj5V4ted3GTARxr5VnZaYJ5MvNlsm+p/FhJ+C4yvfmzO5BeaRJPE1o8p2pR1QC7kusKoi29VBVZvWeBb1kAgznBwOxuxXShX4E5dUCAlZf8/OkH+LJhypdYcTsznhglCKO+gLNt5x7QM13KCl4R2iDSqqbjlMlRXn5qNHFHYe2mnJt1cARLhJtKgJmgwJRfgeU0Ov+eiqwXkhCKKvaC9vhJoYRbWyUW9lmNV8Nn/IRUA1u9bqtphH+/mXC4eZYpkK3pM0Hr5rb45z8fAMA/pKTHgGFyPRsEolhEvT8A8uMJVVXwls6P+ApwwIEiq/YoUzHoE4Id0+SXO840uVvZNkmJUvKl/a8jz2DEuQvkaUBKeEdanOfCbklZBFLrXyJUhtLMPiWoLfU/ELgjoVxMUbq0DhYn7DffM2iwz/fIks4F4xzFmu2xB0QTlvgpMYpEviJqAB261sF2u8Ee0tvWDf+bkF0khFjp6dvj6nMnHMLVUxbc4ps6LT43kjnAQC0+EsEfmnBbWGgfEh+jZgaF0PZvEWyoNljM1VOEUXz AqcDzlNz D5fg2TC997/QHeYt7Ts0yOTbS12/PfqMcQGb5AUilYGzbSpFKZkSfbF1LK89nqqzIjZHaQqARnc7uYoQflVPyF47QxLfgulfmugBop42052skOgnt6A374r6T6fJbjkDyxyEpLw1NEDAH2F0/rFoPI+gQi33aOP7lQ1Ygqxn/WbozvSCSXh763waVJksn3dvtjKDRR9qoyPGxwt47PmoWgDobLN/70iAdGzQ4y5W+YL7s4IL1JoUgLelthjuUZabncKGYo77sp3UO5jDdpDr/JNYrJSgJqaNx3ptFAYhHKczV9SkFv9xzskMbXtNerTkvmP3R47/+311fTFxp5ypWywwcF/eH2B/3KpcT7exMd6OLorE4wdSVT+onwOMMAHgsqu1SAuxH+oOFWzzow96081U6C7Y1E2EDoAM2DbCeo1+cSe2aXHgBUxJ0fD4SBtJqLyRm4P1F+1nrr+05nIOc0D9xA36aC1ifyHj1RP5a4/AKsliKf+XIX03RkzbAuLU9ksNU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 02, 2024 at 02:37:28PM +0530, Anshuman Khandual wrote: > The HugeTLB order check against __NR_USED_SUBPAGE is required only when > HUGETLB_PAGE_OPTIMIZE_VMEMMAP is enabled. Hence BUG_ON() trigger should > happen only when applicable. > > Cc: Muchun Song > Cc: Andrew Morton > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual > --- ... > + > BUG_ON(hugetlb_max_hstate >= HUGE_MAX_HSTATE); > +#ifdef HUGETLB_PAGE_OPTIMIZE_VMEMMAP #ifdef CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP ? -- Oscar Salvador SUSE Labs