From: Oscar Salvador <osalvador@suse.de>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-mm@kvack.org, Muchun Song <muchun.song@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/hugetlb: Make __NR_USED_SUBPAGE check conditional
Date: Mon, 2 Dec 2024 11:37:24 +0100 [thread overview]
Message-ID: <Z02N5PnYa_S_ISeg@localhost.localdomain> (raw)
In-Reply-To: <20241202090728.78935-1-anshuman.khandual@arm.com>
On Mon, Dec 02, 2024 at 02:37:28PM +0530, Anshuman Khandual wrote:
> The HugeTLB order check against __NR_USED_SUBPAGE is required only when
> HUGETLB_PAGE_OPTIMIZE_VMEMMAP is enabled. Hence BUG_ON() trigger should
> happen only when applicable.
>
> Cc: Muchun Song <muchun.song@linux.dev>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: linux-mm@kvack.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
> ---
...
> +
> BUG_ON(hugetlb_max_hstate >= HUGE_MAX_HSTATE);
> +#ifdef HUGETLB_PAGE_OPTIMIZE_VMEMMAP
#ifdef CONFIG_HUGETLB_PAGE_OPTIMIZE_VMEMMAP ?
--
Oscar Salvador
SUSE Labs
prev parent reply other threads:[~2024-12-02 10:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 9:07 Anshuman Khandual
2024-12-02 10:37 ` Oscar Salvador [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z02N5PnYa_S_ISeg@localhost.localdomain \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox