From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7047C36010 for ; Tue, 1 Apr 2025 17:33:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F2781280005; Tue, 1 Apr 2025 13:33:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ED4E5280001; Tue, 1 Apr 2025 13:33:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC2DA280005; Tue, 1 Apr 2025 13:33:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BD514280001 for ; Tue, 1 Apr 2025 13:33:49 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 5B3131A06C8 for ; Tue, 1 Apr 2025 17:33:50 +0000 (UTC) X-FDA: 83286172620.12.62F6763 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf21.hostedemail.com (Postfix) with ESMTP id AE5941C0009 for ; Tue, 1 Apr 2025 17:33:48 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PFW+cVhG; spf=pass (imf21.hostedemail.com: domain of tj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=tj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743528828; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Nexdt20ucL7BatDhzbzEXtsVSkHViXj71PQJ5oDk6Tw=; b=EMfRtbghHJGDI9BIUkDoHnwgncMt0Vg8rPM/DHqghzz3k4HEaa6xOPa5S+m3EVli55ZJvQ oSWjHuSDCaN69DCc5sQGVHD2cgViEElMOzenQyuihJ8uqRhoXruHdw+pQTfR4gqijcftxU 1Dp1HnsiUzADEan05o5lVzDSrj+BLb4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PFW+cVhG; spf=pass (imf21.hostedemail.com: domain of tj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=tj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743528828; a=rsa-sha256; cv=none; b=psMsGDUgVLFJI/1rVjDVeex0R3vlZnliAzZuYH+1X2rAOuIMahSc4UQu6xlK5Ek1qf5OsS KnXBIpqNX3gf5j2patZ9rcRuZQUZ+/lijACgeSOjZBysrFkL1CQpUGdK18ADgtraitB4x1 XbBccUWma91O3kEJQ7Nc/swijXekjNc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 4224CA4574E; Tue, 1 Apr 2025 17:28:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 92EE1C4CEE4; Tue, 1 Apr 2025 17:33:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743528827; bh=Ybi/75q3rVOd12LnlD05Pf2gzBLxdBOD04aayJo+Mlc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PFW+cVhG/eeINvfuUc+YNO3aTlgH9IV9DlNoDlaVoo83t9qBC0+umU+9K4pfR0ydv dZSm3livdNmt5qqaQ/G9aA/z9A/0a0JfXasGVWJ8F85zSODLyMEBZJty8yX1X3V29/ Z/wkleyjQz43Io2XStUaHIc888oE7tqzR37o6djtLm3TeSl+Z9bSYjPikKRR6dpbCm DDVekJDs7FDJb/uEZp8Lhm7GhLqoy0B0H9g2tCW4xGjeHIM/ak40/9Rd++SicMDlvG R0kA0v2X5QDaoAd/ZHh8oe7Jnf6PrtpMqrIgkPAx9jU/jeh7aw+8p3YBh+K7LtkWgG 3QqCO4Uq2do8g== Date: Tue, 1 Apr 2025 07:33:46 -1000 From: Tejun Heo To: Shakeel Butt Cc: Johannes Weiner , Michal =?iso-8859-1?Q?Koutn=FD?= , Yosry Ahmed , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team , Jakub Kicinski , Breno Leitao , Venkat Rao Bagalkote Subject: Re: [PATCH] cgroup: rstat: call cgroup_rstat_updated_list with cgroup_rstat_lock Message-ID: References: <20250401170912.2161953-1-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250401170912.2161953-1-shakeel.butt@linux.dev> X-Rspamd-Queue-Id: AE5941C0009 X-Stat-Signature: k3bjtgc34zingiq1x166467ex7pkc86g X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1743528828-989013 X-HE-Meta: U2FsdGVkX1+toiTN7ExGhbo90Uyfh/nFqUkNRT1rPBx6J8GqMb7+t4FSlobwJfF20rROwnimc+4RTwOTXApRHvZbrma64fQgfXAVNWB0Z5VYpmivpgAQ75jRoxJLKnL7niAJtfEjDSeYDqDNX0KJt/Zjmhyj903H7YHrpWwAImMcRdCokkeHiTtkf6/0j8eAaqPbwpsuba+LT/NpoDv0HzIOptB1QEER1LxJQ/Iv7Qc1mRcORrEe8uWME1EU4RTHkIvZ5Pf41tvLobatG+KZz0aAcFrW+VwLjGJFZsZP609PiVJX6RtxKOsLtmbTwvO+xqBxAjenD8W7VxoLt+6vaAWb+PcUnwJ8i1rGSlcq9vLl7g7mwMvB1pBxjgVzT8jBl51jgsIWGGjo6eFkjEoQ/00/UBTY4tTl2qt7tMasvs2JpqE4uQFG/HHgcoqGoeAdj0giqkioqxGW2s+h7xrgQp/NVEwANJ58hzUyrmgKzbVYgOv7bqpn4ZzdlQ5SbtW84UbZuMBLk/TfZm5R6zX/rQ7l1QL44zqtrAlMs4Odag+sp28aQ1GaVUdSne57Si5m44iFeSnCWKM8viVvQua7bhxA/+ERbEeZ8FueudHXJ7imrkJSwOblnku7JxVRlJTXHngleq9u43qR1P3lsRrAm9J6Z+1YTGe4xcBGFSihha/gz8y9oQuc1h1MdDzbKNDJKe3ABfh8BgbgVWUo3Ah2CO1C81TjBRr+4vlinEF5awXWTkRDSLZzE4ZvYgsICNlaNuFclbmkMOLsqJlTF6kJEwDBG7MV2lP6TGy2qODJYq/joVLtZ7o8fZB/Lf+AHX2CmrwtPJwWpvQgHNL6hiybrhExPnzPgpzYqwKEUvw5bRBGbeg49vNSW5QwRFaXnamUf+rVVL32TBKKkiLvImRJHSY3kneFuDqBw2d4tpYJKmAtCgPTTcX3I+zlCQsTggOs6QphlOUnGlleHu6hBvV uY0qjx3Y 7fjvs2DDrP4ifJGMMKC7SWlaZ2sbQJpmDF9wyIZD4W/wVdD1B81qLykgEaMqjyf29vq2gpFKcxDWubrVefKDr4QFSwcgHWHH42UW1bEgDIP3xMI1R7tePySGc/afgdhsSU6D45z6w7mh7kxN57GIFQLN3SVYAmAH5iH84n0eVrWEAAxTjTrgk54y+hjXuZ1O8yGKrna+H+EI88hK693+UxL5m9YRsHjrFw4M6Ak0MGIHuRHs0UlqkEn901fDlMx78d2eIaPETSQpsU+I1zaE27/nC9QJenqVThIsB6Br1ICw6aEH2vU4i63AHzSOVNCh0JJ8Lq8TQoKex9R8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 01, 2025 at 10:09:12AM -0700, Shakeel Butt wrote: > The commit 093c8812de2d ("cgroup: rstat: Cleanup flushing functions and > locking") during cleanup accidentally changed the code to call > cgroup_rstat_updated_list() without cgroup_rstat_lock which is required. > Fix it. > > Fixes: 093c8812de2d ("cgroup: rstat: Cleanup flushing functions and locking") > Reported-by: Jakub Kicinski > Reported-by: Breno Leitao > Reported-by: Venkat Rao Bagalkote > Closes: https://lore.kernel.org/all/6564c3d6-9372-4352-9847-1eb3aea07ca4@linux.ibm.com/ > Signed-off-by: Shakeel Butt Applied to cgroup/for-6.15-fixes. Thanks. -- tejun