From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F36C4C36010 for ; Tue, 1 Apr 2025 15:17:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 835ED280004; Tue, 1 Apr 2025 11:17:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 80BC5280001; Tue, 1 Apr 2025 11:17:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6FB03280004; Tue, 1 Apr 2025 11:17:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 52C4E280001 for ; Tue, 1 Apr 2025 11:17:36 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D0FC21403D7 for ; Tue, 1 Apr 2025 15:17:36 +0000 (UTC) X-FDA: 83285829312.11.4E9314C Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf21.hostedemail.com (Postfix) with ESMTP id 258C81C0012 for ; Tue, 1 Apr 2025 15:17:35 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=n8ok4S95; spf=pass (imf21.hostedemail.com: domain of rppt@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743520655; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8/1xp0YhzroBSuE0Ia2THIOTuVhQmSiNaHUlp1bAH2c=; b=7CLKIVYdu0tCK6SpLWl0k14GKGboVYyv819JU2p2j0e9DRsQOwyhiwDd006TJX2fvYPeoz R5Gx6+jCB9mdplzuDbZcsZszypljkGWuBpyi9cO3Ty2kP50HId3F0tItd3keeU4LDLJQ2P mR/nEKQmJl+5Mq5hnalPGKUxGRqrbk0= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=n8ok4S95; spf=pass (imf21.hostedemail.com: domain of rppt@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743520655; a=rsa-sha256; cv=none; b=2URlrm2rn9M50xcjBBTXMJI5jY2IDDK2eq52MqFLEqLQqovdg3jOmv4U8Pz7QzdWbY+Qgp Xm06Tus7SR18fmpvJ7A8STK4Yk+upHpYU44ZVSI6ke+pVwF81HGJl60R1VLJ+/90m2QbLh 9T7u+atR1flQXSwLUXnP1FplQarAHVM= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 779896112D; Tue, 1 Apr 2025 15:17:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF3D8C4CEE4; Tue, 1 Apr 2025 15:17:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743520653; bh=jDx4H/eQnI1o2tONXSaqnfYbna/aTlmeKY+YAtarwKA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=n8ok4S95oGSVHhoGDeVtLnm0Jvl2cqEp7eAxdrmlxqcJQnyqsoP1AOwFRnbZo/idp PhZsi44GKn4ANuobYQzPMLjOdoq0wiEMXE6ICxyYkAktpwCB6CeyEk1wzf4quLCXBE sbobSluF3EfcvsxI3KnLh6aZ6zryN86NeeRLafa83+2qB/4iqE3LICZwbjUJxf4m/8 Et6kszhFDTaFvMp163T2//q6hoQGKj+nEBAxE8bz7m7TuOFnFcanJ1DxG7X9iidXDB To31ldwHTO0NPAwcARWx+oXWyddZ+uQlHoOvi6pzW1sidf3EGSOAR4WGZlDIN+z0PC 3YobPLoblYj9w== Date: Tue, 1 Apr 2025 18:17:27 +0300 From: Mike Rapoport To: Harry Yoo Cc: Vlastimil Babka , "Liam R. Howlett" , "Matthew Wilcox (Oracle)" , Andrew Morton , Lorenzo Stoakes , Jann Horn , linux-mm@kvack.org Subject: Re: [PATCH] mm: Rename vm_area_struct to mm_area Message-ID: References: <20250401122602.1738511-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 258C81C0012 X-Stat-Signature: 1qe9c4cf4jtw89c1xx5bd6ertdhaconz X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1743520655-206729 X-HE-Meta: U2FsdGVkX19u657xhmGRS/Td+y5z0ReEXIsWIHDckkEaeZiK4QAFkTMWY3VSbG91+cPkgAM8lfiYJ9ohOzH8A5LBQnJFIVaNVaTY/lfvLfa+xQflsU7OKGl/SYYeU7oHKiUd2wcLyNGuqnVUNdeUtLAPMVl6x/twEerEOcpgQdsKKn0Q+0X0WQNE2S3lguhW0mqTL4qM7/jCzHnUpSQUnmb+PAUkRm4vm0m+vj6+y1AwKrQc6XElgEyP6v2HYkYKQkmq2hhy3/OsMTXSolZ3w9+qNgX7w0TvT6TWtDF6SKmGMKstaKup4lMqa4N+hU8VagpdwTEaNdKLG57gK9/Chc1Nbr2iOBhNPQP36/28C6XGy2A8KGk0UGjb4Jr1g2yqQGWBsek7ONV/Tn+0bv1yg6XrtetXCjoj8xm3j/QcOo6QhbAvk1zmjh6tXdvUnZngKhGPWcn6eNaWciGmCX/EngleL5QbHOj0cAOpwiUWbu/niTRDFkk3v1b2By9tJIK3ZwwR1r6W4aJQ+wgcKg9Z/FTkwGNcXn7UrJPhcJALAvIKAHm3JOGJQKX9wecIqQpaULaVVIPUbpXURCU6Voo0SVVrk6m13zLn4ocNtcmNQWGR4jNy84tXTpnjPMJpVrfl9+9uKe40teyyNjtA6dYA0ppPhOYRKvrhGVfX73Po/6wZ9WVGFa4NI2vVSTDW2aJ4Pd+HfvfBbueHWn1+xf7VRTXhcGyNtDbxxVxeu3Couf7wHa6mZfl5nYEdNNxsD8QYWeUuN5phxFg+DHPQ9gPLdDc5P3AhrjvWcWInTKB61ehZtM0aA9/wRgiz08kIkhIv/P9qj0LYWq6i9fTtI1wM2JN8R74MUXRO3O7Ir4brlzt0Oq+otXW5Zx+qa3ltSMWoPfwJs92/IldD8cts6rzXsy+PqnNiBEHsCMwGHwqSg726a29XvFIo7327r0Yqtb+JBpw4MkWG0cSR+fFEwTK KfwuI7zE xiEwf01m5ukW7VdVDUhlgeOetqRcVI3kYcXBuH41tp5AZGDQ105aik1TWnJ/TJQ2Vj5H5YBBCnruun8zcA4YeHUUqGWe3WZF6TKf2u8MYLgEstZZ7/VXykXpNp7zUIm0RiiREeHqzN8VfiMVYX7wnr2nMlsTkM3OdanUJifqlGqrNA/XyLGKSmSPa+VaU7ZBVhp3D2umgA9KtyuiIdZQ18WxEW5mVEb6O4p6XWrRMdqBTqkMLhFmVJjXJZuPlJ6axzn2pZAXXSefdO1kJtWmMXzaHl947erZuuCRoQHV1vIebsCy/uPaWzZjSDtiSdsgNr7LEaBH3OwjYTajj0x1ojKa6rcwXhute1g+1efG2HPTpNw8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 01, 2025 at 11:54:08PM +0900, Harry Yoo wrote: > On Tue, Apr 01, 2025 at 04:21:53PM +0200, Vlastimil Babka wrote: > > On 4/1/25 16:17, Liam R. Howlett wrote: > > > * Matthew Wilcox (Oracle) [250401 08:26]: > > >> We don't need to put "_struct" on the end of the name. It's obviously > > >> a struct. Just look at the word "struct" before the name. The acronym > > >> "vm" tends to mean "virtual machine" rather than "virtual memory" these > > >> days, so use "mm_area" instead of "vm_area". I decided not to rename > > >> the variables (typically "vma") of type "struct mm_area *" as that would > > >> be a fair bit more disruptive. > > > > > > I'm not sure I like this idea. I mean, we should be more clear about > > > the type. It's not even saying it is _in_ a struct. > > > > > > Maybe we should go another direction and change vm_area_struct to > > > "memory_area_virtual_in_struct" to really clarify what we are talking > > > about. > > > > > > Obviously the variables "vma" should be updated (over time, as code is > > > changed..) to "mavis" to match the new struct name, for type clarity - > > > like a beacon. I really like the mavis beacon idea, it makes typing > > > easier. > > > > I agree with this direction. We should also rename "struct address_space" to > > "struct address_space_struct" and rename folio.mapping accordingly. > > I'm not sure if that abbrebation is complaint with the CoC. :P With that in mind Address Space Isolation series should be actually named Address Space Separation > > > Another added benefit to this naming convention is that the virtual > > > machine code is free to use "machine_address_under_virtual_enrichment". > > > This will will provide colour to the code, especially in the variable > > > names. > > > > > > Thanks, > > > Liam > > -- > Cheers, > Harry (formerly known as Hyeonggon) > -- Sincerely yours, Mike.