From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B539C36010 for ; Tue, 1 Apr 2025 18:52:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2680F280003; Tue, 1 Apr 2025 14:52:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 23CC5280001; Tue, 1 Apr 2025 14:52:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DE49280003; Tue, 1 Apr 2025 14:52:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E1D85280001 for ; Tue, 1 Apr 2025 14:52:02 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5A3E3B6FF4 for ; Tue, 1 Apr 2025 18:52:04 +0000 (UTC) X-FDA: 83286369768.12.AEBC9DB Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf11.hostedemail.com (Postfix) with ESMTP id 1610140005 for ; Tue, 1 Apr 2025 18:52:01 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="nk/qFZhB"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=IFEgjiST; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="nk/qFZhB"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=IFEgjiST; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743533522; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Avd+V83CqKMjKY5z6rVGHlfBxekZGot06UToENPfxyg=; b=TxScmJb+dtGANBdEkolryqnaBGHPWZqMPebgEf042UfJJxQ946pspLdtcEuEUoXE5SFIct grgxhr+3BePFYGvfXCtf48ytj5GigEn7V3zwC7RiNfkWE3a5gtN9vTxLzX+NUCABcJr3fx yKM6ck/9xzmENfYpKP5koPJXROsqYzc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743533522; a=rsa-sha256; cv=none; b=uLkTgFwpAn4qd4PyA2O4W4Bt6vr+fBS372Z6Dxq/0gEaTzy+K12ixzjgFm5JhdwanDXmSA 49ojIAHccweNUNGVsKX7iSfhS4JdeKiRHRJRktQi0yTQeT1sWuW+vDuq47pYXoekjaD655 CxHomdGDXbPqHTLAmvWqAe3aq6px60U= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="nk/qFZhB"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=IFEgjiST; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="nk/qFZhB"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=IFEgjiST; spf=pass (imf11.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1FF5321170; Tue, 1 Apr 2025 18:52:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743533520; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Avd+V83CqKMjKY5z6rVGHlfBxekZGot06UToENPfxyg=; b=nk/qFZhBvYezECcRXBhVpfifFLwOeDqPES+cMW/+gOarQyFcBfulKQaeMRxpbGj/DS12T5 HlBGC+h0jIW3KovRBzyR0OG4cWjHckB880+6i8BjAfNfLhv4ZpS6sqWHeHdmFcznjDYuTt cs0f8PagrJBBhOBpuHSye4N5+3PTcG4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743533520; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Avd+V83CqKMjKY5z6rVGHlfBxekZGot06UToENPfxyg=; b=IFEgjiSTD0e2cxHZ2ydDL2ECb4EesHCuiSkLYB1R3/UYqLFFdqbbsy0GpO77TPFFowi6Cb rTJxcIab0bSocwAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743533520; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Avd+V83CqKMjKY5z6rVGHlfBxekZGot06UToENPfxyg=; b=nk/qFZhBvYezECcRXBhVpfifFLwOeDqPES+cMW/+gOarQyFcBfulKQaeMRxpbGj/DS12T5 HlBGC+h0jIW3KovRBzyR0OG4cWjHckB880+6i8BjAfNfLhv4ZpS6sqWHeHdmFcznjDYuTt cs0f8PagrJBBhOBpuHSye4N5+3PTcG4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743533520; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Avd+V83CqKMjKY5z6rVGHlfBxekZGot06UToENPfxyg=; b=IFEgjiSTD0e2cxHZ2ydDL2ECb4EesHCuiSkLYB1R3/UYqLFFdqbbsy0GpO77TPFFowi6Cb rTJxcIab0bSocwAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id AB8B513691; Tue, 1 Apr 2025 18:51:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id C/YhJ8417GeENwAAD6G6ig (envelope-from ); Tue, 01 Apr 2025 18:51:58 +0000 Date: Tue, 1 Apr 2025 20:51:57 +0200 From: Oscar Salvador To: Gregory Price Cc: linux-mm@kvack.org, linux-acpi@vger.kernel.org, kernel-team@meta.com, x86@kernel.org, linux-kernel@vger.kernel.org, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, rafael@kernel.org, lenb@kernel.org, david@redhat.com, gregkh@linuxfoundation.org, akpm@linux-foundation.org, dan.j.williams@intel.com, Jonathan.Cameron@huawei.com, alison.schofield@intel.com, rrichter@amd.com, rppt@kernel.org, bfaccini@nvidia.com, haibo1.xu@intel.com, dave.jiang@intel.com, Fan Ni , Ira Weiny Subject: Re: [PATCH v8 2/3] x86: probe memory block size advisement value during mm init Message-ID: References: <20250127153405.3379117-1-gourry@gourry.net> <20250127153405.3379117-3-gourry@gourry.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250127153405.3379117-3-gourry@gourry.net> X-Rspamd-Action: no action X-Stat-Signature: p74gorkdr4kewa3u76k7dwbek7isosyc X-Rspam-User: X-Rspamd-Queue-Id: 1610140005 X-Rspamd-Server: rspam08 X-HE-Tag: 1743533521-61125 X-HE-Meta: U2FsdGVkX19r7nVk5L2Vek/EsGPF/xcLfD7fr2ZnnVmPHOoAYY+pfB1S834L7l85TUDxKOKziL3lxyCYlWwajgrMYNwBdHsHnuvOV8nvIc8PMg9GA4aXyoeUg9Ynfi4MvITts8qhQ4zJpcHsD6pqMpOxV/H+ocy9MwAwOdKSl45MvWZI3m9+TEShfK1Vfu/8XSLEqIMOZD+LzsVRpXVB4xgEDv3BG51JKA0rJ/KRuB4aH/nGMTv6c1NskBMRnTiJhp7FCQuGroUJkJaofpk/FREyJ2N8z/US/wDLNVzuDSQBnnd2qK48qBrMnDQnVYf0sYOBEvzSPHK2fH/IFx51WW4ZbcXAIrlSIRb/X4gObEJKnfvBNr/KnVS8CwhNsmQ+mxIqUY3ZJ0Yw3cljA+n3phxVoS8GUBg2qmTHkk0UJAoXXJIUwHknYgQE4/9binlxbyKOT3PBY1YRSoUAjzYbQ4aaGfZ3i90PLO5fsg3xLaWVmU3bb6o4qs98dMzvP8uz06tGIif6lMLBBRLlanRLIZoAkfHd0MwU5SvUshpJN2fWE2kKrZ0eY1v6e4R8sHj4eRj77PIHRAMvgbI/WNU9Yraem+iykqhr3iIwAx/0neX44/vH3ryqbHR8lGpvcK21T7cJk+Qm2dilNt0XB3ZvNblT0476zYfZLutxSxdAPnqccUjU2Aflte47lbJNQfFFRCX8azhSa5akTWjAZdnq1iB8RoUa1AKQsDBSMZDMLPmKOau8r5LyrSvRKkO8f6rYxwBQPBV5P/+b71bXSRMVyL1dcvKIU1NTiQtOzhna3I4JlJPFEtLw/AU5uwo8cU/KyDZQypMtm0ZEglXeIJ2xx7kJUKPyjgOlWxvCGzniqWdMfTOABb8jyjyo9qV36C66lrf+ipJ2WOsRX+47NntAinmIHkSn2syaXuhfRItGJ+WT4h8t/9h7hMdm5NrGU5r0sDJsjPmMIFaRaLEB8d4 sVdqKWyl BjAVAQ98Y1WUAANreiBLnFajvzpk+7Vt8D6cfCEfzfWVeWwlw4o+qImXFPdgZdf2pa4yqFNElFxHaDWkS2gYfjURnwzM/WPx0/pgi8r2aXVw03Wjd9wLa9go3461u2pO4gGbYoCadsRiNeWVVgbo1D3CqVUeaSuXJdjAqkS+aBDshTZFM4C15qHimRhau3nnrY+knEpcwvw7KnFoe61H8QIxq61+5Kgekk10eZPudOn7ULF6ocuWWlA73hcLZ7QDktYq48l7JUq1B+NBu9/S0HSyNCGSEreA+0xCCa2vF/RaX70HM4C+NPT2NMdEcoZ0d/480qE+t7ZIC/Tn6ht+VkkwETcMs6jqR8A20w7Y+Ap+loXURKW8anwoRPzPDx8egGq+wl+uUPNnn+tAGEayInVePlw7IoTfISLYd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 27, 2025 at 10:34:04AM -0500, Gregory Price wrote: > Systems with hotplug may provide an advisement value on what the > memblock size should be. Probe this value when the rest of the > configuration values are considered. > > The new heuristic is as follows > > 1) set_memory_block_size_order value if already set (cmdline param) > 2) minimum block size if memory is less than large block limit > 3) if no hotplug advice: Max block size if system is bare-metal, > otherwise use end of memory alignment. > 4) if hotplug advice: lesser of advice and end of memory alignment. > > Convert to cpu_feature_enabled() while at it.[1] > > [1] https://lore.kernel.org/all/20241031103401.GBZyNdGQ-ZyXKyzC_z@fat_crate.local/ > > Suggested-by: Borislav Petkov > Suggested-by: David Hildenbrand > Acked-by: David Hildenbrand > Acked-by: Dave Hansen > Acked-by: Mike Rapoport (Microsoft) > Acked-by: Dan Williams > Tested-by: Fan Ni > Reviewed-by: Ira Weiny > Signed-off-by: Gregory Price Acked-by: Oscar Salvador -- Oscar Salvador SUSE Labs