From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F030C36010 for ; Tue, 1 Apr 2025 14:03:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86CCE280006; Tue, 1 Apr 2025 10:03:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F589280001; Tue, 1 Apr 2025 10:03:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 695B4280006; Tue, 1 Apr 2025 10:03:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4A54B280001 for ; Tue, 1 Apr 2025 10:03:11 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D5425C03C0 for ; Tue, 1 Apr 2025 14:03:12 +0000 (UTC) X-FDA: 83285641824.17.579B3F1 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf03.hostedemail.com (Postfix) with ESMTP id 9BDF220010 for ; Tue, 1 Apr 2025 14:03:10 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="18PN1ce/"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Tv6oQ6jy; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=aKgTWHHD; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ineTQmfz; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf03.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743516190; a=rsa-sha256; cv=none; b=g26bECKC+iQlWESvSNO9uU0GNWKFtfeMTaJKTOeLrFKRxRdlOvzupXhb1FIFusR5pf5to6 FR72N7lGG/pUZ1YHuisQMnHLLrZyHh/+8FAayJ3v8g0aBMUVL2nJFaKjxQPSHHctONHII5 2fC/x1NkttjeIR+WanCRPepeMzbILxc= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="18PN1ce/"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Tv6oQ6jy; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=aKgTWHHD; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=ineTQmfz; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf03.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743516190; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Jj9vWZeoAUzkYdmfSEpF/aL9/NzMXGds7KzoCm3bc4I=; b=gIVhApLKe8ADQeJ2H2sj8PCb8F/s8GbzfNxXtSpZaBs/3btIjtLXd9BaBNy3BFbBOpbNng KCyr9q1M6U7pBJqI9Y73ZqR1GEV/P8bfsp56cY7h/RZiF1mZuXevn/V+C+iMktC9ptC86M R+f4rD/nI5xzeAHLiaGkCHIwhqjH+Pg= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E619421188; Tue, 1 Apr 2025 14:03:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743516189; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Jj9vWZeoAUzkYdmfSEpF/aL9/NzMXGds7KzoCm3bc4I=; b=18PN1ce/+WUuLFogKF+6gixFI8ILqw9yL8p6hN9Dd0s0Sw7hxoVfc9AZa7Y2Pgwy2ey54Y x6Jo8Gii2AzAzkcy6HQCQGnFXM7tnErQe/yiIjtRU3bGKFIU5zrTi3ML17CZy9uIGec2tE 12ClHPizWbS1fNjaNEXHebvvsUSDRBE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743516189; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Jj9vWZeoAUzkYdmfSEpF/aL9/NzMXGds7KzoCm3bc4I=; b=Tv6oQ6jyN9VJwqH6oIo2U3kxA0rxWPVhCn3GvjOjgOM1AOfTVKklqUYlc1/6+rRKSOCsHI NQtMEUqk4huTTHAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743516187; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Jj9vWZeoAUzkYdmfSEpF/aL9/NzMXGds7KzoCm3bc4I=; b=aKgTWHHDreROvhN1dH8d0LtVrvnWvFkz8MsCHVhP0TnhZ51TpYJ/DxVloDNWUqjDZrbLOF TejUPoAW7SdAbWFz09SF6KQey4X3Rj1PgyHl3868ssX9gw+m7aarNmvdHlWBO7T+FHNmSD Je+8cZCM/0Q+3D+RXtsTb4lq4CjKSJ0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743516187; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Jj9vWZeoAUzkYdmfSEpF/aL9/NzMXGds7KzoCm3bc4I=; b=ineTQmfzNShJYOiXtPLd9pc8CAAu+3z5GzcwDKBNdEXCiqKiLjyhS6AFrtUhWk9UNPOu3e Hbih/lnA+XFHaVAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 85D18138A5; Tue, 1 Apr 2025 14:03:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id jPMVHhvy62cmXQAAD6G6ig (envelope-from ); Tue, 01 Apr 2025 14:03:07 +0000 Date: Tue, 1 Apr 2025 16:03:06 +0200 From: Oscar Salvador To: Baoquan He Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yanjun.zhu@linux.dev, x86@kernel.org Subject: Re: [PATCH v2 5/7] x86/mm: remove pgd_leaf definition in arch Message-ID: References: <20250331081327.256412-1-bhe@redhat.com> <20250331081327.256412-6-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250331081327.256412-6-bhe@redhat.com> X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 9BDF220010 X-Stat-Signature: u86najrfqyy4fg7fjbbk5p8c4nja4xrr X-HE-Tag: 1743516190-708173 X-HE-Meta: U2FsdGVkX186LYRQ3rG6+vUVH/l5qusL6zYAH15Kc6aW/lg25fVZXT6u8xDR/8npNiljij/Eu+i25Y5zak1Y5dPDxOXapG5BURm3RbbNKKWdRuFz8n5VP/3tTHN1Pcdqx0hTEyorsqPJoHWCIEoLVQDPTO94/Fe7wS5f0CFCvZdO4rP/FkxDBbltuwcgYQezjHZRZm2ly0KFUO2zx3voM2mDZGNykvizGyBFA/ULdaP7GPXLjeClThhoifn94H6lNb6gBHVRX05a0kjNXCiWXoSXMgUVj2pBSJOionNm4BhuGy1CAe7agAxSUxOPt9nEgGzxTGM5XXbVjGq01+LljDRHNzMW4OkwsMTWuO2oPHcSt0+qxxnswYReOjbxJqf1uWlChYHq8Th/OFZMtJskr+3zLZO/AvBhpnyVNwh2tqRHDxONfHhaF2MtHE0Hz8DSpBl/LedxmoRSOWzPc9MS3Hw9lk0OivcfFRgiCVtgxkiKhvgBYx3MzcFoxsHytvVzkGJmQlHNOfIXnJOq8XKmp4Ci3NnsIKvsL5xesAeRh8ynAmaKdnyejzzoFbMQPb3AWPmHeqr7fCTnpA4z+AOjj4XRfpDZkdd+yFH4bmqZRZRPGI+iM39TgXFGIFsJalkGI5HGOZzle+hPSHxVQtlpG4jwLUb/3DwM2ite6l9xtdqh6g2rp2MSSz+8HzEbcPNrq/bIQ5JDJ6IyhGscKCLuV9syNMSt8+oD0nr0L/w0APd3tHPzf2c950hQCKwdXrkfDD2Wb56vyxT3zA00pAngWD2ubOlzacj9N+qRzNuZ2JjB2Ugqx3klImyoG+3ws+TScRCnsMVi7XlingSOSePaQuSsVSKFhrXIF8r7l1+WND0lAUMZ84mRODHWySLSyGFEzGHEaIZs8oRxmWyM9kWudo7MDH8vGEKLx/obkPzlWpfa63e6+IlsugtAuWOv7J5i0H7/Hw9Or0re1Vk13UW AutUq5Da 5Ow6aA0+J/cl8CaNYGrO027p0nb3gL1yGbS+rLWocuUVYn+hL4E0o1KycxPpMbO8HuZJZGPzr3lkPJ9tjp0yRPNLT/92PfRDnOz0A4zTtMF3cpIjU3SR4GBeqpfifVRv9qG5wNSjq7w3B7ipBGszopUVIoE65Ptk8JZtkfQdIEzyUWAjoWZ/WiFbu/IfO7n3aThvJNts8erV3pvzMMNyZ9vev8Vc1LnhrTMFXDWXIBhlJjqgfh51FRbsFkdtbF/F4yaltS231tsGuIzWrgGWbK+SQkgqTDZVPiaMc7HR+QSTEKkNscqP3/nbJi0AXvCkb6tFKSe99RtxjcrL5s3kcG5uQwyYxmZADxCc1TwHbzBq61j7ckwMeiWCCi+dAKbvj8H0t X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 31, 2025 at 04:13:25PM +0800, Baoquan He wrote: > pgd huge page is not supported yet, let's use the generic definition > in linux/pgtable.h. > > And also update the BUILD_BUG_ON() checking for pgd_leaf() in > pti_user_pagetable_walk_p4d() because pgd_leaf() returns boolean value. > > Signed-off-by: Baoquan He > Cc: x86@kernel.org I have been carrying a sort of this patch in my tree as well for quite some time now, and I think that Christophe also sent it some time ago, so glad someone finally pushed it https://patchwork.kernel.org/project/linux-mm/patch/20240704043132.28501-2-osalvador@suse.de/ Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs