From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21BDCC36014 for ; Tue, 1 Apr 2025 13:51:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF115280003; Tue, 1 Apr 2025 09:51:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B78D9280001; Tue, 1 Apr 2025 09:51:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1837280003; Tue, 1 Apr 2025 09:51:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 80998280001 for ; Tue, 1 Apr 2025 09:51:55 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F2EDE80234 for ; Tue, 1 Apr 2025 13:51:55 +0000 (UTC) X-FDA: 83285613390.24.6E43DFB Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf26.hostedemail.com (Postfix) with ESMTP id BBD3E14000C for ; Tue, 1 Apr 2025 13:51:53 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=TcFA5SZi; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=FqwTgoTC; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=TcFA5SZi; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=FqwTgoTC; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf26.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743515514; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RG24GCY7wOPa8cPzvXOhJ7YDRKS0RXj4+VcNrGOGoxw=; b=8ev+3x+rhJcXQJrF0kFySRoogdWpLFyeNn6IPuqaLOTy9EcErawKWHXy7lj0pEJiuSWMHS YNE7fCKGsw/e10ZFQgNaedrFE8oZxQ1ErSgqs4pqvdRf/iqFBZBs0fbKOTnRu3rJbFGIPz OQ7dp/64EV6s75I9739nmjzp6N2cKBI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743515514; a=rsa-sha256; cv=none; b=yvC7GhhoDVosLaXIePDnkTTmAB5DdGlKjEVT53ZowuGZNjrJPS2bXToHbRDMmunoctkAV0 JF9uuGOhU/zCE/QDBHdWuJMEdIxDeY6rbUQyfcfArmr4RwZ+UasVVKrBT8IbPPR+qCuaIJ l9BaJu+duV3S9H1VuIaI/l5NKi9zht4= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=TcFA5SZi; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=FqwTgoTC; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=TcFA5SZi; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=FqwTgoTC; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf26.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 374C4211E5; Tue, 1 Apr 2025 13:51:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743515512; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RG24GCY7wOPa8cPzvXOhJ7YDRKS0RXj4+VcNrGOGoxw=; b=TcFA5SZiaEQhVwqcRBiRU24icdTIeZCYSWemH8u4oeAE1sWvjjabsWYw46ox5Jrh+UIQxI yDkNvY9pEO6cHDwdjmwHtSmsuLLW6xTIxqJ9fv+RFO4ecDbOWPLwTkna/QCnaUt2u7XOXU YdhiVO8TlXz3APg3o5tSY+Cd+RilYcs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743515512; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RG24GCY7wOPa8cPzvXOhJ7YDRKS0RXj4+VcNrGOGoxw=; b=FqwTgoTC7hyqwNrGa+JcEvH5KdJUBPaGHWTdENPjruxa4Z+ucy8w4ki/B6lRGrdE0G9HvA YV14gg1EhTr5DEBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743515512; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RG24GCY7wOPa8cPzvXOhJ7YDRKS0RXj4+VcNrGOGoxw=; b=TcFA5SZiaEQhVwqcRBiRU24icdTIeZCYSWemH8u4oeAE1sWvjjabsWYw46ox5Jrh+UIQxI yDkNvY9pEO6cHDwdjmwHtSmsuLLW6xTIxqJ9fv+RFO4ecDbOWPLwTkna/QCnaUt2u7XOXU YdhiVO8TlXz3APg3o5tSY+Cd+RilYcs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743515512; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RG24GCY7wOPa8cPzvXOhJ7YDRKS0RXj4+VcNrGOGoxw=; b=FqwTgoTC7hyqwNrGa+JcEvH5KdJUBPaGHWTdENPjruxa4Z+ucy8w4ki/B6lRGrdE0G9HvA YV14gg1EhTr5DEBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D751E138A5; Tue, 1 Apr 2025 13:51:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id qC+5MXfv62dsWQAAD6G6ig (envelope-from ); Tue, 01 Apr 2025 13:51:51 +0000 Date: Tue, 1 Apr 2025 15:51:50 +0200 From: Oscar Salvador To: Baoquan He Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yanjun.zhu@linux.dev Subject: Re: [PATCH v2 3/7] mm/gup: Fix the outdated code comments above get_user_pages_unlocked() Message-ID: References: <20250331081327.256412-1-bhe@redhat.com> <20250331081327.256412-4-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250331081327.256412-4-bhe@redhat.com> X-Rspamd-Action: no action X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BBD3E14000C X-Stat-Signature: 8dua7qz1dtr6fz9wukw13j6n8i87tx8o X-Rspam-User: X-HE-Tag: 1743515513-132389 X-HE-Meta: U2FsdGVkX1/rFlVhvYkGHxYNcdOUsaJLwg1r4YSkPefef1ZASdtb9QxYQKMIOQw9cpHAMJVJ+L1niA44hfcqVhiWY0rWTu2Ks9rA2JPFwrxJvFOaeP4M5mDxX444iX2jYhVjPzkC9o/fWSE6iTKeYSKkLOFjU/x1WTiK7o96R5HGYNMHfpkK6Y35biLYmvrTlifG6bsU10pS0Mn8MQ35MjmvH+izu701PaA/PpEXjT6GWBntP03T248yUvH9ja6clJk9LXMURl8uDO+S54Djo4hYaPhFCD4Uroz4QaYpNwtkNXSVNHtoJLLQxftYzkilHFEwF4EYxLME7xQhBPdh6DBzlWbY6EUeaFIoLUJY8tzOvIB0b9wBWNhCcVp5bp9Ssg+xjwArbuKBQV5lbSENLUm6nhYD9dV34aVsDwtlsqCgLGiOVu/0uH3ZKkHVbLLVL5bOE57Y1J/91JraS8i7V/fz+M1+sDSB7W5NGZHKuMxFW+CCT6Pz6t/eciObh+Zq/tVk6eDeUrQeQbdEUWwAuulR6cosJqnhLhuSFglDJb3OaN7Se4sGczCMcpR+L4fFwluGejlIdAj0gg4SnphvlbFJVuzlKZfK4pK1uBiYntqpjArkWE2Wfbmb1Pud8xfJq+bratOuouVDT2aoa8w0ovOXJNl+VWjMJswMjNUOxJMDj2RUZCIUJ6InqH6NzLCtAcdzTzxo8udMBFHwiQjAWopW2VZgUobUcWovGjDqqVTo9cr+oIwQB+2/QS1MEc4eoHMX3cYL+o9Y7CqpHwdRzegZQJyrRqwLA1EDXPfvWxFKTt5OxfxNbFtqtAiPE1lLfaq3jgCuZrLxmCNh7nJaldbHhCbSbg8otEoxWSLbLIF6BS/IFuzHsDigD+v0knHpWh8GzMAndkG1VoIT3TPmgfwM8Zk9lQZ7rFV79+q/k6POR0cidA539LwwXfIeX9n4YyTfBQNdoxv9JZOS1Vr kJDOcky2 3gu0V5POwoj9hHGUpBBa/Nzsb63ChvOKPcb3FK0JcacVpTIm33UoVJsJZKZM7mE3N25x/aKnRzFTryWpyXRWS8jpqEP/Xapc6569upEHfnkAZw0QUmiwyieXMP/P4fHuEz/V0jWpo+E91UH8ojfWcWjGRCu4jSyR4c3ukpGMJ7rk/6Ld4EDYnWW9hBMu5kRAiIEqqn8Y37blWnFPrTdObXdbe7/vjNYV9x7wVrAam23nn71V7rRDVePYgLVZrkkuf/TN3rj2i/JWj4WTLGevcIb6oM7YCWPz17tu6XyfC3N4oTnb/QCo+6tKnPVbSAU/dc5Eb5OQp1KBZrvEZr3JGuJXadDcQ9WmwbDIK4rpy+KTz+IQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.016475, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 31, 2025 at 04:13:23PM +0800, Baoquan He wrote: > Since commit f0818f472d8d ("mm: gup: add get_user_pages_locked > and get_user_pages_unlocked"), get_user_pages() doesn't need to have > mmap_lock held anymore. It calls __get_user_pages_locked() which > can acquire and drop the mmap_lock internaly. > > Hence remove the incorrect code comments now. Uhm, I think this one should be dropped according to https://lore.kernel.org/linux-mm/20250330121718.175815-4-bhe@redhat.com/T/#m1aa161016ab98a6d85bcb657a729e01cb98763ec ? -- Oscar Salvador SUSE Labs