From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8130C36010 for ; Tue, 1 Apr 2025 13:20:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E8C1280002; Tue, 1 Apr 2025 09:20:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9BE64280001; Tue, 1 Apr 2025 09:20:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8ABF0280002; Tue, 1 Apr 2025 09:20:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6DC1C280001 for ; Tue, 1 Apr 2025 09:20:05 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AFCEBC23CD for ; Tue, 1 Apr 2025 13:20:05 +0000 (UTC) X-FDA: 83285533170.08.1A8F0DD Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id A68321C0008 for ; Tue, 1 Apr 2025 13:20:03 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YIaDl7Mv; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743513603; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aLA++7QbgSutvFaC1htYkrD41KHYBranyoZiDvoDoCE=; b=qbErdjsAPD0ACQokDGvWQfiG1oL1KHxHx/kQZXn28aBdGWmYjFvIqjRlYYTzOT7lG2gArS NITLS7tdO7EbVVJtpk0SeV8A4kEDc9SvifbWKWutA9WMgi+JPjM2jY66M8HHXZfSZN/5BD +pDIgYEqqmrvcQhs7f1Loe+51IVtpuk= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YIaDl7Mv; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf18.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743513603; a=rsa-sha256; cv=none; b=5ZJXfCnQohyys39WpLic93/9CCpnIhyPX2wrekD+tZaIOAUcRqzeNQe7dGqB+tYue5KZDp WYWWiwqqWe+VFDDGbl6u71TIXRnX5TiUCS83AlZ/pTViiPPyQXnerXA9PSYR7/YCpbwZP/ 7G3yQ/T4MrZUjdtem6IxlqezEuSYzVQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9E3045C4A91; Tue, 1 Apr 2025 13:17:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DDE0CC4CEE4; Tue, 1 Apr 2025 13:19:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743513602; bh=9wSJvejkq5NxPrQKr0Jhsiek8qkHChwl57pzJsxs7qo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YIaDl7MvazjElWMG6+MRQRAKFy4pTiPH2Y5kKB+bwOeQGRBx28iNTxNhm+kBGiDtp 4YKO8ZQVxGwwSlju1t7NgbfrcAPwjIo8gvofNVbWgUvO0GBU0+rwWFjhkT3apkAmJ4 uY6pQqwyoDvqNlDYRZ6RCPga2q3TC6ojEw3OP+LuTxjk5AxZLRDTvJDoDvb6gOWS6h jWngKU0OhKMznLLv+XUMAgOMR4RZ/zSX670RxahSYlQ+eSNB6tA5K2+nNlGWzX4fN9 HG0WNS17ib8DRY6FK3ZVY7oTA0kM7Eb5cnhK7WDEDKBVJRdkqT7xn73igeNcfTzWSk KgnRbPM3oyH6A== Date: Tue, 1 Apr 2025 16:19:54 +0300 From: Mike Rapoport To: David Woodhouse Cc: Andrew Morton , "Sauerwein, David" , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , David Hildenbrand , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v4 2/4] memblock: update initialization of reserved pages Message-ID: References: <20210511100550.28178-1-rppt@kernel.org> <20210511100550.28178-3-rppt@kernel.org> <9f33c0b4517eaf5f36c515b92bdcb6170a4a576a.camel@infradead.org> <1787b97c267b53127c60a61419d99751f8a66b1a.camel@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1787b97c267b53127c60a61419d99751f8a66b1a.camel@infradead.org> X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: A68321C0008 X-Stat-Signature: 7qfs7oogxx9k5r67upic6phbtekwyah5 X-Rspam-User: X-HE-Tag: 1743513603-551497 X-HE-Meta: U2FsdGVkX18E+Xe8/TOf+LKWpgHP3FdfG9TamK92WxOUWI8Ns+zCUkiz66AaYqy8a5P33c/8l/MudcJxYCeAFfJVZVpLt2VB1lzs7Z0nwoTKDxQT+MAjKoe0hLwWOVxH8x1BISXm3UPMccGIJaeX1c7bVSWmhaGzX6OcoCpAi4r3iaUVYGYmgLeHBOmEAMWLI2qPnouH2b3w/JDD51uPBfP/xOWVvww8u/qvkvQ5MGXJB+xng8yysEKBbmqIV+puW2FJ83QuV6mG5SMy4vhsDB3T5tZB7n1fz9aPHjloLsVN/jLniyrzUPbfme8VQZtshEZjq9wtY3W9pFdEOx0C1fE7UVYfYaekInKR+lbwPvSKJfJO3lZ7mTZyOYS6PZgDk0ua2xwHiJQCHyrOg0B3S2jMDRUShl7fwtI+P9Su/9WVmcwSYBw+zaen3sosS5ec+xQNcC/HyLKtSt2wcS8GTONA7RZ+H3aQCNT23QpXJki0ERyQPYrBriuC4pmtxIfdpS1XniROKoxAe1qRquzujRrO6SkF47svD1fJ87o6Ncs8pvc2mqYuJB1v/HTScCIz22rIx4fzdm862nfExucuBHK8zsV+z08sP1KLd1plTVl31Uay/q84tQ+GV9ETg9drb3cP43nUSvAJ+7J+WA1D36QnL/ef3AbL6tFVTSTNzqoe6y9z+EWv7vP1u5D9rQH5Kvbst4fWXd5j9BNY6PZ97/08F40z7VXMedj+oBgwqhLg2PvCXw+TSI5HcwRCrpkTdXt14O9V5KXNc5kOxEUGZ7+qN1upNm0MdQfWHzbXBVcFRn2lHNKqfqYu+7urOt/2wrQak5s7UIdmIdVh4AkdLSwWBYKFDIyPXte5Ld+YQcWJ3gNT2b8YlyLQzsHdvadwYr4x3x8BwopcJD+BqWHV72aAbbUFZifWCZop2Q7wwnM3uHazuKS9HdSbf27Gs714VNoytQ+2pWHvZqph7ct n2NYcIcA /Ag3MhfaoZqx2qQlnrj+bx+KaAdGcWbN6iGy8M2y7tKgeVQp0DlgfGtHa7zIEgri3ZRPICWN1JlCD/pTQ4cBnjExiwx0We2pqzXtHa8jCYpAKFH4XtfqVGduy0hbZ50xmtka5tEznCcGK+ntuIHxlmm57clSQ0BeXkyZNt9CswnLh79dbuEjgkrYIF/ntF2jAufFveFjtdphQ5YWK9o3qdb52P8JdoPg3djxvUZGfz/ewisCcbmCB1PlWzYg12eTMmgQmYVjGA8CqzDfSlu82JQmX6Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 01, 2025 at 12:50:33PM +0100, David Woodhouse wrote: > On Tue, 2025-04-01 at 14:33 +0300, Mike Rapoport wrote: > > On Mon, Mar 31, 2025 at 04:13:56PM +0100, David Woodhouse wrote: > > > On Mon, 2025-03-31 at 17:50 +0300, Mike Rapoport wrote: > > > > On Mon, Mar 31, 2025 at 01:50:33PM +0100, David Woodhouse wrote: > > > > > On Tue, 2021-05-11 at 13:05 +0300, Mike Rapoport wrote: > > > > > > > > > > On platforms with large NOMAP regions (e.g. which are actually reserved > > > > > for guest memory to keep it out of the Linux address map and allow for > > > > > kexec-based live update of the hypervisor), this pointless loop ends up > > > > > taking a significant amount of time which is visible as guest steal > > > > > time during the live update. > > > > > > > > > > Can reserve_bootmem_region() skip the loop *completely* if no PFN in > > > > > the range from start to end is valid? Or tweak the loop itself to have > > > > > an 'else' case which skips to the next valid PFN? Something like > > > > > > > > > >  for(...) { > > > > >     if (pfn_valid(start_pfn)) { > > > > >        ... > > > > >     } else { > > > > >        start_pfn = next_valid_pfn(start_pfn); > > > > >     } > > > > >  } > > > > > > > > My understanding is that you have large reserved NOMAP ranges that don't > > > > appear as memory at all, so no memory map for them is created and so > > > > pfn_valid() is false for pfns in those ranges. > > > > > > > > If this is the case one way indeed would be to make > > > > reserve_bootmem_region() skip ranges with no valid pfns. > > > > > > > > Another way could be to memblock_reserved_mark_noinit() such ranges and > > > > then reserve_bootmem_region() won't even get called, but that would require > > > > firmware to pass that information somehow. > > > > > > I was thinking along these lines (not even build tested)... > > > > > > I don't much like the (unsigned long)-1 part. I might make the helper > > > 'static inline bool first_valid_pfn (unsigned long *pfn)' and return > > > success or failure. But that's an implementation detail. > > > > > > index 6d1fb6162ac1..edd27ba3e908 100644 > > > --- a/include/asm-generic/memory_model.h > > > +++ b/include/asm-generic/memory_model.h > > > @@ -29,8 +29,43 @@ static inline int pfn_valid(unsigned long pfn) > > >         return pfn >= pfn_offset && (pfn - pfn_offset) < max_mapnr; > > >  } > > >  #define pfn_valid pfn_valid > > > + > > > +static inline unsigned long first_valid_pfn(unsigned long pfn) > > > +{ > > > +       /* avoid include hell */ > > > +       extern unsigned long max_mapnr; > > > +       unsigned long pfn_offset = ARCH_PFN_OFFSET; > > > + > > > +       if (pfn < pfn_offset) > > > +               return pfn_offset; > > > + > > > +       if ((pfn - pfn_offset) < max_mapnr) > > > +               return pfn; > > > + > > > +       return (unsigned long)(-1); > > > +} > > > > This seems about right for FLATMEM. For SPARSEMEM it would be something > > along these lines (I kept dubious -1): > > Thanks. Is that right even with CONFIG_SPARSEMEM_VMEMMAP? It seems that > it's possible for pfn_valid() to be false for a given *page*, but there > may still be valid pages in the remainder of the same section in that > case? Right, it might after memory hot-remove. At boot the entire section either valid or not. > I think it should only skip to the next section if the current section > doesn't exist at all, not just when pfn_section_valid() return false? Yeah, when pfn_section_valid() returns false it should itereate pfns until the end of the section and check if they are valid. > I also wasn't sure how to cope with the rcu_read_lock_sched() that > happens in pfn_valid(). What's that protecting against? Does it mean > that by the time pfn_valid() returns true, that might not be the > correct answer any more? That's protecting against kfree_rcu() in section_deactivate() so even if the answer is still correct, later access to apparently valid struct page may blow up :/ > > static inline unsigned long first_valid_pfn(unsigned long pfn) > > { > > unsigned long nr = pfn_to_section_nr(pfn); > > > > do { > > if (pfn_valid(pfn)) > > return pfn; > > pfn = section_nr_to_pfn(nr++); > > } while (nr < NR_MEM_SECTIONS); > > > > return (unsigned long)-1; > > } -- Sincerely yours, Mike.