From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05AD0C36010 for ; Tue, 1 Apr 2025 14:11:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 826A5280003; Tue, 1 Apr 2025 10:11:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7D531280002; Tue, 1 Apr 2025 10:11:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 674D0280003; Tue, 1 Apr 2025 10:11:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4C3CB280002 for ; Tue, 1 Apr 2025 10:11:54 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E76AB1A0283 for ; Tue, 1 Apr 2025 14:11:54 +0000 (UTC) X-FDA: 83285663748.26.B7C6387 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf08.hostedemail.com (Postfix) with ESMTP id B9CED160005 for ; Tue, 1 Apr 2025 14:11:52 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=aMhIagR6; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=fQ6Fn7IO; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=aMhIagR6; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=fQ6Fn7IO; spf=pass (imf08.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743516713; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K75sT1uOE2o2JxpuzJK0ApZypw9om3Mo5Rbs9DxBWvg=; b=oQPpg4JUMDTBUpIEjWNE63APE+2A3mE0p5d10DAI0MioW5/qlw6vTUtKjdsS8iRKaUlQ6Q EVzf4f+zUNdGrV8efSUb+q683gmvDH+ReiXA1qNyMuK9KSvKAX0N9VXnHBvvkfbEt3/+xt p3/DsVd/Vhum2P3fYqhE66c+Xd+oieU= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=aMhIagR6; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=fQ6Fn7IO; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=aMhIagR6; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=fQ6Fn7IO; spf=pass (imf08.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743516713; a=rsa-sha256; cv=none; b=MEDIgeC0NYX5q3GX/6p/cts2AzFlVAgHW7sGyYR/mOA7NIRRstVAO6XVLGBqPlRQyiiy9k hMArzCnLyjMQ4r2uhsZ422wADYKS8OB5zIYcFtXQd6mNV5KOXBYHYqx+AFsGL7V8VZTw/2 NxnYM9KG+IR1g3U/YywSUusQBBQriJc= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 423B3211F3; Tue, 1 Apr 2025 14:11:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743516711; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K75sT1uOE2o2JxpuzJK0ApZypw9om3Mo5Rbs9DxBWvg=; b=aMhIagR6HcL2s1dNtPineA2kIKgnebcZC6J5FJ2AE87CDn+j47OISMOq7ASVn+8iZB7WHM kMaZPxe1K+MmHE4z912HZcnpvkUZjf88hAApOa8PU1o94kK9gRTiD2/+Nj4BnNTsunXyxv djrt78yTTrJW+wYpfMa44tpuP3UYGCM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743516711; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K75sT1uOE2o2JxpuzJK0ApZypw9om3Mo5Rbs9DxBWvg=; b=fQ6Fn7IOyJLaoFncWAx4DD5C2/UvUox1o1Lg+YsHn9Irntk+D/M2MeTbr84D3vi0fmttT/ vCM8Y8oLMaaz2uDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743516711; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K75sT1uOE2o2JxpuzJK0ApZypw9om3Mo5Rbs9DxBWvg=; b=aMhIagR6HcL2s1dNtPineA2kIKgnebcZC6J5FJ2AE87CDn+j47OISMOq7ASVn+8iZB7WHM kMaZPxe1K+MmHE4z912HZcnpvkUZjf88hAApOa8PU1o94kK9gRTiD2/+Nj4BnNTsunXyxv djrt78yTTrJW+wYpfMa44tpuP3UYGCM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743516711; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K75sT1uOE2o2JxpuzJK0ApZypw9om3Mo5Rbs9DxBWvg=; b=fQ6Fn7IOyJLaoFncWAx4DD5C2/UvUox1o1Lg+YsHn9Irntk+D/M2MeTbr84D3vi0fmttT/ vCM8Y8oLMaaz2uDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id E09AB138A5; Tue, 1 Apr 2025 14:11:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id aKUmNCb062frXwAAD6G6ig (envelope-from ); Tue, 01 Apr 2025 14:11:50 +0000 Date: Tue, 1 Apr 2025 16:11:45 +0200 From: Oscar Salvador To: Baoquan He Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yanjun.zhu@linux.dev Subject: Re: [PATCH v2 4/7] mm/gup: remove gup_fast_pgd_leaf() and clean up the relevant codes Message-ID: References: <20250331081327.256412-1-bhe@redhat.com> <20250331081327.256412-5-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250331081327.256412-5-bhe@redhat.com> X-Rspamd-Queue-Id: B9CED160005 X-Stat-Signature: 9489x4rfz3g64x6hc3tbpe8617joztjo X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1743516712-793494 X-HE-Meta: U2FsdGVkX19+7w+P2Q1jumb0pxgbYrdKM6XMpDQF0NbmfU5VWQGM6YYF2mZCg3HjLZFSPwGJdTv+eC6tOCwAwLa3Rvsxc/R29szae8wbq9/OjWWPA9Ag73x20EkG7qHGShteHvA0UhSWrUF1WoaCpd1j8UjJGjsEqOrO2g9AlAd2UK4NattKlGpunK4ZtP2V/9b7RzatfNclaQVeSvp33WD56Oli1aFG1yZ1ZHg4U3UVOzEoX8ADjGJoXvsKX/0LFReRR4vWCmqjIDip5vTuB1TSZc1at9gd/J9lS8vnJu7+O55BXBoGmMPs6PBRPwCive1p0cKDnj7qXLS0cxlDn1TCrl+y59imkf5OvhYL2J/EWw5vpxV40GEGOEt4qOMSCC28FX+i9ED8U6dRmAwaRD+GuynK6qeHqV43hdDh2Mw8LxRFlAZtX0gEbXOSSTfkCGQC9eecqjyqhFJpKwF2SPbPwXi22ai3PaBbbHXFlzyqpPUvfCKqO/eU2dbB86sr18YBsc4h+QioXPf764GA5k8oc63KqUNIwyLl/94fu5KOAxV9gu+IBE7/KD7kHP+9hUqOT4Ajqy5W0SmIdjEkD5HNBaHul0NW6Pruvjkx9zlYIgLjelC2ac83MpdzinHEY7/Q3btmZodPcvoRWHBrZ5TjtOl02pPH2JpNYA8myYqSe2T0E28cldI5fDoeUv5r0EiIyKpLxQyOn2qvp0bb76/7emiT61ndE6iIwDnlFY6HUWChg8u1hNvoxvZfTwLdKEgOyphDTD1j1TLUzeYYupBbwyR7DOLKefcaKCjTDT/p9hcD/djjKw8EoTLyhIFu1FEZjt1+anlVLvqNa/vqOabity7ylTzf6ofIdvGoVMPja8hHpRPV0Wu8OCs0Ng66BCRPUn4McN1gqlN02QwrgZwDUlb/B7yO5//oJ7GWbgx1njzuXBTWm2PomltjgndNFaW3mbXWzwsAfpE/qcN ty/ggw84 gyfaLUpCPvWahPV3XVOLet6OkWCZbGWVyHqe2Zv02L6DfpcL9JAXemxvX2nN0b33XyD+95m+WlCtLmLRSRIP+8L/aKGjwUaZpSH3809etbDgCJWcW425TQ/a2W7Hj/bCIGSo6ymJEhBxgd9/34+EQKulsJnqxvjGaa3YlUyyL6IO+5SEb5zczKMQXb52cjgnJFJn7JOHZe+3fqhgFIcnQh8C8C+UqvixqYVstVGp7vRye1jSJNP0tf7xxNcNG0ZtVS6Ma6MXe6JWA+0LvKOQif8QbK1N/kllcAmwHlNIyYlo21RjbIQqVNtNCfdCb8NFM3w77THotxim10gM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.009595, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 31, 2025 at 04:13:24PM +0800, Baoquan He wrote: > In the current kernel, only pud huge page is supported in some > architectures. P4d and pgd huge pages haven't been supported yet. > And in mm/gup.c, there's no pgd huge page handling in the > follow_page_mask() code path. Hence it doesn't make sense to have > gup_fast_pgd_leaf() in gup_fast code path. > > Here remove gup_fast_pgd_leaf() and clean up the relevant codes. > > Signed-off-by: Baoquan He Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs