From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8B38C36014 for ; Tue, 1 Apr 2025 08:42:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C7280280002; Tue, 1 Apr 2025 04:42:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BFB7C280001; Tue, 1 Apr 2025 04:42:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A74CD280002; Tue, 1 Apr 2025 04:42:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 88B94280001 for ; Tue, 1 Apr 2025 04:42:17 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 53ED1141E6E for ; Tue, 1 Apr 2025 08:42:18 +0000 (UTC) X-FDA: 83284833156.29.A2E8C51 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by imf23.hostedemail.com (Postfix) with ESMTP id 3D45A140004 for ; Tue, 1 Apr 2025 08:42:16 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b="bzTr43/H"; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf23.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743496936; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T/o5XWa4l5gUPNjznvgYeaHUgYy/EIx7woUA0k2Kxd4=; b=Y0xnulOD1JsHL01lDznVBh1ApaR6zS3ayKR8fCN1qg8IdkA0PEjwTlfYao5uomN/X0Q8Fl sPgP3DRtiHiEnsrRyagjUwZgCfCBfFruSZgRjCinlYyzgPJkCqFkUde9nC58yUVu4xK1Vo u3A/HPcGE5kuvvm1rjHPNMFQ3ySD3zM= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b="bzTr43/H"; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf23.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743496936; a=rsa-sha256; cv=none; b=PDpfKyngXbsKS8B55ABxqK/ilCco1fTWytWjO8tP+Zs/Y8VWAfc62BRyedvnKBYypPdCRO v1+HEbw8htwjKswLl/Ue9sERaRKFychAR0yWKsWhCaW4aFCmizVSbloTDOpwlFGHBrDXAL NJHYhLGC5LY7SdFYndMAMAeZYfF8CoU= Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-5e614da8615so5759694a12.1 for ; Tue, 01 Apr 2025 01:42:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1743496934; x=1744101734; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=T/o5XWa4l5gUPNjznvgYeaHUgYy/EIx7woUA0k2Kxd4=; b=bzTr43/HgUwIAFE5YmleIoVMYfWaBSqC7Q5AIZSQgsUZ8ALZ53SUgswzfffUmhTEdF CaNpDKWTXLbZ3wuSmHjH+5uD5GyHE/hVTrn1XWw12vt4yjMPYjVmw7JQ7kIojMu57kTr w8Cpib5kxcFyK1nWzW+pEk8zAchrQme1pxv48hPWRVisgpWVDEJ0DjeRC3F/H7Uu8b79 ybb7fuSM28fOp8j7h0DWhtk0CZ42kzFKk2OQ9Ato81CDhgI1BqW8Fwt5Hq36SGKqlSI/ EUvtgSZ/k4MLs8eEHKtGkVLuaJx67q0At+m8mzo+XvufG3FfxhryEXnCtVPZxcMAVOVd vRZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743496934; x=1744101734; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T/o5XWa4l5gUPNjznvgYeaHUgYy/EIx7woUA0k2Kxd4=; b=Cc/NRG2IDb4KnS2tP32kIjKTMOUIOJm+G6qwAQgd1+l/YLT2QMOgOhPTvjmmJdh9dz 4d+SaPfIvCKBaQG7H4gYLrikkiabN6HaPdfS7tWKP5FQvWoJkYwk9WbDs1i9TH1Aj0PZ DJUTbuXkQc28pATTObgzHDG+YCce5x4Rb2+2qXMcx/vulMTg7ZjT7u0zqhGCsHyT7Oc8 bqLPnTqGft3D1rXH19QN3RcSUNWoK+6kTAfCH5iEqAjGOHfxLOc5F7SkZd0xEB6EWT+O Abk5z+gw4zN/mbSqHFDxrpXuvoxx9CVN5MURDZ67aMwsgDrffCF1Q05H9vYUqhRprn1E NCwQ== X-Forwarded-Encrypted: i=1; AJvYcCV8TIB+wSRNbKdG+qJav9zHw8sWESyq2nwDiYLkAs+vxpgdgFMrXex+lVDlPzqtqBXb0dq3kTFqSw==@kvack.org X-Gm-Message-State: AOJu0YxyacCijiWQlzQcQFzol7BfL1WCVXoDeFyQj14VhYzhbi/G+jIl k1+LzpbclJCucA/rvAvDUmEkhfwpGi9fasGY3du0KpoPmXGO+7++bShnvfvuTMU= X-Gm-Gg: ASbGncvRBi4xcLBIkOFV8puDUn6w7r6kYZVx/fmEqCprxrWcjc6UyBgWR1WW5f5J5ma WBlbCBLPG3dSSg4Su5CE23x9/m3wciDBbdI9a3zI35Dt+n181kKbS7rh8gJLCd9IrVf8eVi0s81 bx7wBTynyNYCx0L/sWq8gR3fVdkyOJRlWwbie0NOvO+12PYqKLPQ1EbkW/ODoS4n/ydWLJUgPoO vxGSpMiD65koAnNkJVZSLpFF5rc88VGy6q4u70CRf+JMhJNvpr+IfrepHaBrRmzL1YeHvYT2LWq Q3l/edaGDiTQvsUWCxU+Pt4TQhdxmkwWAHaSQyYKiG6Wtw== X-Google-Smtp-Source: AGHT+IE4hKhywGcQobvbzoNbXf8Bq4/ZS+8/xXWXD5AUQUwrxFzCZds5ecBjzn/9IMrH/IQA23YLQg== X-Received: by 2002:a05:6402:84f:b0:5e7:87ea:b18c with SMTP id 4fb4d7f45d1cf-5edf6033e1amr9834137a12.15.1743496934489; Tue, 01 Apr 2025 01:42:14 -0700 (PDT) Received: from localhost ([193.86.92.181]) by smtp.gmail.com with UTF8SMTPSA id 4fb4d7f45d1cf-5edc16d5077sm6779970a12.32.2025.04.01.01.42.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Apr 2025 01:42:14 -0700 (PDT) Date: Tue, 1 Apr 2025 10:42:13 +0200 From: Michal Hocko To: Alexei Starovoitov Cc: Linus Torvalds , bpf@vger.kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@kernel.org, akpm@linux-foundation.org, peterz@infradead.org, vbabka@suse.cz, bigeasy@linutronix.de, rostedt@goodmis.org, shakeel.butt@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/page_alloc: Fix try_alloc_pages Message-ID: References: <20250401032336.39657-1-alexei.starovoitov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250401032336.39657-1-alexei.starovoitov@gmail.com> X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 3D45A140004 X-Stat-Signature: nn3wfjeceutbxfs3o1es9ur4hke3wob9 X-Rspam-User: X-HE-Tag: 1743496936-710108 X-HE-Meta: U2FsdGVkX1/dLHpnlY7KUls1U9xpg/Pz/Ndv4LnUTLzyu6Kjp2ye3bvSpCUNTMw1+nuqjNvEm/Y9mz/vyJJok2aTO/vvDufDLoi4miu0Qj35YOHnA/pPd5FFkJIAPcyd+CFUaQOIw5r5G6JTKN+3gpT0Ti8iEdQ8/PIelO2zjubMI7zAEJ56C+LS46zr9FNVzjQbCjgCbK76eFT+vgVHgVwKhAJhWfPyDNSzRJgh7GNODYGUKEzS6xAnan1M+UYZPOKJWhilOaREgMp/C7Ra8nnf+9NBac14iNmzMmVGLWvsYEF0918iByQYECHoVaMXphyiLxkZ3Lntk8bn9S6lVEHlBPo1lzBhJBEj96eTPpnAcDW/t5CwlelL7fgPTQm11A1vY72iBAZFVEU77pcNov/U9tC9cVoQ4YS0UpLqS/MBjmt9V12bJi2AbOXMvCYJiHytDThDrxascNcJUoZ4318RaFkIT53PAPuNw6LV9I7bIZ7Sc79g1jk8Y43M/sjzo/qg9qbXbwnLY+s8mn09J+SzHN3qniRojzezSTAZJqRLHLYK+27XMI2nM8vRWcba9r6ll4iLNtHzSezt9kj7xteTomVvlMlLfTbddABeRkdxPZu3Pc+l+//LP91PeHtDhhEUYf4D0J4wjran4xpg1qdFR98ygZ20KeRzb8rkp5pSTbwwCGuPpeNQpa2FQbOnt2pwXs/JAu9Z0YM0JgpC6TF60ZLvszIKf8hyEhLhBgDB68tJyrNREvM0j0KQH2hqafXtJ1LD1mqrpvXMrbRB5cGtvsesj37wdH5v4omHngK87OHF/R9FTrClFUlJcFurzYNAYjruWu60oKI4XBSFLpr9QALlEmnNiWfWCEj0W5smzUl1qIYa3yXPO2fEj9LwHcWqzRquzIKrYbVTSa4vu/cBy0q12GutTe9r2dXiSfle8LD0O0uJkonlGt873JRHMuASJPR6M/vezUgxamG guNY389O zWemzIwV4+neveXqCrYyrXXlUtcinqM7rAl7zn3ez/+aYx1JaYGEE5dSZF0skzCi08wKeTmi5lf2WccIjadVGM+FPJHzki0sX53Ff7PfFI9FQ8Wwwtav2mg/lb7dPJRlziTfDMBGzPPfCJknjEqhFPOs5W6JN3JByw6F45m/A5FtwYQBIRkFBAIHLaPEOTGO86NWm4iWJjHiNbhTjMb6u/eFNz7dxvSBytNO2Iu8HHsh/bDlCbFAAlZO+sxquhska6prQVspcHLnHHDeylGvvPpOuDJg5YkDS7Zzwq84q2w4BSGsaOrkU0cSMd6xOwItoDHR2Goz+GaXy0wUBCRDU/3sT8sDb/dAYLWwenFqfFEhK0CK265znmVPnN7r7Hwsbw2MDJJN+lImLyRQSaF3jrhKM81/3qXJu6xTZURT8bZ+WzU8Djlfx96qHrC5dOdUBJfctIkemqhJGGgDMf+LUCkDDqWZaMpGFX24vglRE7YbsKyNrO3sxOTKKd3QSDGAkU7/pKzVQ/I1AuEk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 31-03-25 20:23:36, Alexei Starovoitov wrote: > From: Alexei Starovoitov > > Fix an obvious bug. try_alloc_pages() should set_page_refcounted. > > Fixes: 97769a53f117 ("mm, bpf: Introduce try_alloc_pages() for opportunistic page allocation") > Signed-off-by: Alexei Starovoitov Acked-by: Michal Hocko > --- > > As soon as I fast forwarded and rerun the tests the bug was > seen immediately. > I'm completely baffled how I managed to lose this hunk. > I'm pretty sure I manually tested various code paths of > trylock logic with CONFIG_DEBUG_VM=y. > Pure incompetence :( I believe Vlastimil is right. This seems to be an unfortunate mismatch in the final tree when this got merged. -- Michal Hocko SUSE Labs