From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B456FC36008 for ; Tue, 1 Apr 2025 07:20:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC0F9280003; Tue, 1 Apr 2025 03:20:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C6FBC280001; Tue, 1 Apr 2025 03:20:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5FF9280003; Tue, 1 Apr 2025 03:20:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 97345280001 for ; Tue, 1 Apr 2025 03:20:51 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C641F1616A5 for ; Tue, 1 Apr 2025 07:20:51 +0000 (UTC) X-FDA: 83284627902.24.4F8553B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id 25D51100007 for ; Tue, 1 Apr 2025 07:20:49 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="SNVF0/nR"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of mingo@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mingo@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743492050; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DD3lUzRFe+0UQZPnhji6IX2o+/779gVmIYUgypITe7Y=; b=XFr9yEYE9hHdOIek/xbxxqp3vN/JaHaylRcjaaCRtbR9PqDF0xw99CHr26Rde/6tC7SuHc mTKIGCc1QBlHU9F0uV1HQEYSlDulErEQLmmLSaq0ECKp7HaKVmCwazMF98samkfqMnEGsL nOBer4RQxfoCg08hXczP26ozWg5SCSA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="SNVF0/nR"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of mingo@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mingo@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743492050; a=rsa-sha256; cv=none; b=7SC2nbJitvgsdlE7PidHaES6SLlh9RjeGGm4Msjouu6oo76DD6TVr4vSXyqFXFnC4byof2 y2VHu+qtiEbrXkStDgceQI5f/RkX56Sjb/qmyB+rJRrpVdSesifg+27JQVIfiURRFzuMa2 BVXCQ8wyc+5pYSFFOa0jBVMc/LGFT20= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 32DD55C5D16; Tue, 1 Apr 2025 07:18:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 45CB0C4CEE8; Tue, 1 Apr 2025 07:20:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743492048; bh=IpyimrQSSkylOuSmeYUIWWedL2EoQBr1IdLla/29YXY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SNVF0/nR2Eu11Yclfxv7CXnOEjiJl/zMyaafDxicEvqatNGhTQ3hI8zpnUZED+ZKg XstFSg/djjGLhrTjR6Kg/H+J8LmCmfINcLjNfFAIUq5R24L4PLWmF2HpKd49YyBEIq hAtleC9yZUnm/rSpFjiRCnj8Fhrt4eYqzJdAXndFCLAisvPkv7GT2LTKdl+07NK6CK PhSINlkp6/EomxQbkksZOGfVeJpwAVMRdJTsniNDgbW4c90MYFzwDiEYOQdBkc7Hed //pahRHFS3ydlD3MvNbEIQPLOzESR3Pq2F+AZyJo2woKzVTzXT2zj9jZK71XZDCWAV jGdHs4QOCJR/Q== Date: Tue, 1 Apr 2025 09:20:44 +0200 From: Ingo Molnar To: Baoquan He Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yanjun.zhu@linux.dev, x86@kernel.org Subject: Re: [PATCH v2 6/7] x86/mm: remove p4d_leaf definition Message-ID: References: <20250331081327.256412-1-bhe@redhat.com> <20250331081327.256412-7-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 25D51100007 X-Stat-Signature: 4b1dtee77xg6abbpicytnay87oawx8jt X-Rspam-User: X-HE-Tag: 1743492049-802195 X-HE-Meta: U2FsdGVkX19eSMCrVhb3Xt0DzXb8EnNHwFSW1qh5U9Q7qmz+rh8DyWVQl5UN+ysgnRTL3wbEP4PuQYGvFnEZn0gRxF4Nz40NbuJHNgSJm9oG5rCQNmR2D3etmf0Qlyh9wpUmqfekrrkzRt3m9atWtyk0rB4lBbqyPcoSQI9vWzNcXWRXhymyvW+S8rI6TejhZ10lJCs33DPGeXIMJvpobG8KXuLQPvetc6yJ4j9GMOKMJVWAp4sr97YrkoPOBbAL0wNs/V86pVNDNWOrp2EqbmBm7L+EztXwa+petMUbI1TLY2gF0L1j1MgB0OCeTAzis81dcGliA5+bQnGEzCWTG2xqW49YmVp3UnfWzC6l4v2bnYYTesqeG79/rdit2E6tD/SxsMS1PcggWUPJ8IdhfpUXmV9k2qbV0DonXm4t7PImW0B2kNeYNZIN+uChZjsVKAcM2MXU2OmSncfaZsRDTDyi6d40iLcse8vUHANIoJAx44SX495kuw3nk3XJ2qBnEJJptB/qUmzTXwZpoR2e2R6t7fHVcsqoBO6cJ1ii68Fw8Gb9H4dRtMwICFMIEhShsqtSiFtsJtV6jb5wpLssFQljl+3YsMcB5o6yl4t7AlPlWHvIQapka8qiiQmMWNSFqvj14N3tN+h2+WqoNyUX/iL4LmuUUZhr6DnmidgoVjmsj3aiPr99qqTdtwJFpIg3VmGkgTo+NS8PHgNAY4GJmdqYxflsiNXvG5/wV2PWtr1bsTrkN8w4pHFRi4LUASU3PfNluhHuRzMyNRHzJ4UH27xdqV9gicO2gIYMZdnnudHJCHe49MqL+Nd72amAOm2DFLM9h3fFhiOZPRC5SxHy4OA2j5Okj+tAhMbSJTPFzpW48iq5fPnkZelq/THcNfjk+ZAc3/Cr45ovImy4G/FKs4JjQvOVrJyf5GQFx2cmuUmH1XsWGmtNFl49cGW0FVSf5bBm6qpmblEKrY9OvP7 mizJqfMB 0NyOqQeMuscv3kVcVM7pVBZu0FTJcgT+xeGJ5VDJggU98Wp939oFgzX/JVwaSPQj1YmOnzWzEgTMLRslYLvQd2szCI0cNAhdWBIlcvPfIhG3V/bP+Tz6IFlHI9wyRzasBtHwPfQJrmOYEhaa8fORWpzm4YDtt1ogzzW83dp8ZmQ/6qoOToVJ4sb1DXYEtx8qqOLux2L+HH3GTNgKxxoV/alpDYNoGIRu6d19cxVxWyGQipYr7RvlBtxOcQ41QeUc1jphRxpGMJc/vb7vROS7Y0+06TA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: * Baoquan He wrote: > > So the above comment should have said '256 TB' pages, unless > > there's some naming weirdness I missed. > > Hmm, there could be misunderstanding here. In 5-level paging, PGD is > the highest level, P4D is the next level of PGD. You may have > reversed their order. Erm, yes indeed I flipped those two, so the correct table should be: - level 0: 4K pages - level 1: 512x 4K = 2MB 'large' pages - level 2: 512x 2MB = 1GB 'huge' pages - level 3: 512x 1GB = 512GB 'P4D' pages - level 4: 512x 512GB = 256TB 'PGD' pages I'm wondering whether 512GB pages will be called 'terapages'. ;-) Thanks, Ingo