From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDD82C28B20 for ; Fri, 28 Mar 2025 22:53:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A48C128016B; Fri, 28 Mar 2025 18:53:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CFFF280165; Fri, 28 Mar 2025 18:53:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8712528016B; Fri, 28 Mar 2025 18:53:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5FDB0280165 for ; Fri, 28 Mar 2025 18:53:34 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 483BB1208B2 for ; Fri, 28 Mar 2025 22:53:34 +0000 (UTC) X-FDA: 83272463148.29.7316D51 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf19.hostedemail.com (Postfix) with ESMTP id AD56E1A0005 for ; Fri, 28 Mar 2025 22:53:32 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=oGyNjFrs; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743202412; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G08r7pI321BN2IijZmop3LLUTfVfqmxK1ZrFwkfJ6M4=; b=EnuLf/cEmn4r6SnXpSIWWGVD0mfiIxsOPDjQe0gfiTc1NT0yKzTBCrmBymbtXzmderJIps koqyhXKa83EGWis94b8zy0yGG10wwf2CitO3keFu/f0bC3VDJPk5Bf8IWC6xqpglW/6pX4 mAfE3kzlB+LXW/BmUYDBgyvn8QM+LvY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743202412; a=rsa-sha256; cv=none; b=CEUpg4zRyKyhbfSmHRS2YM/vfIPJmueiR7rLlQ2n0wkogmiug8BpsJA1SlQ9tnn2th9vmP QU3yhriCX3deqjxQVPetdnMtK98cbZh89xd4YkMll/Cy2h/Lc6fEeL8gDqbF8X+Rn6ZLGg dk7Ke0OuBBbXnWn3d67FIj+d+Nm8Iyg= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=oGyNjFrs; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=rppt@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 09B1843616; Fri, 28 Mar 2025 22:53:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2604C4CEE4; Fri, 28 Mar 2025 22:53:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743202411; bh=X8QzRMcFsniUFRx5vA7MHEqQC/yTTdlJQdKOdbyOdCg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oGyNjFrsB84ZD2gSZSoDKhui0JmIK/RMefONuzx6vRZDoAXKClqQ8TWFqrqfecofS kL1GFnZk6s0cNy3nP/etxlUOrkZousXfaWLtxsZUd9Ky3zRHfXOkxGHIsGffdsehIV 8HcUnkAhXxaPDlduhMDsLRkh2y8FfUXo2QcxmEB+sw7RzwujnrKxx3itYVyoO80wXu UZthIA3EpRHjHqn3NdKK5uK4RITBpuDVCDt0oYqOrvFD5qeWLEwkwkwk1lzeCeJL9K Ob46hbj6s9Wt2FyqUME251vPI20EViHGEXPFwLsfvs3R728YUanJk2B85OcbRW1ihp AW8/fn5c7x01Q== Date: Sat, 29 Mar 2025 01:53:22 +0300 From: Mike Rapoport To: Yuquan Wang Cc: Jonathan.Cameron@huawei.com, dan.j.williams@intel.com, rafael@kernel.org, lenb@kernel.org, akpm@linux-foundation.org, alison.schofield@intel.com, rrichter@amd.com, bfaccini@nvidia.com, haibo1.xu@intel.com, david@redhat.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, chenbaozi@phytium.com.cn Subject: Re: [PATCH v2] mm: numa_memblks: introduce numa_add_reserved_memblk Message-ID: References: <20250328092132.2695299-1-wangyuquan1236@phytium.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250328092132.2695299-1-wangyuquan1236@phytium.com.cn> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: AD56E1A0005 X-Stat-Signature: prnsimqgcf5k1x4rmu4ig5pjsnui9o8o X-Rspam-User: X-HE-Tag: 1743202412-89716 X-HE-Meta: U2FsdGVkX18ljMANa0PXBOIbNQJ/AidwL3vDU1lczYQq4YdNB6v5GSAtvhfDmS6+c11MOYAMzWySB95siSdwzX17g4UrT1u/i+0s232ifJz1Kjqr/PxI2zAr5YLQ8L66hdyL+pS/4rSeNyXHc14ZeRq5AW3/lRFbsF66wF8hBYtEjU/v9QLf+r+QWNp5PoPSo8h9AmqcCn80twzQ0BZkA/xYSXRogCqS4Hu0lil4ifrwbNUFz+QPvOYTT8Se0ae4ePVV6tc8dIchCHf0fjeDOBBqtVA2Ah9uUX4EuKDfqQlig713OUMVkQKc6dWoZHmjbshiUo5qb2sdjK5NsMfc43aVD7s1QrGUM2mXd3OgjVSC6G7FR4YDDDiG7xlqExRsu8G6ldIXGJ/QeCC+//F7aAhVudfA+4TO7ebxFDb5ahTb8whs2efzimSVWzBtBTqrf4PUQU+HCaxZp5+sf1/1D5xHRPzujKF/dWm9hOBteK9N/NxW2PjSOA9d8FoPydjVmoRwnCRiFCN+eiVmpWQ44OC6cgxUAOV4DOb/vbMSX0y5jF1LDpnqVLadym03g2hiFR7cTRWwj3LpUlCW2sAxgqOcIcpIWDxj4LuG5KpW+LgiZEwUGpF83RDP1zDY4O028PDO05T0sv8OI4mJ6B4IfD3VlM93H0UFg9CxFKRBFpicYAlbBd/tHXdNY+e6eROjHfzFXFLJ0TEF6woJkIL8FtqIVu/5SxiK28Ng7KkG7h2It3jVFzO45qD4CkpELJMBuuBY8xL+jSpem52A2PgaB/a0XqrPps1oMxjc0OpkdcK9cnc9koSHoNOGoAF7saHXZbF8veJeT6A2HwITBscNf7MSxSSwZTQyNAanMTAHmslmGGelqmdcKyMz5seiguqnfZb+BpAaHM4AuNxwDEDgDxVTL259GOaYKM7tlLXHOAKluIMpQi0QudbWu8RchMgoJwo6IJ7cXUfmppEw/nm AGvPVq2T ENnQ3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 28, 2025 at 05:21:32PM +0800, Yuquan Wang wrote: > With numa_add_reserved_memblk(), kernel could add numa_memblk into > numa_reserved_meminfo directly. > > acpi_parse_cfmws() currently adds empty CFMWS ranges to numa_meminfo > with the expectation that numa_cleanup_meminfo moves them to > numa_reserved_meminfo. There is no need for that indirection when it is > known in advance that these unpopulated ranges are meant for > numa_reserved_meminfo in suppot of future hotplug / CXL provisioning. > > Signed-off-by: Yuquan Wang > --- > > Changes in v2 (Thanks to Dan): > - Use numa_add_reserved_memblk() to replace numa_add_memblk() in acpi_parse_cfmws() > - Add comments to describe the usage of numa_add_reserved_memblk() > - Provide a more explicit commit message > > drivers/acpi/numa/srat.c | 2 +- > include/linux/numa_memblks.h | 1 + > mm/numa_memblks.c | 22 ++++++++++++++++++++++ For numa_memblks Acked-by: Mike Rapoport (Microsoft) > 3 files changed, 24 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/numa/srat.c b/drivers/acpi/numa/srat.c > index 00ac0d7bb8c9..70f1a7c6b54a 100644 > --- a/drivers/acpi/numa/srat.c > +++ b/drivers/acpi/numa/srat.c > @@ -458,7 +458,7 @@ static int __init acpi_parse_cfmws(union acpi_subtable_headers *header, > return -EINVAL; > } > > - if (numa_add_memblk(node, start, end) < 0) { > + if (numa_add_reserved_memblk(node, start, end) < 0) { > /* CXL driver must handle the NUMA_NO_NODE case */ > pr_warn("ACPI NUMA: Failed to add memblk for CFMWS node %d [mem %#llx-%#llx]\n", > node, start, end); > diff --git a/include/linux/numa_memblks.h b/include/linux/numa_memblks.h > index dd85613cdd86..991076cba7c5 100644 > --- a/include/linux/numa_memblks.h > +++ b/include/linux/numa_memblks.h > @@ -22,6 +22,7 @@ struct numa_meminfo { > }; > > int __init numa_add_memblk(int nodeid, u64 start, u64 end); > +int __init numa_add_reserved_memblk(int nid, u64 start, u64 end); > void __init numa_remove_memblk_from(int idx, struct numa_meminfo *mi); > > int __init numa_cleanup_meminfo(struct numa_meminfo *mi); > diff --git a/mm/numa_memblks.c b/mm/numa_memblks.c > index ff4054f4334d..541a99c4071a 100644 > --- a/mm/numa_memblks.c > +++ b/mm/numa_memblks.c > @@ -200,6 +200,28 @@ int __init numa_add_memblk(int nid, u64 start, u64 end) > return numa_add_memblk_to(nid, start, end, &numa_meminfo); > } > > +/** > + * numa_add_reserved_memblk - Add one numa_memblk to numa_reserved_meminfo > + * @nid: NUMA node ID of the new memblk > + * @start: Start address of the new memblk > + * @end: End address of the new memblk > + * > + * Add a new memblk to the numa_reserved_meminfo. > + * > + * Usage Case: numa_cleanup_meminfo() reconciles all numa_memblk instances > + * against memblock_type information and moves any that intersect reserved > + * ranges to numa_reserved_meminfo. However, when that information is known > + * ahead of time, we use numa_add_reserved_memblk() to add the numa_memblk > + * to numa_reserved_meminfo directly. > + * > + * RETURNS: > + * 0 on success, -errno on failure. > + */ > +int __init numa_add_reserved_memblk(int nid, u64 start, u64 end) > +{ > + return numa_add_memblk_to(nid, start, end, &numa_reserved_meminfo); > +} > + > /** > * numa_cleanup_meminfo - Cleanup a numa_meminfo > * @mi: numa_meminfo to clean up > -- > 2.34.1 > > -- Sincerely yours, Mike.