From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3753C36011 for ; Fri, 28 Mar 2025 14:29:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F7E8280149; Fri, 28 Mar 2025 10:29:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A661280148; Fri, 28 Mar 2025 10:29:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7962D280149; Fri, 28 Mar 2025 10:29:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5D1A4280148 for ; Fri, 28 Mar 2025 10:29:42 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8F0D9A8D0F for ; Fri, 28 Mar 2025 14:29:44 +0000 (UTC) X-FDA: 83271193488.26.A53BE02 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf02.hostedemail.com (Postfix) with ESMTP id 854E080018 for ; Fri, 28 Mar 2025 14:29:41 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=JxOb0ekQ; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743172183; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tyt/ZAKoHxN92NT1NO7qDEoIvsrs/XPq4582kbmb4HI=; b=NF6p8MVHlNLdec2DNBZaNEwQJ5DRZL+fVJVXJHspExDDQAymiUiEOWb0lMl6ucEdfVnN0t fMRhvWZJugdgZ9kWrJRt77TNmpudiwgCUF0IQtUf+uhIwDo86c2ZHddhdjfiZmZprIl35E aq97gwbsj8prw0Jx1Ps5Sg7eoDzcyaQ= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=JxOb0ekQ; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743172183; a=rsa-sha256; cv=none; b=Oz3jjSxzT3NEBqhPh+tKd/JJ4dtRr3uxLxgQQqodxZOIGDIzxA77AxVaA+h7KVMJ2eqzd2 nmHIi4ae+bSPiQ/Ww1VtkbQXTZKL/QK6CnaimLHRtX1s+6rSjagddxgZ3sFdNdBvlYGPx/ GxbNzzpEVHDbC5jYxcosO0wZSeGDtDk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tyt/ZAKoHxN92NT1NO7qDEoIvsrs/XPq4582kbmb4HI=; b=JxOb0ekQafhxhp449WSOz+GRZu xvKVTQUQP/vQiCcUD8BcLjxaL6zSErgpG0VREOjBPkCiIczsN2RmExgUwuDJawhX1Tm9pRCq9zFoH A5hlOpaewWLSQtm8dmkZiBOcEtum38lgwPvip55zVKjMeu2guFT8KHEJ+uFHrDziL5DuoBe00jt/F 8cA02Ro37jX3N2+XZLyLYVMsrEHcl0IK9GGr+GU9M5Sea5lzDkGQEewgyxZ7Ln2dE11nGpe+n0LiR wnJAtebomUO9wO/lXV0WNWrrzpUmZiFY+vvkkZQVpQJ7RzM2swHBM90YUoz8O8hGa/FNgBg0s35KW dXT73p0A==; Received: from willy by casper.infradead.org with local (Exim 4.98.1 #2 (Red Hat Linux)) id 1tyAiE-00000003TQ9-0q61; Fri, 28 Mar 2025 14:29:34 +0000 Date: Fri, 28 Mar 2025 14:29:34 +0000 From: Matthew Wilcox To: Ye Liu Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Markus.Elfring@web.de, Ye Liu , Sidhartha Kumar , Anshuman Khandual Subject: Re: [PATCH v4] mm/page_alloc: Consolidate unlikely handling in page_expected_state Message-ID: References: <20250328014757.1212737-1-ye.liu@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250328014757.1212737-1-ye.liu@linux.dev> X-Rspamd-Queue-Id: 854E080018 X-Stat-Signature: uadxyakjzqm6qz3ok6b4dhzg5tqbimwp X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1743172181-194591 X-HE-Meta: U2FsdGVkX1+dPGDQkgMo3FTbcW+j4Q8Gc+aqCsqIxcN2/t+UrtiUFkJcTB2wm8mNrvfNHyo/NAaxz3XPCV4G2apqsWWeLRW0vSQkZ1p4E5Yxh6mrDdj2Oq6Eizhj86SbAlKKLEveCXOHqJeeCAtiXgcoouITQqCSRFU8kOBZCNRqzdY4AT1J83L5icz8nYyicq1veHdH54N9rsJQ9s9zvtAgG3VHwsU5ps/OxbVMoG6Bqr4sGmfPE1M9E/nqrfCbWEZK6YlPuT16qx4AYDS16zMmDAVsXGfZqXyuOwOQOq5y0htDoBw+pT0mKTFWNZ5H9prRWCGy8/3w/GijRe4LJ/9P4kzXl9UfuWn2tb842p2sbCB32SWsUD8EboK8maprxljnF4PDCmvuvFmNgNawiRV/+1LOSyLVypGCzTKJmigncbeZIn08S6RO6fzKofF/7r1IHnDrE830SBiCy3f9wVPcKE1b8zLtLVIyj5YskjAim4mzquRa9BBoXl32CIjOKEeuL+b4BgKBiAQ3DQO/xPIpSu86St/xb4OrfmgBFY45eof9+T56pD1sZBv+W2+vmSGPBNmRE9X+El3zSbiOEMcCpoNunpUe6T+0lBaFLkKXepK07LSw4B7yjleIqjZ9faKpmtzguS6drrVzVN7OnE+AXLDGdQn30zFbI7LTI1/DZaXoQ7xrItfBgUUqtb4RKqbOAUfmnTZnhPdfn7k/TlY/UFrgaat8Q1aGBuGnuRVePE+2z+UuIekSCtmRgtqpvbZGKtrvtBF+GCnRHTYIxnGFtlU5naxHpVAlbBE8vpdzXKGwkbvm4yCCka8LPjneFLIDlVJ0NWAXIiA/8bPFw4DApcN2Xsf6kE5MHyzKqu4JNz5Mcb88RjVwnPXP4GkdkAfqdchozTIVEzdf5ZW/k3oUKgFQPVmSGjKFWwVKM0iaGPuSqdTiH5r3VW+ycBb8haYKvRbefCxubFTgWzS z4QSWf2Z o6P9McGOCsrEg8wv9ikoL/E6QSsOSH+jYiUOMLdU0tML9KaBP5ke4z53O0Bpe9yiACayZevOzrQL6p8XDAhTwigvx1NHKuX8aI7Yxxa0n4BrT+uOqAIVXZrES5eiXK+Kq19gy1eXBqJZgVEcphX0JPOyo7vYNBMM/pvkPAl9ArgjrrA6sJZdZI8xXnIvfZaJsX0VFETXyGRNhByX7UqwiwOdtQzq+qLuTBJfkNhdM1o3QVW5i95H8rCNsGaWTAto99HPWz9oHmfq7kbcVC34m5wKQeg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 28, 2025 at 09:47:57AM +0800, Ye Liu wrote: > Consolidate the handling of unlikely conditions in the > page_expected_state() function to reduce code duplication and improve > readability. I don't think this is an equivalent transformation. Please, stop with these tweaky patches to incredibly sensitive core code. Fix a problem, or leave it alone. We are primarily short of reviewer bandwidth. You could help with that by reviewing other people's patches. Sending patches of your own just adds to other people's workload.