From: Matthew Wilcox <willy@infradead.org>
To: Ye Liu <ye.liu@linux.dev>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Markus.Elfring@web.de,
Ye Liu <liuye@kylinos.cn>,
Sidhartha Kumar <sidhartha.kumar@oracle.com>,
Anshuman Khandual <anshuman.khandual@arm.com>
Subject: Re: [PATCH v4] mm/page_alloc: Consolidate unlikely handling in page_expected_state
Date: Fri, 28 Mar 2025 14:29:34 +0000 [thread overview]
Message-ID: <Z-ayTt8o656AkGfz@casper.infradead.org> (raw)
In-Reply-To: <20250328014757.1212737-1-ye.liu@linux.dev>
On Fri, Mar 28, 2025 at 09:47:57AM +0800, Ye Liu wrote:
> Consolidate the handling of unlikely conditions in the
> page_expected_state() function to reduce code duplication and improve
> readability.
I don't think this is an equivalent transformation.
Please, stop with these tweaky patches to incredibly sensitive core code.
Fix a problem, or leave it alone. We are primarily short of reviewer
bandwidth. You could help with that by reviewing other people's patches.
Sending patches of your own just adds to other people's workload.
next prev parent reply other threads:[~2025-03-28 14:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-28 1:47 Ye Liu
2025-03-28 9:44 ` Markus Elfring
2025-03-28 14:29 ` Matthew Wilcox [this message]
2025-03-31 12:08 ` Ye Liu
2025-03-31 12:21 ` [v4] " Markus Elfring
2025-03-31 12:51 ` Ye Liu
2025-03-31 13:15 ` Markus Elfring
2025-03-31 15:53 ` Matthew Wilcox
2025-04-02 2:51 ` Ye Liu
2025-03-31 15:59 ` [PATCH v4] " Matthew Wilcox
2025-04-02 2:49 ` Ye Liu
2025-04-03 3:55 ` Vishal Moola (Oracle)
2025-04-03 5:58 ` Ye Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-ayTt8o656AkGfz@casper.infradead.org \
--to=willy@infradead.org \
--cc=Markus.Elfring@web.de \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuye@kylinos.cn \
--cc=sidhartha.kumar@oracle.com \
--cc=ye.liu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox