From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21811C28B20 for ; Fri, 28 Mar 2025 13:44:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 91A68280146; Fri, 28 Mar 2025 09:44:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C92528013E; Fri, 28 Mar 2025 09:44:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76CEE280146; Fri, 28 Mar 2025 09:44:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 56CFE28013E for ; Fri, 28 Mar 2025 09:44:08 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1488954FC1 for ; Fri, 28 Mar 2025 13:44:09 +0000 (UTC) X-FDA: 83271078618.17.CB1945D Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf28.hostedemail.com (Postfix) with ESMTP id D6D16C0013 for ; Fri, 28 Mar 2025 13:44:06 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=JuUfbvHa; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=hoyQW1R6; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ILGDQ+s5; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=tXyED2Mt; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf28.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743169447; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RPFJ48KGhj+KLQfNV2vcV9VmybTFElBFEvbSzstMz6s=; b=WA6XF1aR9sdKCd2pHGWKeMMgUJEB1luommOLhqAd9Y6WGhYZx0NHQOsmIJA/3imTef5VvL lHtqqd0akLnC8tGV0Zl6KCP1kpnXsuXRM2nCVHoseiLB3Qo1X9i6M+f9tk21TCyn7KmnaZ Xl5Exm/s3td0/MKQU8NQSgycrx4GiGo= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=JuUfbvHa; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=hoyQW1R6; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ILGDQ+s5; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=tXyED2Mt; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf28.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743169447; a=rsa-sha256; cv=none; b=RiHAUBECxQqf0hdIRdCqbESFLUAea4Z/SOyc0QaU4+RjJt/9cJebacmtj/aOJtyd/ZT8jW mBeKSc62TctnGM58Q98EkwslHrtYQ3yvKYCq9X1u1UJoOSoIkcWEkrhRYlnqwEQQs6P/Qm RfQKmqcwozxu7S4fHDYV3ukvhZFkMe8= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 773151F393; Fri, 28 Mar 2025 13:44:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743169445; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RPFJ48KGhj+KLQfNV2vcV9VmybTFElBFEvbSzstMz6s=; b=JuUfbvHaGkhkztddcu2fNDh3YaPbvIi4vT6YGx3weJMaP4SBCmYJY3KgsFz1rYcPzLn4h5 1A008jUcNrFz5GoJ6+bk/zZ/ccCJqvEpd0tpi28dhLa3vW0Vt5RAQb//X0pD83yZYpKClN Q0BlQQvN5npevLG9AacPS7rzUUZKEW0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743169445; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RPFJ48KGhj+KLQfNV2vcV9VmybTFElBFEvbSzstMz6s=; b=hoyQW1R6w57i2iyKKdRG4CSQwR0Fmb93Fi3ldKqT+jGHizxIrRNxPjtTb1qQLEAv5kPrr+ XCtvtDRSt0sSywBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743169444; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RPFJ48KGhj+KLQfNV2vcV9VmybTFElBFEvbSzstMz6s=; b=ILGDQ+s5aFSxuJgmLwSDuTaCbtCvaog1dRvtbFWfMwHFKle3P9YG9QqPYGRspDndkhah8v QapLZwkqFcLu2G+H2oRbOn0czg8Zns4OV/jgLpF7q9K3KZ+svuBx19UtHjQFh9TNc0PzwJ rQBqwo5AGk2h/lH2/NE2NEXZrVYKf10= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743169444; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RPFJ48KGhj+KLQfNV2vcV9VmybTFElBFEvbSzstMz6s=; b=tXyED2Mt41nU7CApnPuzn274TowRhNfJexvhWwixUxgCh0BcfNb1UnWgfcd/wxLHeRU9QA XwwVUuas1HdYL2AQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 20599139D4; Fri, 28 Mar 2025 13:44:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id P2kdBaSn5mexaAAAD6G6ig (envelope-from ); Fri, 28 Mar 2025 13:44:04 +0000 Date: Fri, 28 Mar 2025 14:44:02 +0100 From: Oscar Salvador To: wangchuanguo Cc: akpm@linux-foundation.org, mhiramat@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: migrate: restore the nmask after successfully allocating on the target node Message-ID: References: <20250326031218.487450-1-wangchuanguo@inspur.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250326031218.487450-1-wangchuanguo@inspur.com> X-Rspamd-Server: rspam01 X-Stat-Signature: jbd3h8gbtpppd3es1ziyr6enosakai89 X-Rspam-User: X-Rspamd-Queue-Id: D6D16C0013 X-HE-Tag: 1743169446-117308 X-HE-Meta: U2FsdGVkX18+0PmPh06X3EgOCAH4vU1M9HX/i7v98/F329gpg5Z4Oaj15/eXUnj8B2NoPFduto4gOoHcS6ya883liEwJC7i3id64D2p+C8zU0PRd8KT3OLX2DjQwGR0Y4uiWaa3V4vsR/00m7iXfRuoHyZ1lXGtk7dVD+Czb86ilM2VvM4H0kKcOd809Y0KgDvXB+MfAPM9ELWs5Fgsd2RFnQppmIlp9UtpJkVQel5MiUYwjFAIW98g9U+S9ZC6IfXad074kZPoRsHOsaPtOtDJi3nvXFpxoKoK2XsCglXbVrkiymeUuK08DAk1dKrf2IaM0PFmtzP0RFlsBxrxWlJhUkdw35/vuM8rgxMl8PGs5bxH82Fy/PnW2wr5LTptIcE/pPovOK9dJTT7szd1YO6UOP67S9hRayjSr2Dc2J54k0FEffQ5NwbvLtiHwXBhF/ys82OPGzADST8o4+IqU4QBr9NSV2sZ6bhlpH/STP4PxSn2xYIBmPgYRXdGFd1bHInM8NcaOEKaWuvwfqvQobVgmBDmIj3ai0ydpg1jrd+YuiSlWS0lLwA52CR643DMgCsEw7B+yJtSXY8Tqk72L0K7/IYk8BWmbc0B10V1MXxO3DWDpMPBxxneLBDi39uiSY0kwB8Lt0GZwPIkKDhrqSNTAc0IBrMc62SOB9JIFhu6WwISssVz7xwQsqdmE3PPPnTZ8+YMhCRMxEuaIPHzPT34VosgEBMmWxea82JDucpl0WH7OcncRR4Nx0IyjwG9Nm1b1BF4lHxJ7kv/i+HxsqhZeDqAd5YXYszWiu7iMwDf+bs7ECc2IeNGw7+5XclTe9Ru4cXe1LypncioiKeOHx9lYfmm+v1Ylsi2RuONl3JAv65CAGFHVRJ2sTK292s4eksJUVi0cwf/GOcmLA1Oh1OU/vkPtSVanVDdzcm7js0d1uQ/u6LFn0TEK3NEq/g1SQ9yaacVHql/Mz42njtJ wyeGc6i6 BImgOt1ziLAZkneVOh3O+J3dGVyJIcAaImoqF5uy4pl1VVoEU9GXj+MoSkMmRLavaY4KffDaUA1LQog7oUrydsKvvIP5hvK4p2Sn5drKJbfLDcrZvTf8jfEWy2q1XVh1dGp9YCOGZiEuFSV2Fg8tmgAceW0bVXS8PbKCrXBQbYOQu9TBFxWANrX48xBTBdSii9gGe1+AlAroxwVeIkp5+UufaUEJyCmP7MoZAExkWBjGCq97bFfo4+TJ4N/srCRuzCrF0IDqsuFbBJqGWgNSi8v6BILLVaAozxssC0q5uG4QF5I6rI5yi59WOsZtG4GYH7wBq X-Bogosity: Ham, tests=bogofilter, spamicity=0.284770, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 26, 2025 at 11:12:18AM +0800, wangchuanguo wrote: > If memory is successfully allocated on the target node and the > function directly returns without value restore for nmask, > non-first migration operations in migrate_pages() by again label > may ignore the nmask settings, thereby allowing new memory > allocations for migration on any node. > > Signed-off-by: wangchuanguo Unless I am missing something this looks reasonable, but I whonder why nobody noticed it before. It is a path that should be pretty exercised. -- Oscar Salvador SUSE Labs