From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 414B2C28B20 for ; Fri, 28 Mar 2025 13:10:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 53CB2280141; Fri, 28 Mar 2025 09:10:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4EA8528013E; Fri, 28 Mar 2025 09:10:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3668C280141; Fri, 28 Mar 2025 09:10:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1279528013E for ; Fri, 28 Mar 2025 09:10:30 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id DFAE91201CB for ; Fri, 28 Mar 2025 13:10:30 +0000 (UTC) X-FDA: 83270993820.26.BA42793 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf23.hostedemail.com (Postfix) with ESMTP id 9B7A1140007 for ; Fri, 28 Mar 2025 13:10:28 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=L5H1rfvo; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=9+ULbLGD; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=f6nHSpqB; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=JVcPqmAa; spf=pass (imf23.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743167429; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xu1rSHeQgr2TGn2wogNSIxm18y3cQEiVZTbjppWE6F4=; b=qcIpFbIofO2Yl/x+us7MfhmfvFwGO3lHsTRYFmlic6apuKIK0GNxydqpJEIOexWX4lurWz 0AcVjtaNcfNSIlsHQEa4Ez8dedJ1N7DyNa+hH98maGZMqbqUqBSYAJf9Cl1Gp/EfjVrZ2T 41Wf7rh33WzfcAKrV044H7inKiya29s= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=L5H1rfvo; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=9+ULbLGD; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=f6nHSpqB; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=JVcPqmAa; spf=pass (imf23.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743167429; a=rsa-sha256; cv=none; b=2/3Ds9u18Gm7ZqGHNepYTiDbGAoODAe1qofnOvLaxiTattPdYcy+zYB9Kcae8mo95VLyGG 3l9wo/NdzJy8+Y/FGI0t08tpNNzSnqXJ2iOJUgG1vGp439FLtYKYEV/uCcj1yvYtiJ8TF8 TpZ3wgIuhD22LkaBrjjoFrP69hVWIzI= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E28FB1F388; Fri, 28 Mar 2025 13:10:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743167427; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xu1rSHeQgr2TGn2wogNSIxm18y3cQEiVZTbjppWE6F4=; b=L5H1rfvoEM88pq1D5oWedswEYssvdloxShoiAjRCwku77+uMMut2dnFqa6sn1SjUfP5107 SFHSnXy6SCogX83wX8Acw6p3YeAVH5PYzvDa6QwAZ2Ym668fGxsrwTBG91+/WnlJkYh6Yv ME7D/N0XuYvL01iUsCUfiot2DZ5a3LQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743167427; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xu1rSHeQgr2TGn2wogNSIxm18y3cQEiVZTbjppWE6F4=; b=9+ULbLGDTBrhvM4DMbrx/SlOF+iDLs1nsgrBENy5oBc3BN9l1TCLMKSqelpONaKa6eGux5 sU5Zs+QzCa/IAqDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743167426; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xu1rSHeQgr2TGn2wogNSIxm18y3cQEiVZTbjppWE6F4=; b=f6nHSpqBO0rJMm+yJS7a+aKMJkd21PtIKTkfXGDMEPLLEqOy+ke86jXZTQD44qeurkpwpb sPlyuqjIammQ1HzLmeNIqecaNUphhWDyx80zj5L1P0zTxQIVDLmTCsycxAh9foHyKYc+LM kfrIM5dDxgknO618j/qNV4p2T4vqAFg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743167426; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xu1rSHeQgr2TGn2wogNSIxm18y3cQEiVZTbjppWE6F4=; b=JVcPqmAakRV7qR4ZkSj9JkqqhXRwiKNCP7PRHqRR2AvGsKhyLUgHavr/ciwvJW76VjVJLT QbVO8+NJ1LS/vZAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4EB7213927; Fri, 28 Mar 2025 13:10:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id o4NpEMKf5mdiXQAAD6G6ig (envelope-from ); Fri, 28 Mar 2025 13:10:26 +0000 Date: Fri, 28 Mar 2025 14:10:24 +0100 From: Oscar Salvador To: Ryan Roberts Cc: Baolin Wang , akpm@linux-foundation.org, hughd@google.com, willy@infradead.org, david@redhat.com, 21cnbao@gmail.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mm: mincore: use folio_pte_batch() to batch process large folios Message-ID: References: <7ad05bc9299de5d954fb21a2da57f46dd6ec59d0.1742960003.git.baolin.wang@linux.alibaba.com> <54886038-3707-4ea0-bd84-00a8f4a19a6a@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54886038-3707-4ea0-bd84-00a8f4a19a6a@arm.com> X-Rspamd-Action: no action X-Rspamd-Queue-Id: 9B7A1140007 X-Rspamd-Server: rspam05 X-Rspam-User: X-Stat-Signature: am3mwwdrcxfdkqa4yz1n8z38ntskf6kj X-HE-Tag: 1743167428-115711 X-HE-Meta: U2FsdGVkX1+/zimarbDUy8t7BGhI8PVsBMPY0fTgXdOJpVa5JHEz6JHqnvl+TyYORKmfZ6GwXy0PVasj1US163GQlHKmhjQzrpelff0kCElymRLf0uanysdm4d1iehk37Zy08zuScOPntOEW6s4oicpGkGpoGhvS5CXOzjGEnKACIlwfFDFNatyyhty2cX51FKVCFqCQ+HHwREefiDQGyued+2wD6YMTcUKd4eJshiiika7K65tGWTDIiHjh+b1k/zbHnvAalCSpsfrIT7LXNnqHn6rTOaRw8nfGeFgK0sIp2otNQ00K4RiiIaMxE+/1ucXVJv+JwbMth1RJBx/fNU0p4ME2bt/4H8dN/k/l7ju+sKdns/01o+rbSLIh5M5XoKsNqEWF9QPRw5eTMrLAnc1Vgytsxc/TjY3YRBhDXvbsTvDZVUMgwX5RHfpyiR5EkKRL6yg7w/vA37SywkA33BSKysEC/Ix1lauBTTfgUHfmDqPzYIavF0/ine1SA+EOvYQz2nYq7clZutHIu8q7elHS1WPLksFwXAgzmLLCzBmNTHWK7OOKXvYEtsow+1yFaCVpl4A6Lu6bq4Wo7loFvMDqutUZvpj8Ul3JGlYOCYibMJGOrNCRB8I4abbKPSD+ybdGH2kslT49604pfu0C3Po1JHHcTtEyBNhGKHHENPXZdn1Qg6KOEFG7+8rWcWDQ5frHIjAu/MVIoCVs0RsDSJ+IjxITVJlg1y5nQtCGONkxoIa/CMJSqGOUfH8Dgj1hdNuT9MCU7qaxS0BCeIHaMhhzaAF/5zp/MxHMXazvZ/vg+iLA0od4HMMJPbcK/aZbM1BxBennybYVd7GBEK6wiCQD9rVVduV6IPiBzbnYkYi5favurnB2CLfmpNWrsaLQCeekmgCloH+CPSsh1lRGBeiZxFDboC1c4I26DLRuJaUVFwzmvMTl1sa1yaSBFXAwMZ8sI18Zcz0Zt3XZ/Wg lBK3s1ta R9QpMxk40r2SM5DzLVYHQ2pp3HRpZgOg6BlvgqF9U/m8FmRYrqraPZgMstSD5YW5O2DuOunIWlD2waWX/kWcx7/bN8frMhGwlvMWGRHWTN91OyucslMF6Cc00yLMKSymkB3Wt4Fp9ccrsIliICCIRH9eh7TczC/+CCoAELH5qppOWq1H7yzuZkh6OdZVLIus5JfCNRkOhjHiGbufI62rjzW0dBfN7jwOq7eAzPYiRdYY6ASNoHhKPahT+B3bLfEES9Cwm4+qeR+yRxBqSUAmZ06VqJHzV0x3ale4PR6gZIdke/BdWkVpVa+RwIFzgMdfNUC/E7UxOG9pvTR4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000012, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 27, 2025 at 10:08:56AM -0400, Ryan Roberts wrote: > You could simplify to the following, I think, to avoid needing to grab the folio > and call folio_pte_batch(): > > else if (pte_present(pte)) { > int max_nr = (end - addr) / PAGE_SIZE; > step = min(pte_batch_hint(ptep, pte), max_nr); > } ... Yes, I think this makes much more sense, in the end, as you said, we do not really need what folio_pte_batch gives us here. With the API I am working on, batching will be done in there internally, so we will not have to expose this here. -- Oscar Salvador SUSE Labs