From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1FA9C36010 for ; Fri, 4 Apr 2025 12:56:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E25A6B0023; Fri, 4 Apr 2025 08:56:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 593D1280001; Fri, 4 Apr 2025 08:56:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 432F36B0025; Fri, 4 Apr 2025 08:56:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2070F6B0023 for ; Fri, 4 Apr 2025 08:56:45 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id C2C7856040 for ; Fri, 4 Apr 2025 12:56:45 +0000 (UTC) X-FDA: 83296360770.10.A63F4D9 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf17.hostedemail.com (Postfix) with ESMTP id 2E68C4000B for ; Fri, 4 Apr 2025 12:56:42 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=c78OxrVm; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=1COTDiaT; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=c78OxrVm; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=1COTDiaT; spf=pass (imf17.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743771403; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rfjqoDJYEhzm4CPjo42uGV1n+giaq0nT5awowVQ0jCw=; b=Ojdkj1g5I0aV2LZz1mcnWSejJJTG4k/6X3MEK8ynQPHBNAd2jmMissfwCwibH0eZyeBVVe RNwgV+zT6bn3lLswkc9Fzf7IdXK9h5d4NvIkj6uLNqiOydlj0xz4GuBpotp7B1cjCFq0Sg KbxKuvk6FsKp1JW4eXgG6lLAN+KR0qU= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=c78OxrVm; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=1COTDiaT; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=c78OxrVm; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=1COTDiaT; spf=pass (imf17.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743771403; a=rsa-sha256; cv=none; b=8kOx6KaG/eR/I1K+SKJdKplh1fPAnq7rJ/n3yyGO3njCrCEo5yXRO/IU/oZ1s1euqDByUv E3WbXDHTQAtdfH04mScTlHEUZoShb5cpPQCgn4Dl+MSjcb0XoD7llrY06bKFB7jPmBs2J9 wM0nR0y8jbjODCnHLsHe7Ij2YEHAoDE= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7129021170; Fri, 4 Apr 2025 12:56:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743771401; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rfjqoDJYEhzm4CPjo42uGV1n+giaq0nT5awowVQ0jCw=; b=c78OxrVmM97t75aXmSi7XxJ3/JpLsoMeLVYvVRKKIimKsSxRWgmAUeDgF1MFy+W8mnlX7w IrTZmVfZXR3psPpWqiPXd7irA9BR2CZzmwE/z9koVwBMguE2KiexQtuhYyftG7OEqc4BCA PBohFWsdwCpi9SJaaxS5fgMxYtBS/+A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743771401; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rfjqoDJYEhzm4CPjo42uGV1n+giaq0nT5awowVQ0jCw=; b=1COTDiaTm82sP/n/IzZppWjN6cY7t9LrJ84SeWFxsYLyAwqqYwxkprMvqMW+wm/oGZnpVo WYhbp140iTfgDdCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743771401; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rfjqoDJYEhzm4CPjo42uGV1n+giaq0nT5awowVQ0jCw=; b=c78OxrVmM97t75aXmSi7XxJ3/JpLsoMeLVYvVRKKIimKsSxRWgmAUeDgF1MFy+W8mnlX7w IrTZmVfZXR3psPpWqiPXd7irA9BR2CZzmwE/z9koVwBMguE2KiexQtuhYyftG7OEqc4BCA PBohFWsdwCpi9SJaaxS5fgMxYtBS/+A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743771401; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rfjqoDJYEhzm4CPjo42uGV1n+giaq0nT5awowVQ0jCw=; b=1COTDiaTm82sP/n/IzZppWjN6cY7t9LrJ84SeWFxsYLyAwqqYwxkprMvqMW+wm/oGZnpVo WYhbp140iTfgDdCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8780F13691; Fri, 4 Apr 2025 12:56:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id R0r2HQjX72cIUgAAD6G6ig (envelope-from ); Fri, 04 Apr 2025 12:56:40 +0000 Date: Fri, 4 Apr 2025 14:56:34 +0200 From: Oscar Salvador To: David Hildenbrand Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka , Hyeonggon Yoo <42.hyeyoo@gmail.com>, mkoutny@suse.com, Dan Williams , Jonathan Cameron Subject: Re: [PATCH 1/2] mm,memory_hotplug: Implement numa node notifier Message-ID: References: <20250401092716.537512-1-osalvador@suse.de> <20250401092716.537512-2-osalvador@suse.de> <9d5567ee-8c48-4fbd-97fd-d13f28325621@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9d5567ee-8c48-4fbd-97fd-d13f28325621@redhat.com> X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 2E68C4000B X-Stat-Signature: dx3hs4tkrefbs3psj69s3y3mb7k8a1g7 X-HE-Tag: 1743771402-566869 X-HE-Meta: U2FsdGVkX1+lNN2kKg2+lQu57a+UAGLM6FddZr+wH2zLGnNGQQtqTRK+hBzxy7EFgvLnp0aSYsJAJMG50yhJfTGDHqDtMxWP4AFDIi55/6tolKnVO62bkjbvtnu2ztEj6h4GdHKUrLWj5HShEEjKy9kkXtnF5RGAw1PeImGpRrVPIbB329U/Hk4vTc8SNavGzQb0CSPJYL8guSMzNiRqPzm/O1B9bcapdbVwaQ5OLSwb/oOuC++0mGL1z8TojWAIrGbW2lJC7liMYUQFdnfYYznMvcc+m7AZEDRNEtBlytw9W8jx8Q+sV7eqS5c8ywnwikG8a0pO3QBYhhNGdroHsFD9B1I8SppwKD936dVxmYPMV+KHa17HpcS4Yr8ontjRo+oicvi1cFpV4l23BiFSYLRJ4HU5SyJmucpkxKMoD6cbcKnGr3NRjhryvJTNAgOdBWOcmsfi7uVKdgPFm1WEDGiUkrKLb+aR1dI1QwliItFt7HkEYck59luUvJeJY/Sb404gDA554salNIwtApW/Iv7F2bjA19eacv9SP64zuzvnpqM5vXB7WBuQihJlnFy1w8L92i4r8fi+/ZR9MqO8xLYM0gScdsop8f5aKS6ejFcJHf0aFvJPo8zfQ//hpkr8HQcP5zsfWqD5Fp5fkvnaD0evLoPhdqEjhiuGU4CMaDw28wpIyddXBqgkGAaidHtUlOashn71Dh5rJUdDJmBjt1GcTlgrBxK9QyQQcvTT0ZcbYoCmYGdVLQTl5TZSPHlIg5c7jHxo/CgQfYw7I8MgLE4MBvmdMVQcOcj9yp4SA9XznwIly/YwCgWrvLSbuDVOhSnlCffupoWRcbUTDEORDXCKOjuv+5D8EnkjgA9l9l/s5iZt15fXadgccLRYsrfSzzJWUtuHuyFX035KhyN1qhby+u3S81feVbE5FMM6T+Ez5CZ39FKSmK0fw0snWhYpciMx+RR4SwV/7nGnIzp yGKR3RiB heUflgjF3j5BaOIt5XHAuq6ZE6ncv1sDm5cYtDae+NoQpgg3sUPYsXaJFwxUBAkoAEM6ZcYCV/HcUi2ZEg5UxtzPi8ltfR7tZXLr+5/3SGlNBWgIqAPNPhWpuwYMOBkcaKSmlPH6hgg2Y5LpSFKm5VKQekXMbsNLO81eTMe7VE0VAF42E3sPaVw7KM8jxHC6aymzG5eZXEjC4nI1MJg+dR0/ot0yfIzwm7e1OukhjN51AQlvzkYyRWnKe3IdF2NhQyslXD4bmAMWbzE8PgAroKzYdRMMhQJf/mQwY61UHh41iuo1My34hdhmUmEVOWwVroEQ63LeDzQV/p0JyhyzWOK02r5l1bTTi41oc2YpQHEg2uC+R7duic3wTRzzSKBk05IMd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 04, 2025 at 12:09:39PM +0200, David Hildenbrand wrote: > Assuming we can remove the _normal stuff and we can do what we do in patch > #2 here already ... meaning we unconditionally store the nid in the MEM > notifier ... > > What about extending the existing memory notifier instead? > > That is, we add > > MEM_NODE_BECOMING_MEM_AWARE ... and trigger it using the same notifier > chain. We only have to make sure these new events will be properly filtered > out (IIRC, for most we do that already). > > Of course, the range will not apply to these events, but the nid would apply > to all. But that would defeat the purpose of having a diferent notifier for those only interested in node changes, which is not having to bother at all with unrelated notifications. Yes, the handling would be simpler than it is now, but honestly I still see value in having them both decoupled from eacher other, I think it is cleaner and expresses in a more clear way the change of what the consumer is interested in get notified for. Unless there is a strong objection, I would pursue that path, getting rid of the _normal stuff for slub along the way. -- Oscar Salvador SUSE Labs