From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6991FC3600B for ; Thu, 27 Mar 2025 13:05:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE08E2800EC; Thu, 27 Mar 2025 09:05:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D8FBC280002; Thu, 27 Mar 2025 09:05:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2F5D2800EC; Thu, 27 Mar 2025 09:05:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A2616280002 for ; Thu, 27 Mar 2025 09:05:55 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 41CDFC0DC2 for ; Thu, 27 Mar 2025 13:05:56 +0000 (UTC) X-FDA: 83267353512.29.E6D20F8 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf11.hostedemail.com (Postfix) with ESMTP id AFA524001B for ; Thu, 27 Mar 2025 13:05:53 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KjXXkeKC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743080753; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JGH+RDQqvizTR7M2TT7xmX5Ot4Go2YXyV6Szdxe1HRI=; b=JWyC2xO70aQCEybelQsLacahq+IeQOphpdI8H07j4lECznwjYJYqyB2U/5JYznP/jdiMG8 G1PQzQoCG3G0M58FBXGo8GLfdL1w21iOCZTznl4w+xPNe3CrKM1KgqhRRZq7TQV4w77kpz mBP2ztAYvP9LNTNg5gkiKNerHgGZLK8= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=KjXXkeKC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743080753; a=rsa-sha256; cv=none; b=ORNPdmN+kcJfkcNyz0Pp0IfPTWPrdNk24UWQ8N5h3vUTWLgeSTcnncMvCzV7ZL7L1ZKDv+ gHa9if7r7yZiIcJs3apeEjyi22fQzMeYpKF3EIuA/UedXfhSqduds6km5Btd6p3zcyfeDa R1b41k5bQeEyMHt4u9cLZ+FTF+oXhLg= Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-549946c5346so959217e87.2 for ; Thu, 27 Mar 2025 06:05:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743080752; x=1743685552; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=JGH+RDQqvizTR7M2TT7xmX5Ot4Go2YXyV6Szdxe1HRI=; b=KjXXkeKCUcwkPvCncwTMxcpQFNjpsgO7oYvC78WUYh7nmS1mPtj5C4lZNrO6spZwV3 GW9stIMzBJqTVkH8Fp0D+NxHFRvqCiWLgdacISbxd/9nQDgG5B3dIDY4QmxKJU+OjTFE CR69AuLb2/nR+skDEqEq2Gtcjegnt73/4WAvR9OjHxDUoDkjQPtGkM1HvJJPSOhc4zq3 yDjuTyTpm3ExXbGhYm7+QxV6Ib1xqeYxV+n6WflSHznjwWVwMdNiM7Q4nbUPlR1OcwB7 CBe1riUfbLRRIgGuAzHZpw8ohd+H1mgSwC5IEsu9ZMALfyJ/P3dtziLwumRkQKrBYVW2 mXLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743080752; x=1743685552; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JGH+RDQqvizTR7M2TT7xmX5Ot4Go2YXyV6Szdxe1HRI=; b=TiDKII4+ZudQLCjI9xVJpbgyaXemmcNZQhCc5yZeMRPG7ue60TrwSberqjL5EDtfit sIScsQRiFq2XjS1/5vi/Oc0a4W1Jjio1OU4PbGIYRbxTUKm04v3ZzGWcW18v18qLjU4w LV3j94TZza9ERB00cUsKCyZEgivUescMIzIoxcD0z9mzXi5OrLzpjdnaczPAxgceFARD EbVVNk9cTLxm48gy72mUDpoLVDASe2Mwory77p9X6bxe75jmITGNgo/ynHi3UTMVGOFa MINtXiJrY2wj+H7skUzlrTklEg5eMeid/7oF+ao8650cs+RCL08sZAwMbfQBt3ThrJCh T+pA== X-Forwarded-Encrypted: i=1; AJvYcCViBukl5tMDZ5l2iNZJ7Tbebx9lXHSfteJaY9Iiyof9aKDyxT9AU6Rx3UuphM+96HgnpriNKiUrqQ==@kvack.org X-Gm-Message-State: AOJu0Yy0nHsMAb8B+IZfhlrA/Omq6/0Top+LSQb4YLxUtf9ww/KZDPRz nAl5NzlzC014PPc3mW25MhOrKjYSqjvn9iAf0vRZO9aAwk+pWA9k X-Gm-Gg: ASbGncu2OEkabrIvuQouEYBFo8lQo/CUvxNSJ5szjzAVVQOS/kEgNozvgyQhoT87hlo +qUyKBbDXuUzqHpbGdvs4Rwgpck2hoK+N1Da7kF7pUzgH2pxylp77ifMlS05PQZTfylfJGKSxJO 17oR/pDX7VaIfY1CWqx4AmU4UR6UDMlefuwBYiymdvpY3MyBzzBpVxfoZLa7MqWdxYq8V5DenTx giP53dJHCOh8AOaupbu/gyWUBzoFN/u+ucW8t9axAVZQy5Dzq31qxcbvY8oxkc9NRoAosyCNCdF fD4ClgB2CZPSuVIYbiRbfuhBGGnsvSIH1xJgFx1J2MIldjuQdO5Or0q93n0wpWDOj8ddw6TzUT2 FRICWZhFAOg== X-Google-Smtp-Source: AGHT+IF1ll9cFaCAoJWAxGR51kEPmHYKRptVRMXGOLv6BMKpLV+455ArQUeHscuizCmY6sFulZkafQ== X-Received: by 2002:a05:6512:3512:b0:545:2d80:a47d with SMTP id 2adb3069b0e04-54b01263b2amr1059877e87.44.1743080751766; Thu, 27 Mar 2025 06:05:51 -0700 (PDT) Received: from pc636 (host-90-233-221-122.mobileonline.telia.com. [90.233.221.122]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54ad64689eesm2075567e87.24.2025.03.27.06.05.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Mar 2025 06:05:51 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 27 Mar 2025 14:05:48 +0100 To: Ryan Roberts Cc: Catalin Marinas , Will Deacon , Pasha Tatashin , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , David Hildenbrand , "Matthew Wilcox (Oracle)" , Mark Rutland , Anshuman Khandual , Alexandre Ghiti , Kevin Brodsky , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 07/11] mm/vmalloc: Warn on improper use of vunmap_range() Message-ID: References: <20250304150444.3788920-1-ryan.roberts@arm.com> <20250304150444.3788920-8-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250304150444.3788920-8-ryan.roberts@arm.com> X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: AFA524001B X-Stat-Signature: rzrngmhjp5pg51of13psxe9r7auyxz41 X-Rspam-User: X-HE-Tag: 1743080753-151885 X-HE-Meta: U2FsdGVkX19MAzyk+XFx0WJl0NkUQBlSHRmKzFFwQ0Uop7wBwmFTvjoxSdxj5s1SAAEyZyVd9V7m+2bdfOosy9EeEmBVBS2IQL62dEttlmoNhlCpAz83rRjWX+UwyAX5LIEhhdapMoZscTLXweJXF+XwLxJZtR1jJmGQ751zesQKdkQOw04LICHYWPFeLpucuamMYdgbU7tFfxptd5pDCLHgItyU4+1xkPhpJhiCEvEiIrQDSzyYk4X7C8ehRZDVwRXB10ImQFWohoORTcP4soq5TewTcE8SrXkk2F/mwBRTVJZTEcwsCyHyVZB7SKz7PB4+Z88lYPWA1/u8LGCT/Ns/jz7mvBaKIgX78UIhA/8kiSv+Dy+XmjTID5kVDGCyPf8hjgv30IkTz4PG7iXJIKHMwcg0x1Y8FaUOjD7cQHoa9zRGQptisA9Cpr7G2toMw4CLjbWtSPhYrR3lQkWneaknxjInTEtUJNyShOPNZ3DirEo+Ps93r8MHf2UrzTzdNR8/D5pcXGEZM5saRreQVmUmGvV+iees9emWcuVWQJDcH1aMY/DIDhKJZgkJfIO7U9ihg94VX1gSECOzYMaD/qyfWOIhfVhqhSyVYROfERENsqoFGBE5nqqdOQdY7QwEtnNsKUIXF6jaB8F3wPhH2tohT3gFWLqUnquKqIZ57uGJkAdWnmmWoHr+eR347LvsoLg0mjw0Q1RY++gCBd03spUayDsS94TVs0Tf3mFr9CoMfSRV6SNsbmqNUqwDMM6AojIF5O39BgShCZjliepsU+4fCZ8mfkjIyIj4BHuxabwEP1Gw53AaoVgrJ3rbSJcd+ogOyubVQqPdR9KPOoh/PZkkdgaiOKTJm9lWC50+bIsj1MSaWZEMJwltDjbuVZl5Aoh9iKkZi77lqb60xMio2ot5vxwevOX0ynDzrM5co8i4YqywdhSXBIYCtcuVBDGc4syKdI3CVoNup7Xy+7P 592mTL6z lRXZWqhbvsiVEtjZI5N9kDYoN8sBdGDeHtGAXthCJzPBnXtGgrNDGVw0KEz0epgHKROZBluaA7JWI4LoMVl6XXLACfnlKK0EMOvOtoeNg5g0UeC6Re1xZOu4KwOTDBBDLigp4sVgOYtmPL5eoI8ukSgF/AhVX68yz41jrK0YOXPUGXP77UW7T+SlPKkqr4NQU+xzBv3pg6KyVbaNBOu2+RODXFKuTkJI7gbBUabNLvh6jtrd4j78TSLgbKnx1AeDwdS13dxxogbYheIUhLl1N8+xWj4QqUVPshwO8gIzbcuHifEHWAYpXP/2pDQllZ2j7jcbtLcdJmB9qJdVqta5Ttaov56hnlo8/Rn35SXthWtSw//BHerYR3znWoFGEVE8jDQeTKSP93BtBWyNTP3GzjpP9r5BVc8AXqEaa2E3YQldjM8vJno0zNf2hUmHBRL7avSdAWcIZEHk7Z32+xrVrhlgfX5O75iqoiYFou0QRvFiwQbDKbdZbSq0Xgggswk+Sj3Bcfxr45SXhQmF6WE6cX4ovww== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 04, 2025 at 03:04:37PM +0000, Ryan Roberts wrote: > A call to vmalloc_huge() may cause memory blocks to be mapped at pmd or > pud level. But it is possible to subsequently call vunmap_range() on a > sub-range of the mapped memory, which partially overlaps a pmd or pud. > In this case, vmalloc unmaps the entire pmd or pud so that the > no-overlapping portion is also unmapped. Clearly that would have a bad > outcome, but it's not something that any callers do today as far as I > can tell. So I guess it's just expected that callers will not do this. > > However, it would be useful to know if this happened in future; let's > add a warning to cover the eventuality. > > Reviewed-by: Anshuman Khandual > Reviewed-by: Catalin Marinas > Signed-off-by: Ryan Roberts > --- > mm/vmalloc.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index a6e7acebe9ad..fcdf67d5177a 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -374,8 +374,10 @@ static void vunmap_pmd_range(pud_t *pud, unsigned long addr, unsigned long end, > if (cleared || pmd_bad(*pmd)) > *mask |= PGTBL_PMD_MODIFIED; > > - if (cleared) > + if (cleared) { > + WARN_ON(next - addr < PMD_SIZE); > continue; > + } > if (pmd_none_or_clear_bad(pmd)) > continue; > vunmap_pte_range(pmd, addr, next, mask); > @@ -399,8 +401,10 @@ static void vunmap_pud_range(p4d_t *p4d, unsigned long addr, unsigned long end, > if (cleared || pud_bad(*pud)) > *mask |= PGTBL_PUD_MODIFIED; > > - if (cleared) > + if (cleared) { > + WARN_ON(next - addr < PUD_SIZE); > continue; > + } > if (pud_none_or_clear_bad(pud)) > continue; > vunmap_pmd_range(pud, addr, next, mask); > -- > 2.43.0 > Reviewed-by: Uladzislau Rezki (Sony) -- Uladzislau Rezki