From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26069C3600E for ; Thu, 27 Mar 2025 10:58:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2756C2800DE; Thu, 27 Mar 2025 06:58:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 223A52800DB; Thu, 27 Mar 2025 06:58:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0ECA52800DE; Thu, 27 Mar 2025 06:58:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EB9FF2800DB for ; Thu, 27 Mar 2025 06:58:30 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DB723AA860 for ; Thu, 27 Mar 2025 10:58:30 +0000 (UTC) X-FDA: 83267032380.04.4AA9612 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf17.hostedemail.com (Postfix) with ESMTP id 9E3F84000B for ; Thu, 27 Mar 2025 10:58:28 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=LLBR0GZw; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=fHH4QlsC; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=LLBR0GZw; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=fHH4QlsC; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf17.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743073109; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=W9Pr8Ub5qgGnovkmhpFhqZcnIZM6RvFEbI3pqHcF0bA=; b=c7ADZlSw6pxidpaJG/NhvT3T7npqCYlgDfvwQoZNsKdmV8kKXfUUw6v+Bp0WHsXi1E6Rb/ gOLdsmxmFJSz1hdKdNP1FhdKGGNwSGdR1EiT/pT8IICb/ZKvBxKKVOE1/33a14L45NjtXX 9oFuSohglKrpQ2iHebaWmifdux0/0iM= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=LLBR0GZw; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=fHH4QlsC; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=LLBR0GZw; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=fHH4QlsC; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf17.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743073109; a=rsa-sha256; cv=none; b=5DezmLR57RAPWNv/Hc7G06O/Tw8ULayjnho+QukURvP5A8IxRjqtkRFzUcTtKTCXIULgNp HLaTS99MbE+1nI1SC7AW+zb+i9FBiSnMkX2AMhO1SM32H1ofaFSMTSXYJSX0qaUidg7M+V pp0gzDZK3Tq27VYTPFEu2ZpvfATIqqo= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0EB632117A; Thu, 27 Mar 2025 10:58:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743073107; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=W9Pr8Ub5qgGnovkmhpFhqZcnIZM6RvFEbI3pqHcF0bA=; b=LLBR0GZwB8B7NMSAejk6A8Kqs2rCx4zmd6fyxPreoO9RM9k3I1IOY93a11M7XmilVZnSQA t+y4c/doyMgx/ykGK19OPFL3ZSXecYIsmjQVh6hIO+5PrfRgn/0kFrGY2W3gsT/XNk3DO9 3yA8tCb9YNWoQUiQCnX3j+WFfAtHy6Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743073107; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=W9Pr8Ub5qgGnovkmhpFhqZcnIZM6RvFEbI3pqHcF0bA=; b=fHH4QlsCw3of7zmZfwftWHuJK8mrfVo6HMZE8TuL4/W3hdpvC9i40zK9Upz81Azl4Dpa4D 9e2B9cnANLalfhDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1743073107; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=W9Pr8Ub5qgGnovkmhpFhqZcnIZM6RvFEbI3pqHcF0bA=; b=LLBR0GZwB8B7NMSAejk6A8Kqs2rCx4zmd6fyxPreoO9RM9k3I1IOY93a11M7XmilVZnSQA t+y4c/doyMgx/ykGK19OPFL3ZSXecYIsmjQVh6hIO+5PrfRgn/0kFrGY2W3gsT/XNk3DO9 3yA8tCb9YNWoQUiQCnX3j+WFfAtHy6Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1743073107; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=W9Pr8Ub5qgGnovkmhpFhqZcnIZM6RvFEbI3pqHcF0bA=; b=fHH4QlsCw3of7zmZfwftWHuJK8mrfVo6HMZE8TuL4/W3hdpvC9i40zK9Upz81Azl4Dpa4D 9e2B9cnANLalfhDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2D6BA1376E; Thu, 27 Mar 2025 10:58:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id dOTLBFIv5WfTHgAAD6G6ig (envelope-from ); Thu, 27 Mar 2025 10:58:26 +0000 Date: Thu, 27 Mar 2025 11:58:20 +0100 From: Oscar Salvador To: Ye Liu Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, anshuman.khandual@arm.com, Ye Liu Subject: Re: [PATCH v3] mm/page_alloc: Simplify free_page_is_bad by removing free_page_is_bad_report Message-ID: References: <20250326012434.918844-1-ye.liu@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250326012434.918844-1-ye.liu@linux.dev> X-Rspamd-Action: no action X-Rspamd-Server: rspam01 X-Stat-Signature: a1fr1huwepcs7gjc5mw7uxb4z9bgnkzj X-Rspam-User: X-Rspamd-Queue-Id: 9E3F84000B X-HE-Tag: 1743073108-102331 X-HE-Meta: U2FsdGVkX199iL5oHlZI1P4UoUKL2gOf5xv8HwRcpK/Pvq0Y9fki1RZ4TcQw25AtXvzs28gNlDNFboF90sOD24cbgWocu08JzIY+v/8DdZeeW6qEFy5zVtvfRttVnVLNSDySWKE3ljPE07aCKCYkBoFG8FA7qP3wTNsioqWJmzFiZrPoFXtw2oD5wmOEFFFFnVYjfTE31j1RHWaA3sZOJO+eZhyjgYPXc1x8mDzG9enEqyuMA23Icd5KjxRCLHj/a9cGm5M9VCMhekL1AZTBJY2s7jFQPfBfLk4hmu42m6OhOujYyIIQZrT+FzMjftfSyIcUQwbC4ZF4RMRs4Av6kzWAAAILpyxMRTwYOhBWmfqTyIHlHFBRLcP5bCNay6aGvvn2xqZSF9H6nSb8cRb0Mmrwsok1rQLhRBQprBoXH5EYeDazEofe5RQnYSNydPzCKWX58IV37nlhszmF14vcEKdHhVQHabjeV5vK5vRsx+xdExnuergZTIw1rea7Q8sK2PAUXZoiXqvEdIiF6BAZLdsYq+dI9pGmr98HoJMfI/sowNHViqzUlywgUTeFFtxGf0dF1C2eLkRCKvoUrFcvkYXJnepOHjh3+ljkjl73kXrPpPLmgii+yT/WmRXG/Vjtw11UnxGagF/cReRbfRiNCWW4xPDw+X9Swuv9TkSeVldyq58pHMwbjWCU3bnj/yn6u0xYEmr1PdZUIU8pnPHnxxDg3/Bj+NlXB3MFpXHb8sbk4lPJTs/D+mtULCi5/a8tZBfdo16g4lMPAUYw8V4N9PJjUyutcknPfuPCCccsvpy6b3RRnnl6Z7dNjGMtRyv8k6rV01SJuJQhxO4mHv5pQS6y6MMtyf1K+5RBJJ0FHIn/ZY7rrCTRR9D87UqfVdxoLRVcJ1ywrCYd3cgmVNnJfctFz4Z6BeoYNRp+z7ZMHDBWBbrZ/2v6QwI4QNhIuBZ2lAqHTgAGRoF9k0sM1Ej ftEQ3bAP gaQesMOOJAESEwvJe4HyV+SK4NM54snmI30qpksJIWY511JyE3zhmuBo/caPl6dsBI0/hteBUKB/Q/A6TlTdmyUNJyk6MvDsSUllaHLtoZ/O/kMS29psc1/LReNy4RFJ7sdc1dPucXMpIXpcxEjOreAvYu5lbke01YIDQaA6A/gL6XN+3Nkmq0FaWhLpqALowP4JBJMwbEzoEut2EoT378WRi3QyIFyr7AgIBLChaHUp5uYfFfzy998WOaG9WqqTXYbfUO+/kl/5Hels4ffN+oV7l/N9V9kxV25hyE1Sd0d+cuZ+7ytWutalLwLAGejblOanKMflUuk6C2pXG0p0cQqG6eVLgYhy0UpbN2JaIFY8tb8wXM2xi6CTNynukwoz0TWtlaT0Usr4OB3hGew3Rf+U/RQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 26, 2025 at 09:24:34AM +0800, Ye Liu wrote: > From: Ye Liu > > Refactors the free_page_is_bad function by directly calling bad_page() > instead of using the intermediary function free_page_is_bad_report(). > The removal of free_page_is_bad_report() reduces unnecessary indirection, > making the code cleaner and easier to read. > > The functionality remains the same, as free_page_is_bad_report() was > merely a wrapper for the bad_page() call. The patch also improves > maintainability by reducing the function call depth. I would trim this down. > > Signed-off-by: Ye Liu > Reviewed-by: Anshuman Khandual Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs