From: Oscar Salvador <osalvador@suse.de>
To: Ye Liu <ye.liu@linux.dev>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, anshuman.khandual@arm.com,
Ye Liu <liuye@kylinos.cn>
Subject: Re: [PATCH v3] mm/page_alloc: Simplify free_page_is_bad by removing free_page_is_bad_report
Date: Thu, 27 Mar 2025 11:58:20 +0100 [thread overview]
Message-ID: <Z-UvTBZqGdufLfwu@localhost.localdomain> (raw)
In-Reply-To: <20250326012434.918844-1-ye.liu@linux.dev>
On Wed, Mar 26, 2025 at 09:24:34AM +0800, Ye Liu wrote:
> From: Ye Liu <liuye@kylinos.cn>
>
> Refactors the free_page_is_bad function by directly calling bad_page()
> instead of using the intermediary function free_page_is_bad_report().
> The removal of free_page_is_bad_report() reduces unnecessary indirection,
> making the code cleaner and easier to read.
>
> The functionality remains the same, as free_page_is_bad_report() was
> merely a wrapper for the bad_page() call. The patch also improves
> maintainability by reducing the function call depth.
I would trim this down.
>
> Signed-off-by: Ye Liu <liuye@kylinos.cn>
> Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
--
Oscar Salvador
SUSE Labs
prev parent reply other threads:[~2025-03-27 10:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-26 1:24 Ye Liu
2025-03-27 10:58 ` Oscar Salvador [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z-UvTBZqGdufLfwu@localhost.localdomain \
--to=osalvador@suse.de \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuye@kylinos.cn \
--cc=ye.liu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox