From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14477C36005 for ; Wed, 26 Mar 2025 00:39:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B76928004D; Tue, 25 Mar 2025 20:39:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 03F63280048; Tue, 25 Mar 2025 20:39:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E226B28004D; Tue, 25 Mar 2025 20:39:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BEC24280048 for ; Tue, 25 Mar 2025 20:39:28 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2C21F141294 for ; Wed, 26 Mar 2025 00:39:29 +0000 (UTC) X-FDA: 83261843658.21.91B598A Received: from out-189.mta1.migadu.com (out-189.mta1.migadu.com [95.215.58.189]) by imf06.hostedemail.com (Postfix) with ESMTP id 3166E180002 for ; Wed, 26 Mar 2025 00:39:26 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=tDIEaqtt; spf=pass (imf06.hostedemail.com: domain of yosry.ahmed@linux.dev designates 95.215.58.189 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742949567; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sXDsuUboUc9RfyZTHpq+3wvJeMIPLr7k4uMKT3isc6Y=; b=fupv/FmHr1xh0TWztInm5YhrcmI4k/9pCT+gj71oFd69REtts1rTiQ5DI9xNi6VlAOu9bp GkjtRiBhVLUkrpGQdCk5BPWKMuKqFfENZ4cqTik3k1FFnccpc3NrpLzV/21izgqHmV9Ftz cOZtInbS8NXScXcQTlaX20bpsiLSOpQ= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=tDIEaqtt; spf=pass (imf06.hostedemail.com: domain of yosry.ahmed@linux.dev designates 95.215.58.189 as permitted sender) smtp.mailfrom=yosry.ahmed@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742949567; a=rsa-sha256; cv=none; b=HrMqBSU9hycZFA+egkpAPQ5dohzUVayHyx7b9hw9acMbatN/VGi0v3GZvyY5+a/qu8aYoB UL8O4VMJ/TuZdsribA/is7GAbinazpvQB4PNA5CyvEMzOtlz3dApKberCU+V3z3HF+QIw3 4CEIFfpDF/eGCbB2EQRsDMtdTCwqwpw= Date: Wed, 26 Mar 2025 00:39:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1742949565; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sXDsuUboUc9RfyZTHpq+3wvJeMIPLr7k4uMKT3isc6Y=; b=tDIEaqttG3JzQ0Prbn8Kzaa3pFLWvahGEMYTw51my6eIU1nHy+XdKNx3LY1j3Dp4sRjfxG h1/la0YVQ/etrcTE2yeJjOlUi/MGrGEgMdbvyy/KmkFVjvT0XfASCPZwg1ds127GlGICbf ve72A+GgqLu4OFDzNGjwbUidzhvokxg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yosry Ahmed To: JP Kobryn Cc: Michal =?utf-8?Q?Koutn=C3=BD?= , tj@kernel.org, shakeel.butt@linux.dev, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 1/4 v3] cgroup: use separate rstat api for bpf programs Message-ID: References: <20250319222150.71813-1-inwardvessel@gmail.com> <20250319222150.71813-2-inwardvessel@gmail.com> <4akwk5uurrhqo4mb7rxijnwsgy35sotygnr5ugvp7xvwyofwn2@v6jx3qzq66ln> <11a80d4a-9776-4a43-8c61-5cc1ad4abbc7@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <11a80d4a-9776-4a43-8c61-5cc1ad4abbc7@gmail.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 3166E180002 X-Stat-Signature: tfk6a4feskh7y13uq4uddbqyq7s8hmb9 X-HE-Tag: 1742949566-413549 X-HE-Meta: U2FsdGVkX1/PeIOjEbipo+/J5aAkABQYYbHuTTRQipTaP8YvYRcvPijFl3ALNBBUjqgAbROdw0LIqiC31f7pERusoWgowN4hNsMyTarUNKrD3TR5H10+s3rNdZek+4yPbb4CrmXWwXnT7ROP0zLbORSMj24tn5Xm67YGrJOnamyWRvMe9diozspZUAS+VjCBtqPrkSUEkJcD12sz/xKD6s3vrG7j3YwlPbqr/bD+G6nAD3jZBBaWwyrtXBWZgroZdY0pajcQe7t5LPZG7BRzP7ArRmMxg/I2wjJLl/SXJJ2E+MFwgffOZd/8mvTyv8b1EujzDdEmZVfO5zk3gzyonoWQpq4pU5poGR25ZuY7GeugSypY0Lg8wlXl1osegOGabjkEd9DrF358t+c4OhyT7wyjWnz3G7gHO8LhSm/PXoa5/uT+sRcaN2Htn5r/S1cnvFNaYQkckKlpBr5FsYAla7L/5mD+XBYDR2kg4KnGdXEoaHZpNydQuLDoTwfdiFLyDKkLee5MGv+1l19qQ9hdh41MH5q1NNNbtaWJEP4U4g3+fWJlxmwLHIP6fhBPR2vNTyMTL7TX0gtAqTTQVIUpOf5xfOcE42IgMFIxBiZDMAXlM6CiV1Yej+F1AnsutecWx10S1C+5ItD2HUQ5uC45lX/RZ5OC5CUYBsIRcFw2Pm0HjS/2lbDiP6CLWLeqTfbjH4xJNWMzqeIhJ06GyEl3+/Tp2L+B260ivqQ+ISkOKY4gHEHI49OETn+74qyBpfX4lNkT7E7onVziFgACZh0gMBauLx04YsEU53gOAeCY5TkJcRgqR71xTqPu+EDUt3Ie/LYSvJmYOlj2XlvKsp8fIL5Ry+DWsUc0oGkTTm9LB1ySUpPeUM7mVrx7ts1CJseS1HF8RJRUV8yumhXHPSj97faZjM5V10Agbtlq1EC9+a7ymngx27/16J8lAiV4Sxyu7c5ozuUlH8nGUmcEMRk 4XnAtNeM gMVlDWlLtvtf0c21ctKa5SGFMHVU1A1Fmo2Fnf1T0BenZacpO0PijVjpK7MpPa/OjsMjRX/7oncUpUuw6jWSMqaEj1PvccuE6vYMUkxjR512/D19H2Sdhg7l8u4qWHDBYVbA0YWrybAB1iDPCgcBaJE1NA0lvQQpCCmOZiXAywJEtQgYOiVX3DGrtYSqZVW9mIJmrUV2EQI4FQ9mDfq3LjD+hrWmMtMGReNs+SnHrVKFQkA8f8jpzWEC+9rt7IJrtBpOALSwG123ANhmvAKWhvXMQn5lxH5Z6+LU6dZKOMJmAxPs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 25, 2025 at 11:03:26AM -0700, JP Kobryn wrote: > On 3/24/25 10:47 AM, Michal Koutný wrote: > > On Wed, Mar 19, 2025 at 03:21:47PM -0700, JP Kobryn wrote: > > > The rstat updated/flush API functions are exported as kfuncs so bpf > > > programs can make the same calls that in-kernel code can. Split these API > > > functions into separate in-kernel and bpf versions. Function signatures > > > remain unchanged. The kfuncs are named with the prefix "bpf_". This > > > non-functional change allows for future commits which will modify the > > > signature of the in-kernel API without impacting bpf call sites. The > > > implementations of the kfuncs serve as adapters to the in-kernel API. > > > > This made me look up > > https://docs.kernel.org/bpf/kfuncs.html#bpf-kfunc-lifecycle-expectations > > > > The series reworks existing kfuncs anyway, is it necessary to have the > > bpf_ versions? The semantics is changed too from base+all subsystems > > flush to only base flush (bpf_rstat_flush()). > > This patch was done based on some conversation in v2 around what to do > with the kfuncs (bottom of [0]). It's true the kfunc API deviates from > flush-specific-subsystem approach. Dropping this patch is fine by me and > I assume it would be ok with Yosry (based on comments at end of [0]), > but I'll wait and see if he has any input. Yeah I am okay with dropping this as well. > > [0] https://lore.kernel.org/all/Z8IIxUdRpqxZyIHO@google.com/