From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEDC4C35FFC for ; Tue, 25 Mar 2025 13:18:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 50BF7280034; Tue, 25 Mar 2025 09:18:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 49525280001; Tue, 25 Mar 2025 09:18:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2E7BD280034; Tue, 25 Mar 2025 09:18:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 09CA5280001 for ; Tue, 25 Mar 2025 09:18:24 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 60D211A0418 for ; Tue, 25 Mar 2025 13:18:24 +0000 (UTC) X-FDA: 83260127328.21.D345CF1 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf29.hostedemail.com (Postfix) with ESMTP id 1B0AD12000B for ; Tue, 25 Mar 2025 13:18:21 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=eMd4e5ne; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=bgXaPSJp; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=eMd4e5ne; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=bgXaPSJp; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf29.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742908702; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hmi1AWNsJXVFY/UuGGYiipEGSV0NO0EM2xhVp42xeFQ=; b=3XCvt1Y3LdbNzkOSnhBAKukgc6HLNZAc8jDRQ/6ISxQctD8+5Z4aZs8iiOSlzvnXumKKKF zi6PKbyRgxXNE71D/Mjnl4Ch53d2NEtsuMNehrbVryT0DjAc0FJ68UMlEbUsvPXuCxMGPR SqOjh+j4YVts4L7SpJBufsoxCN5HFeg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=eMd4e5ne; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=bgXaPSJp; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=eMd4e5ne; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=bgXaPSJp; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf29.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742908702; a=rsa-sha256; cv=none; b=buLv9EaA/vV6AYOUZ23I7FJEFxOYYdB7uwkznuRhI0wJ/FF0RkGhl88lYmcLp9ezyk+Qpj AOW6mdUOCr9DFuYYYhNJFKBpsbMun8vni3VYK7EmYtbnRrVktupyGiEVxxY3qnd6nN+to5 cxZfe2MdmUDm+H76VEumUsiwVgs1K5Q= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3EE002117A; Tue, 25 Mar 2025 13:18:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1742908700; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hmi1AWNsJXVFY/UuGGYiipEGSV0NO0EM2xhVp42xeFQ=; b=eMd4e5ne94m/O/OKvtDHc4P/71IUF7jLo/gA/wcI4WfT1lRyth9Hti00+UWbkzAu5fUY9b gBTSIa1VQPEya1ydEXCLDmodVtDmn4PQACDz4yztM4qCL268AFLhJHzpD+/d+YE+WQDoom f/cdY160rT8rBk86IioP6caMGr4c2KE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1742908700; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hmi1AWNsJXVFY/UuGGYiipEGSV0NO0EM2xhVp42xeFQ=; b=bgXaPSJp7E5p5ZIvxKziEZsgWl1ks4sFMm/Yhjg3P1d4TS20uf0d4DB+G59WizhzdyQ+D2 il3UHxgwyhDgUKBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1742908700; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hmi1AWNsJXVFY/UuGGYiipEGSV0NO0EM2xhVp42xeFQ=; b=eMd4e5ne94m/O/OKvtDHc4P/71IUF7jLo/gA/wcI4WfT1lRyth9Hti00+UWbkzAu5fUY9b gBTSIa1VQPEya1ydEXCLDmodVtDmn4PQACDz4yztM4qCL268AFLhJHzpD+/d+YE+WQDoom f/cdY160rT8rBk86IioP6caMGr4c2KE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1742908700; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hmi1AWNsJXVFY/UuGGYiipEGSV0NO0EM2xhVp42xeFQ=; b=bgXaPSJp7E5p5ZIvxKziEZsgWl1ks4sFMm/Yhjg3P1d4TS20uf0d4DB+G59WizhzdyQ+D2 il3UHxgwyhDgUKBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A4B1913957; Tue, 25 Mar 2025 13:18:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id RejjHhqt4mcvBQAAD6G6ig (envelope-from ); Tue, 25 Mar 2025 13:18:18 +0000 Date: Tue, 25 Mar 2025 14:18:12 +0100 From: Oscar Salvador To: Jinjiang Tu Cc: David Hildenbrand , akpm@linux-foundation.org, nao.horiguchi@gmail.com, zi.yan@cs.rutgers.edu, linux-mm@kvack.org, wangkefeng.wang@huawei.com, sunnanyong@huawei.com Subject: Re: [PATCH] mm/memory_hotplug: fix call folio_test_large with tail page in do_migrate_range Message-ID: References: <20250324131750.1551884-1-tujinjiang@huawei.com> <899807c3-931f-43e6-bf3e-188787a4205a@redhat.com> <68ab727b-dc3d-327f-33b6-25bbfce8530e@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <68ab727b-dc3d-327f-33b6-25bbfce8530e@huawei.com> X-Rspamd-Action: no action X-Rspamd-Server: rspam01 X-Stat-Signature: o4artfy4fig1m3hbxoxwwpomi7faompk X-Rspam-User: X-Rspamd-Queue-Id: 1B0AD12000B X-HE-Tag: 1742908701-765315 X-HE-Meta: U2FsdGVkX1+aDivfG+mFZot4tAPVNIq0IhcJdDdDod21RPgGunRlWRZ2+gc0ZxNPk0gaZG03N39yXG9mt9fgQFKvm2bJUR9CY2JzvblShFuw5mEh//8hulct7tGUz4EEsYwGy7lD7yAREOB4VOA+JClr3vPPz6JV8mH4JzMsmBKSRBC5DsFs4NunPlUeb8a3zuDArLVzcgmrhfsVWIfdxFh5DCRVIcmiJFKmJiu9fk8X7wk1GqjlrbeHWrsY24mAdltuJfiovbTYEPHkWgWStjIZsfP/FUlPryz2j28G/QNDit5KV3TzvvWGDfxF7ListpoXkO1jPoY5Dl4hrqdFNrj2TZTmx8qXDbG4XkzEaQSt1EHAfnWwf1v80ObXgRHxUQKeEd+6TttcrNrY6ExCsbmAirFc9GYqHfV55ZASWlrL5jpf1Yc1DNAui/BpzFfwDsx4NDx5PuK6VN/RqBEcnzoA5TAQF4HcHWKr8D6RSEvRXyODK7+lqk8z86tV5YKgJPldN+dCTWhrSdiZ97GPxCjXdCMo/FQSMmZGVI4uJ2x4M3/rBYWeRdkJbPnOb5jshCwF2RMfVVAxWE+4bRhCsn/5r+GT+QYb4IWcesq5ZoBB4eYxBpli2YP9fOGnZSFK4nKlDmjzX6uax1IF9FOiEzfut/uBoy5b7X8KRn33yensPt9uLTmMO6yxuFMZNNbqmibACa58d0RGJ5SnVfinSKNUe4okYq5FX4Vfm6G/ZnDyPtq5KfQi9Y26frZo2eigfpy7jfYpBYWLwUIRjzvG0dxWDE9W6v6UiWaLk6KbCMvK6msg/2nb+BJDt9oK4iPtXBIWSMAmGMNvSjHiO8664Jr3fRdgV2p/AeoOqPpmclbUHy7RxwCRye9yIhGUx8kl8/rLo2o8XT3nYmGDkfYjCwDQdVCp5ljoP3uTETm0e3jhlgcisxxZD7oBdk0y+oJW3I3qox4PDuhBeebDdmi 4FseohD6 4zAoZbBrbYg5Juqy1wSmEz6ULQdAWv2Agvo5AQqBjeFf4jVYIPJb1xhZy81PNX6NCAQFQt8rTPkAqn3G4BJLLdFZiP7it5SVh6gEgiGSbn+8y8l0elDwT1EPREDhZJRY9wWQlg+50unP5eHA5GVlp5WfDAn+XzB6AEUKS2qqT8PQq4vs0iC4r9nTrxTrSEV+P8unaGADT9LODa6n3DESyyOdfE+wj3JvFo423Z6lnopXAlNXn7pLCwnUFEpqwY8PchJZN8Aok+oUh5yxGg/CHGyphCU2Yl71GfU/0J12qQ0S3a9ybhVCtnKNDkGaQNCuhD+mO7XvQwOBflHccu2Evvx3wsE9iaqymI9Rt7g3ggEKM7wz9fVNIj9o5fJ6fdrxJAdcv X-Bogosity: Ham, tests=bogofilter, spamicity=0.005214, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 25, 2025 at 11:02:30AM +0800, Jinjiang Tu wrote: > extract the code in __dump_page()? But snapshot may lead to > do_migrate_range() slower too. Yes, but offline is already a slow operationg anyway, so it might be worth doing if we do not want to step into this "middle-operations". -- Oscar Salvador SUSE Labs