From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84C8EC36002 for ; Mon, 24 Mar 2025 13:43:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 81591280002; Mon, 24 Mar 2025 09:43:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 79B37280001; Mon, 24 Mar 2025 09:43:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63E33280002; Mon, 24 Mar 2025 09:43:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4A57B280001 for ; Mon, 24 Mar 2025 09:43:58 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 29C70A94F7 for ; Mon, 24 Mar 2025 13:43:58 +0000 (UTC) X-FDA: 83256562956.29.8850929 Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) by imf23.hostedemail.com (Postfix) with ESMTP id 5B21D140008 for ; Mon, 24 Mar 2025 13:43:56 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=GuArCzHj; dmarc=none; spf=pass (imf23.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.181 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742823836; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vGW53LfyIVcfMlHvMt/kyxY4rw5TXGHD2Z6PF0btLwM=; b=6kXuepuDM4IJoMcIq92Z8jK8/QqYTXajaXiVMutH+2f8RsOpVROcN8IV7GEeHRvN2LOD/J 4VLFpp/MS7b4MbZbER5h0LGYktz2hyA9UlDKNT5F/wm36sYCCx5j4zmiw5GCqnS+vfVNig xigqn5aM6/nxX8IgaYZf2Z+1z6hi2IM= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=GuArCzHj; dmarc=none; spf=pass (imf23.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.181 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742823836; a=rsa-sha256; cv=none; b=ux0bUspjVr1O2g6d9xgGTa1/wjn9bpaNHqlItKjqW+T3o+wd0exsQHPaC9mB4wwZU9eV41 SsWA8zJmtQMfUyIIZnnWQY5hAcanc+IccXjoYlUburYbAwuEUMX/4aTmjcMk6GwkThUw41 yabCsDrIT3ZtMtHpoNnCO7BWUgHlf7o= Received: by mail-qk1-f181.google.com with SMTP id af79cd13be357-7c08fc20194so929324085a.2 for ; Mon, 24 Mar 2025 06:43:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1742823835; x=1743428635; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vGW53LfyIVcfMlHvMt/kyxY4rw5TXGHD2Z6PF0btLwM=; b=GuArCzHjXj1DnTemw7QAo/0+NwT+bvRftuK+aupk5STDqzBpPAogD1BCswtZJYnly3 So+nGG9n9WHB+/taem1H9ZfSGXN3pxN6dsbcX1O3s00LvGLa5P6IHrS5bk0yfwh6Ml3h 9+BQBvbX5rw9GZHXvFhqYvla9fNZEWsaclYKeVoYFAPDCyDBx3jOASft6ItdM1LPfjPD hbAlfG+gT7CI3ivvjFTzTblw38rxWPsNgFTkmtd7u2qIfv8UoRgOD7Il8FywLLCsNScw 5TW+JBVE9iwnFMVttrg3+H8Rd/qABI6gqWsnUzODwuOBiWQtkEz4wFygQxXqnu05yED9 nwCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742823835; x=1743428635; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vGW53LfyIVcfMlHvMt/kyxY4rw5TXGHD2Z6PF0btLwM=; b=mtb4SeOBSvn9eeKvIIeIc3Ct5Uhltt610GtgsPT0Ima3qNJtldlIa6uViJuM1L93Dy R9UXVqcggoFW6hLRVQhTfIUm7X8mr7cYwdHDfNjfuzUbbQm1aQjTtyOcWShsTWP+Nr2B Gt4BYgwalDLr38ltoRId1aUNG5MIRBLdXgp0eQvl6xCzg1paeiWBgqy6qxhHFjE+wXnZ uo/GHHRiRjrOAMylgFTih16LxFVHp1v2s+Wk4+nKBUTn298YzTENj23ybaPyjz8xrDJc BYnxyCl2OcqtxgI4H75X6d3GmEdcxz1iEujqAyDA3QKpxFpy0lZLqLI1yasW1JCEPGTe 5Vfg== X-Forwarded-Encrypted: i=1; AJvYcCXrdsTzKjlA6pKJjI+BxzRbbhXhBCUuA/wJ6eDg0Jo5Q/50B9NcSMWIA3wDOoAW24aP6mXNZrYZfQ==@kvack.org X-Gm-Message-State: AOJu0YyGyI33A+uRqAYAtR+ZXcHpFRclZ0kJsspLV6YPvaVgjNLvhCBt UzGRD4f7mZgbSh5ws7RxbQnWfflwXBaUM6QDCsC76wETeX0S4oxqG8UxIfOkfbU= X-Gm-Gg: ASbGncsy5DOml5aNEFem5elF++CgFZahG8P346uVxwlj+7XUS9KQGnCdpIdag9YUPo2 h2OGn6mpqcs+qM0ffpu/83XBYf9zRWzuKlJ2ikf+PxR2dxMUwtt5o1VgD3uM8vs17+6qrMM7ZMM 3OI9TwIOisNM29Jwf/dv0sl7RHworkgQKSmYwA96NlYS6voji1TY06n11IK1XUKwHSK6lFK0MqS YAwSe5zepCclobd0BpbTYwqJ5v6MJP+WvUttRy2Wwf9rhBYDLUJm4dRpmuT+2BunTam0+uH5MaA vAyAMF/N7949RkvPu2QAYAmSrt4vwfIJCGsJiIokHnwAGkutI5Ao6g== X-Google-Smtp-Source: AGHT+IH8FMzSfvRHQLrikh/cxN2juHwustpDdgjWn8aSD//4Ho2J2tvUAcurpDqW2WXUj0eQ9aDqjA== X-Received: by 2002:a05:620a:f05:b0:7c5:9fd3:a90b with SMTP id af79cd13be357-7c5ba235ba9mr1867116885a.47.1742823835257; Mon, 24 Mar 2025 06:43:55 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F ([99.209.85.25]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7c5cf74e3cdsm163064985a.18.2025.03.24.06.43.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Mar 2025 06:43:54 -0700 (PDT) Date: Mon, 24 Mar 2025 09:43:51 -0400 From: Gregory Price To: Bharata B Rao Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, AneeshKumar.KizhakeVeetil@arm.com, Hasan.Maruf@amd.com, Jonathan.Cameron@huawei.com, Michael.Day@amd.com, akpm@linux-foundation.org, dave.hansen@intel.com, david@redhat.com, feng.tang@intel.com, hannes@cmpxchg.org, honggyu.kim@sk.com, hughd@google.com, jhubbard@nvidia.com, k.shutemov@gmail.com, kbusch@meta.com, kmanaouil.dev@gmail.com, leesuyeon0506@gmail.com, leillc@google.com, liam.howlett@oracle.com, mgorman@techsingularity.net, mingo@redhat.com, nadav.amit@gmail.com, nphamcs@gmail.com, peterz@infradead.org, raghavendra.kt@amd.com, riel@surriel.com, rientjes@google.com, rppt@kernel.org, shivankg@amd.com, shy828301@gmail.com, sj@kernel.org, vbabka@suse.cz, weixugc@google.com, willy@infradead.org, ying.huang@linux.alibaba.com, ziy@nvidia.com, dave@stgolabs.net, yuanchu@google.com, hyeonggon.yoo@sk.com Subject: Re: [RFC PATCH 2/4] mm: kpromoted: Hot page info collection and promotion daemon Message-ID: References: <20250306054532.221138-1-bharata@amd.com> <20250306054532.221138-3-bharata@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250306054532.221138-3-bharata@amd.com> X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 5B21D140008 X-Stat-Signature: yjjekkpcmhs5wuinsxrxzjdwqmemcmed X-Rspam-User: X-HE-Tag: 1742823836-965132 X-HE-Meta: U2FsdGVkX18CEXbfcCQxou4/Ds5m9gnIsGlSJ+YozKmMx1qepMdxa+J2M+YKgPb37UScHwXEwshRg7szV5F4ei8BuVVoW7wmmhQrLf1kQnRpe/ozU3MTE8ZE74l3wrTQQT7amHMKrVUGbDXEjf1LBIGiAhkhOHmnk65ALvnihx6bXnfSVv4fHEd3v0ZKJ8S3P2WdDdLAU/lCWGx1AmaTKOiXQMI6HSgGZxos6wVGbDtLlrIpRruJMTrkywdFaEODNUHMIKgr0JXHl44qUVJ+LtcLGBhV7M3JWVytQxjz20B5dGPAzOxdj5JglFI8j4J3GRamV3Xp3gTkfKMBCi7IOstnTo8uk0gEN7F0lWf8WeWOBdOndZOCLXxP3lmDpWzgNGnfUHtmCX6Jh8GX8TWdrw8kMeKeAmfjuT064UP/rDWb/0xxQjW7B3gRm0ODwo0ZrHNArt3PRFkkXjdkf7QKkZI5B1FOeZSsROA8TTSNfEDr16YVUNRcGhbq/hjQ5ykHrINsecErbUKVb/8mvRBrq+UrJOnYiRgJ533+5RquulY6jiQVToHUBWweKAG1PXPIxhiXx+V3boMzYGpE2mENCLtBqCy8vChY7wbsu++E+AvpsDyttJD5PDtYXhaxLQRcPZGULFuPtn6MxxXAJxNUrvZmYiUd4HHkqo3/lcrHRu74oYSy2LpkpLD4fmcckZZCjaiV+zvIUJtrI9NsjPfplpLAV5pL/PHt/PnZ8KSO9JOYjjne6LAFX7k43wl5QKAakzgyGXODDTKvFsr4EmKX2HkTKj2x89+1FaeHX8gds3oHGYISADCkRPikC3lkHT1sgBJTzUxET/xRIzUuuRw/be3ginrWMG4LPykq21EwzivzZfSqb3woxnCQ8l6gbs0bR6oX4eJiC9PnuQyLnF1UJwdZZ2ay1/S+x4L3Xk2/ikDLRtSVh16kOAtiOElFbjCLnHH5PTxFbp20dueJKJX OBKypM2A LCkwEAEnQI2lFqx9mvVeXXngN0h6qx33Lo81/xhTV3ZGTnlET/EnfwTaZ9dm0egXPqrYDamP1UWzrQvp5Wn1gJ+c41H1fNQ6oD6dddvFVz2KvK6b1QIfibUljjXhvjc6X6W6kuldl0ZPE5hKP00GcRI5W7W61MCGyAhv+3wO+VOFG1afrbh/5elXguiCMeEnZ7ipLH7vfXKEp/GVqyDVI/aNPKgbRrWIz6a1NxZzOWr2jeSVfHT1WqGLB6Fa6cXt2KUiDQfERTbiu+FhAKD8ZyWkXxpbt6hZD5Da0DNScIzU9UFgyzlXhnNrhgZA64/UCaWQf3C3JJCfmOnZB9b9gxuLr7DX0vWogZd0Xdd3wx+IovO5aVY8OYO+eAHqf9EO1aVkAmFg0eicVODzbEkTfg/5hOg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001052, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 06, 2025 at 11:15:30AM +0530, Bharata B Rao wrote: > kpromoted is a kernel daemon that accumulates hot page info > from different sources and tries to promote pages from slow > tiers to top tiers. One instance of this thread runs on each > node that has CPUs. > Hot take: This sounds more like ktieringd not kpromoted Is it reasonable to split the tracking a promotion logic into separate interfaces? This would let us manage, for example, rate-limiting in the movement interface cleanly without having to care about the tiering system(s) associated with it. my_tiering_magic(): ... identify hot things ... promote(batch_folios, optional_data); -> kick daemon thread to wake up and do the promotion ... continue async things ... Optional data could be anything from target nodes or accessor info, but not hotness information. Then users at least get a clean interface for things like rate-limiting, and everyone proposing their own take on tiering can consume it. This may also be useful for existing users (TPP, reclaim?, etc). ~Gregory