From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87A61C36002 for ; Mon, 24 Mar 2025 13:32:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E225280003; Mon, 24 Mar 2025 09:32:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0920F280001; Mon, 24 Mar 2025 09:32:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC465280003; Mon, 24 Mar 2025 09:32:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D242D280001 for ; Mon, 24 Mar 2025 09:32:54 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 27133160637 for ; Mon, 24 Mar 2025 13:32:55 +0000 (UTC) X-FDA: 83256535110.07.85B80FD Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) by imf14.hostedemail.com (Postfix) with ESMTP id 212A810001C for ; Mon, 24 Mar 2025 13:32:52 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=m8fylIUK; dmarc=none; spf=pass (imf14.hostedemail.com: domain of gourry@gourry.net designates 209.85.219.43 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742823173; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iJ3k7yEhYDRnLKFARJZHNQlKgfuegZSgLZhOzT1gU3A=; b=Neol1JlF+obLkypt+ibDQtp5IifbuaA34gDKip6+brQqnj/PRp1PwX8UkxFxwrGeK8GQrL 5jR+xrOxsxX5d2/Y3u40oK4z4H+2Okn3mSUif/IWWbdApDClHeROBvE8AJfTgVrU+iGw2F A5tSbqaxHUPIzxWlvtWihbHX1MuALGk= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=m8fylIUK; dmarc=none; spf=pass (imf14.hostedemail.com: domain of gourry@gourry.net designates 209.85.219.43 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742823173; a=rsa-sha256; cv=none; b=P9k4Rsy5a2E2jPzTRRZNdaZzBvCX3BgUyncjR9VLwdlkwvZE5N8SE+IYKQ3Wm50EPoQxS2 KymzYXazDxeGFs37Y9DhbCGcE+Dgt8lhFeQrh14XM6X4HAtGQ1+YcykA5iyigsS7gmv5a2 zBt85uedJVvo5ec67xvzQzXjejB1GZk= Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-6e8f6970326so39319186d6.0 for ; Mon, 24 Mar 2025 06:32:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1742823172; x=1743427972; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iJ3k7yEhYDRnLKFARJZHNQlKgfuegZSgLZhOzT1gU3A=; b=m8fylIUKyU7+Q+n383FGnZRoD1uYlb9Fo5m4SJbVlUHAYwEcpyjak19Pdzx5PqETsB 0QFQVyJO4sMWnXjnrvrJ2iTMDDwbj61bPdfbTruhQttG6lzpdxrHUwRl1Tuh6UVDcifX hnRSZtqOBCcZMQVhNbXlbd42nbiERczNMvcV8loJu7LGkjeqi1f946XjuKaYwhF57Ips ku7RQ9uNCQCYON4ASBx1MHBiIEjkIPVNJbmVnYswbYcnAGyt5ZD7F8rP5lfEsP8ecGRm PpcY0tgB/QGaXi2JP+XgmLmNNThxcbIchamW5MAFe3a3MKgL1kSqvIsQW6wbJypTHsv0 fLMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742823172; x=1743427972; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iJ3k7yEhYDRnLKFARJZHNQlKgfuegZSgLZhOzT1gU3A=; b=mfEQk2VfSiNqkSTamZJQ7q9F5oH8BWK9zwIQ+lTx/DuT/9TQVjWc0YbFms8C2FgYFY lk2EPmAAExwMygsum9951VBdYn3zyOkOfr8dXkKbpEFoqa3nJyN8Y0QeYpeySBDFlI8l z8qf9vpsLhzKirT6H9w4/DABME4WvYMwGigD4DhP2CpQYT9aEFUWiRRszf4Cs3Sj6L6W pLIbhn47o6Uu3aRotkT8O6+jdeGXsKfxgZj4mADuXyUpDvvuLjRTl/ZeGWkt7e//m/qv qiuD8I8i4zKAwvwM1FUt9BR93SBm0OWcwLuD98JS7enesvcY+60lpOUZFM4Z27L55N45 Bd2A== X-Forwarded-Encrypted: i=1; AJvYcCX6mewJy2b38M9wweulKdnTTWNi6kBw5dYpYRVVWv9yv+a0veAm7nmVneXeUT8z/5m7TLER+ESyqA==@kvack.org X-Gm-Message-State: AOJu0YyDCUhHVMBmaXGWEY2s5MOWznrkPETQ7pSwIWdurm/W1Wy9qafS wIiOLRUEM8Strceiuo/q332qufN4jtgTdkwqjP4LUDJ2YE9iQx8KFr5NPoJg5Qc= X-Gm-Gg: ASbGnctxNpOisNQXlrFGFtZ9xC7U3c4Xe6XLO/dkWM79q42rh4e3hYvIoo1QM4cHqbz pOo3Ygvm7C3mfviGnTuAvBJXsJqSY334CgoEI2E84TlO5K8JwDDAMeE/nQRBYOHDWSlHOkgv3ii jeQyVw8GWjmvV5kSqwX/zSKHryLWs7RKrP7KsSdUIxEQRREuhowb2uTP+yJiN355d0eeZSs407j 8/76Fl/rQqUh6suPqnvz3NMfbBTypaOstnJUdAmF+H+xQeHHo2VBsumeBPiPaY+ibdNx/yPnQe8 PbMolqzXLYpuLT0KrULxzYa/wKy1816hftqntpCmVIv/bqEtqGF7qg== X-Google-Smtp-Source: AGHT+IH6AI2Hu4EvLbPfd+tJ+iT15wj0QMHGeMvnf+rKbGzhr8KsnPvdxaL8QbRANSa5d3GYbYPvMA== X-Received: by 2002:ad4:5f4f:0:b0:6e8:fe16:4d45 with SMTP id 6a1803df08f44-6eb3f3446bemr145244976d6.41.1742823171962; Mon, 24 Mar 2025 06:32:51 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F ([99.209.85.25]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6eb3ef34792sm44450036d6.68.2025.03.24.06.32.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Mar 2025 06:32:51 -0700 (PDT) Date: Mon, 24 Mar 2025 09:32:49 -0400 From: Gregory Price To: Rakie Kim Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, joshua.hahnjy@gmail.com, dan.j.williams@intel.com, ying.huang@linux.alibaba.com, david@redhat.com, Jonathan.Cameron@huawei.com, kernel_team@skhynix.com, honggyu.kim@sk.com, yunjeong.mun@sk.com Subject: Re: [PATCH v3 3/3] mm/mempolicy: Support memory hotplug in weighted interleave Message-ID: References: <20250324084920.987-1-rakie.kim@sk.com> <20250324085433.998-1-rakie.kim@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250324085433.998-1-rakie.kim@sk.com> X-Rspamd-Server: rspam01 X-Stat-Signature: yt8mxib4petzsimx1xn6uuh68r9kpniy X-Rspam-User: X-Rspamd-Queue-Id: 212A810001C X-HE-Tag: 1742823172-586286 X-HE-Meta: U2FsdGVkX1+k9LpcvvecI69wtoB8Ga2ezANQLCvaps8wjzE81x9r9fP+iJZgAMtJ+jiZknI1cfcpYq0beNusyoZlLuIW4SLrKi0hpT+Ob4706DWm+LSFA/pO/e3A5ipnogZsAeS2/UghV+YzEXtYSArSI2szcomYIityaiA/4titaSS+KbMhWIIHZ300mJTRptc7TSoYclSdTASrW72lEpc58IT7xFUW8oWs7/vDR5qVpBSHvKOJd6LUN9XvQSZviFp0tEDq4W+nItfUFQZlmAFzVl8TpwNIIXr1oEJZ6b8g/ldiyKYUC5SKLJgQPAxnlFwUPepvZZbmPclmeDLzj0hDzFmu1AhtIbkmHzIStZNRUdfEb69WWtDyox5hatLUoEPTKYTTOVhXnYWDZOPpGfGbql3OG/GA7rZm7fgctlpdnzu0uLTUrtRyWXS+qYKYuVqvjTu7sn3rwjdoAR5rNSi+Tz1hDrkoZOVCWeo2lIzWu3HdzYDcl3D0hF6qw8LJg54GNgzLcad1csCnCRm+Fs7BqS7kRlCZ8Ju+JopozWbM9O6vIimGigCUZGrrmxe0YnmpLtMXD1XrXgFfzo6IxsOCzomx7dT13LmDKFvBxEttAzLLbAwl3bqBEf1FhikfvlOXsolTkHozCqr/eb+Y5c0TUroq/z0/mI+hqSiKWU0H5U0L0VsLEXzVbVpCXkjUuay6Ji2LrGE7XRn2j8A9CKJANbcigLXzXg1qxqdzsKPp5p9sFtnkp1oiPvsMTZwgjO+0mc+37ly5Nlqi+H29WJBEmpa1pQfZCrOzPD2NLqs/Q87LgmozsbY202VhQuU64N6EyuzYWS0iekGXkJcrcaS+5NmmEc6CCrE5kWv5HLmnmVko6RjDFVWV678FqpbYeUUVUSgy/U+/W5qzPlKYUEdsLee7qXNH/8TcgeoCYt6XHcw2GqXaR2FVEEZWTpVvInCRyD1JJvf3+9ftbz1 mn3rfkkc nj850WCBr7eUY/RtsFJdENCqZvNAbytp56TSyHG3cm3JmmKECffLTE7GY2GNA4zLnCtEQzEMg5IX2RzeSa/5ZgttRAZWIMTW2KYFSJkcoWpDd1NCZ35q9mxS5gEBlnKKYws2Hgh1PNGUrK/BW1lSqJ641n9ToN7qL9NQV2hNhBTzcv/fqT57GJL3vJErcPo4v31vRqqNAFFfKI2desbgtFfVQHXHS9sE6I23Prx9g0BPGjtV7hdoBnfMOzj2Zc3G88cgRyd28t2L4JoQfIS3SBXvGLEVNsQRl/FqDNZGLFg/VD6dZ1vaBULMbjXcEDb0aqY3CBVcZq9P0xGTVXhzAx/it7rx6hoZhHCbtdx6Y0YgBefA5EvASFzRGAM8OJYDD6zGqyiIlVbvaHUhZvRNho5xjAw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000773, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 24, 2025 at 05:54:27PM +0900, Rakie Kim wrote: > > I'm sorry, the code is missing. > I may not fully understand the scenario you described, but I think your concern > can be addressed by adding a simple check like the following: > > case MEM_OFFLINE: > if (!node_state(nid, N_MEMORY)) --> this point > sysfs_wi_node_release(nid); > This should work. I have some questions about whether there might be some subtle race conditions with this implementation, but I can take a look after LSFMM. (Example: Two blocks being offlined/onlined at the same time, is state(nid, N_MEMORY) a raced value?) ~Gregory