From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B75EEC3600C for ; Thu, 3 Apr 2025 11:17:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 11F0A280003; Thu, 3 Apr 2025 07:17:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CC88280001; Thu, 3 Apr 2025 07:17:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E88DA280003; Thu, 3 Apr 2025 07:17:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C66B2280001 for ; Thu, 3 Apr 2025 07:17:28 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1FA60B85D4 for ; Thu, 3 Apr 2025 11:17:29 +0000 (UTC) X-FDA: 83292481818.30.FFDA331 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf16.hostedemail.com (Postfix) with ESMTP id 24BED18000C for ; Thu, 3 Apr 2025 11:17:26 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=R8uSksy7; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743679047; a=rsa-sha256; cv=none; b=qZD29fdqJr/4dq6A7KLkR3F/9Nrm6qCC6VLRIZ3gzZPJ9ESv+ZGcXC4iOMQyKHMKFEJXFV p2O9bMm7keJ8GJs65d1++dbuSxXkp++zbmx8rCfFBXA/bAHKS+P43EBSF1vqJetfv4F69m Kd9z/SzBoP7O2IEQIVuzW42zvxc8GYA= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=R8uSksy7; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743679047; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9B6yGiKNwNdzmfscTDQkaW1QIyxljiYzQv2I/D7Krjs=; b=srNSPRxSJ54cO7IFV1eTfB4l/4miuvq70jiH0wdrF+PnzmL1EhsjdB5TST9dd0fIg6PfdJ C4O1ZOYhFkzaTol8yxMoVWe9OSpdByToqGVG185cHTeNp8bO7u/GFFShAwZgYhXYs8tBAA s+FhS/lDWKPxiqMXIW1euEMRXAQg/Q4= Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-54963160818so932170e87.2 for ; Thu, 03 Apr 2025 04:17:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743679045; x=1744283845; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=9B6yGiKNwNdzmfscTDQkaW1QIyxljiYzQv2I/D7Krjs=; b=R8uSksy7C121UpKvHuk8+IqtDHOcQVIq567HFEOAZlGw5B3moPUiNXPIn+OwQarJWU eEAhvo4PkMcb0YDHiH8jHN3zH+5QlPV71fxYP2BrxEvfofmUPxZYQRCmwnoEnHl4IOBk qUlpQcEAN3+ZTyGjMb1EqwySbHon85EBZwcQblT+ciYsi+dfDTJPpard/JsPrOkuNneN A6KWw1q/VJ4q7WKY197ljFeX2cy0mxcnxKKilFuXPVhwqRavPDLlWDTWm2Z55sDchx9w mOhj/ttmq0xnexEs+IncMLzCbqdAx4iDN6e7ydwhPuNkqQUo4P3EApR8JTKhcCpSIVdM eqYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743679045; x=1744283845; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9B6yGiKNwNdzmfscTDQkaW1QIyxljiYzQv2I/D7Krjs=; b=EGSQPAIQSl3UDiFmQ6gdiXPLBnatSqd26LGW3oGQ5YRikp8KTvYjtu6A/WLesv+QKC 8CVxJRAPLsfjYfHe8e06LmmPPfWKG8xxd6z/3+tAM3XumIaeRjMiSdCc5lX7rU+oZyQ3 8hpaoc7A+6Lig8Ck9YwNkmUyB+BFKdqvUOeoLeOsCHQko+SbWs0UUyYE76dp3XWCwoA3 nPYAUNL1JtPzoX8BH+eFJ4OpgvyIe+XKQemVtVANYHN8S29NQw0g8FGUXssIxFt8QPeL TEy/XGmIpuahojywu4Y8/Lu5qsBtKkTj/EZDzIQlGXBmEOCJxU6zmW8GaZgP8JRpZG1S 70Ug== X-Forwarded-Encrypted: i=1; AJvYcCVMODCou8DYeCxZqZsFmBnk990es2sa6hCvlhJwkN2689DVwPQi2GA1iaquUqFjJCuhJO40gGg4VA==@kvack.org X-Gm-Message-State: AOJu0YyHHhUBxB/pq2Ywp2G+zI9xmI85vtfA86aOa9xAHNpBrlVAefu3 /3+yjYVc3OwHpn4cPr5fPSiHF7+NhBT9/QkRuPIPodG/wx20GBKf X-Gm-Gg: ASbGnctPCfiv+StdvwWuYCl9D6xd9R76A8oDHAJLizDtL4OlTs8TWR0DfTCin3ab4dz uaJLZTqW/5Q7lAN77ccD7vMm+o2nnRvotLHJxSDTVWLu4u70gP5eZ9OIv7NVvlrVPw+U4hr7GiZ ALH2wJTL4lYSepAj/6V4ogFMfwJ6BbJEaxMkofh7SpU2J5Hr+bopyEcX40Dvl+Lq+dClCbh4lYZ 5VMFugpmDESfs3Mr+iSSNiHN6bry5B6o5nUOyF/0pCeHjjF5/9NVGGtX2CkX7593euZREVWVX19 AOJ86eXtQkU+RqeN/1XS2AfQhyZUr876uCUOQgVyVCanF4mXM4e5cs27KlYtH3hS0tPc3tZc16U = X-Google-Smtp-Source: AGHT+IHZUpWn98mMs6DpAc2coIrgcsTFuvOSeRMOYSdkF01E5/yPiCCmRA+Nar7c6MZGly5Oz5h8gg== X-Received: by 2002:a05:6512:1253:b0:54b:1055:f4c3 with SMTP id 2adb3069b0e04-54b10db969amr6977015e87.11.1743679044928; Thu, 03 Apr 2025 04:17:24 -0700 (PDT) Received: from pc636 (host-90-233-203-182.mobileonline.telia.com. [90.233.203.182]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54c1e5c188bsm125274e87.64.2025.04.03.04.17.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Apr 2025 04:17:24 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 3 Apr 2025 13:17:22 +0200 To: Shakeel Butt Cc: Andrew Morton , Uladzislau Rezki , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [PATCH] memcg: vmalloc: simplify MEMCG_VMALLOC updates Message-ID: References: <20250403053326.26860-1-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250403053326.26860-1-shakeel.butt@linux.dev> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 24BED18000C X-Stat-Signature: gr6z3nfha6ubjrjm8hp9e3szok7y8y8d X-Rspam-User: X-HE-Tag: 1743679046-707798 X-HE-Meta: U2FsdGVkX1+p/+QHa7XvMTFYX+MpR0LmN7sIAU/xTyqN07MWlsHojuA+HmxP9AxSoUKS6Qe67LyI7ultLqvYVHZdF/T3RvmVVHIuQywZNr07hvR/Ec/2sPzOGg16hgXsu/7ftstE1oVPanQ8iZ+VGY6OZ3JsB10+lrHaoteokZ32N4eDh9KaQjNkGLV9gHamATWFQbb/qC64R60y9uhsmcU6FVdKZKELtnoYKAoWIOMQCjMTsELDrl0UtXVOfPT5uJel/pdiHqcJ+4cJadh6R6U3qsRv39TXo8iHAk5zqj35b0146sdF4zmpOrJoN8/8AsqdOwvu1rdvdbI03ySQz1Wy2a62qcv8/BssHVeN5Pvb9yb8sBFJ/3zua+/gnRqIHknnhRi1q3SvliG/pzZp+iWLqFzVUry6x3ED0ecbxV1Gkm9dsYr+53nR9PkJiucB17NBXUcTCCsTtKw1ynYaYduHA/rd2hQSuTtphNXsYNTPGNkTDg78p2aQpa7wqKzqmCSqDQSRuvDZNMmuVRAnU2vhJs+4qHcA0vom34uYgcAvAU0V51mBUp9ecNldjFrJ4jwZziaB/FJZRhbxlGC/Pj7IumDtu3ba23wv4AvYEvpaUxpMInSi6zQLA3RToQTVjzJ6yrwALm46PzIDgX981qGjArTsx/0cCaCuyELyrodsvG9bou6jVKdbn/Z5IQc8G5xR93DDWmgsAvFW+/LS3UNQuOyRHQR54EhxN9vfNu5iYYWtfgZTVxoVe9BIgPZ+jGe1PQscaxAubOtI9CivTrFfocD+S8UfooduUcMLvLPQX2DzS+/+PKIpvCb422i/B8AmBEi5cRb7CITsk7VFyIkvAiXkwV1/LlnNhkjvJBQOibbrG0IIH8albDmeXCL0Aydg21yJqRnIYVijYlcv6ysuKREcwmZ70wUM7LsoTgAvDZzisNFrcjUlqtH2C12iWjjS7FfUKH/TAW7MHTL XRCK3lLn TE/WOAV5XgqhDpmxyiG2sE1cjdZSORxNvrBREcVC66wJonWkvpSNzdYi1PbOlN5r2dCNvddYjdIit2NzWNv0Gv8xxqE0fQxahgdDmqZ3cr5FWjoLFBAYVRDcFdDmqVPS4oVG6C0DgaJBIHV5IqXplFYt3KG1Pu1YoK7gNLRvN9FKEPkXyfj1sbJ864t3rWjJdDnf7sGrogvVdrF8DSkppZeTIFRUeHKnTAC0/Zv/jsRQXVG/RTVjjPqSowBydq9vgmJ/ZTHDM2lqTNFQ5KHIrWMX+6ES9zgNu9ZT5tPZsTHTQonfJYB/YEy4/qCLxDbSmvmVb5FgDRft/6//ZW5AWipmoUavYbbQtQ8mJc1ld3sL7xq6upO/7c4ZxW3SQIXA6kYLss9uxs73smWscQXEUNR8ozwuulwnMl2aKKqNnMvKou7NOAZSrogEYGcN9YQCVEILGzQXYrNaltssj6k/UmXEarA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 02, 2025 at 10:33:26PM -0700, Shakeel Butt wrote: > The vmalloc region can either be charged to a single memcg or none. At > the moment kernel traverses all the pages backing the vmalloc region to > update the MEMCG_VMALLOC stat. However there is no need to look at all > the pages as all those pages will be charged to a single memcg or none. > Simplify the MEMCG_VMALLOC update by just looking at the first page of > the vmalloc region. > > Signed-off-by: Shakeel Butt > --- > mm/vmalloc.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 3ed720a787ec..cdae76994488 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3370,12 +3370,12 @@ void vfree(const void *addr) > > if (unlikely(vm->flags & VM_FLUSH_RESET_PERMS)) > vm_reset_perms(vm); > + if (vm->nr_pages && !(vm->flags & VM_MAP_PUT_PAGES)) > + mod_memcg_page_state(vm->pages[0], MEMCG_VMALLOC, -vm->nr_pages); > Could you please add a comment stating that the first page should be modified? Yes, the comment is clear, but git blame/log takes time. Reviewed-by: Uladzislau Rezki (Sony) -- Uladzislau Rezki