From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F28DC3600C for ; Thu, 3 Apr 2025 03:55:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6EB24280004; Wed, 2 Apr 2025 23:55:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 69AA0280001; Wed, 2 Apr 2025 23:55:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 53A61280004; Wed, 2 Apr 2025 23:55:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 361F9280001 for ; Wed, 2 Apr 2025 23:55:44 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 22F041411F3 for ; Thu, 3 Apr 2025 03:55:44 +0000 (UTC) X-FDA: 83291368608.21.694D21C Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by imf06.hostedemail.com (Postfix) with ESMTP id 27B5918000A for ; Thu, 3 Apr 2025 03:55:41 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fbknUDbG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743652542; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gnm05LZuH611EkrlJvpklr8mHTu9KPvCkeLM7JCWaWQ=; b=aoaeweylf9VhvdnlwX7q/hAmXXyeOTvULEgLeOu0QwBAex6HEwSA9lhoJb10BpFIfZkY4Y Y6S74KEYbE++lzXk2e1CBbgiGGRc44XYXcvcL49t/fVax6VkH0jLnKf5mX4EsSqFLVE+yy ZuBcKg7aikJU6uLvZ+CtDiFp0Q4QFyc= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=fbknUDbG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of vishal.moola@gmail.com designates 209.85.210.170 as permitted sender) smtp.mailfrom=vishal.moola@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743652542; a=rsa-sha256; cv=none; b=SjLo8Sy8QbA1s8yBYAD9HcGSHcugHJF+0Aq8cfkB5S1wnjozVXDLNJy11ewoK85CpD+jy6 enLcTD4UI0l9NUvvv8ukS2fOEt2vLCZAshJAWke72g05m6Lo/O8s3Epebuqk4asf/ehtbe YfC+HVOKGcAXiaRMNg6CuD2d4osG9B8= Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-7399838db7fso415646b3a.0 for ; Wed, 02 Apr 2025 20:55:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743652541; x=1744257341; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=gnm05LZuH611EkrlJvpklr8mHTu9KPvCkeLM7JCWaWQ=; b=fbknUDbGOe7QNQfeSvSks/DcnGM3kW7ZCDMgMLkue7SbGGE60IMCW2rsGq8Cs0TFC2 Njaju+4JsGIKG7uXKcrjZOZEUHA7FHS7IsXsSuW8fnGMIeewIFMOPYWaOMnDtxos1cJ6 HhJTOljAITlq+RMN7dw/oUaCxPzDSvLGi5XzIBtwXe+RLsY5W+U1P/S5dX7A9auOClry rpjzGtX3uacSCfBBjutLZA2MSDylwLVC7/khuwPY3IsH5+qvXEkX18A71JSVBKL3jlXE mPNPNo20GHqNmexjpIXfc7XZGhZbmUeeJm3/NO8PG7WwNGiBT6PIoXrdkVbM9gRLZm3+ E25Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743652541; x=1744257341; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gnm05LZuH611EkrlJvpklr8mHTu9KPvCkeLM7JCWaWQ=; b=F/PM47psoAl7DtuQJIWD3HiU/uWyCPvfE1a9KxHMjvvwM2PGMhdpDOn7IYXDELCt40 BRLrjqQtnLnhmIWXbcmiPcMvlt3Yx0txp1VjOtEkqndyOEzAWv6sG9+Yk+aES4GRtqgv 8S0HLWQzLaM8GTzWDw4lHJsA7kg/IGRAL8P2bDDBERmDjRyp+BlYVb6wwxy54TA8mv9d Ay33uN+KnFwtX4hpfI9PsV06wMXbU53HJkS8E8TvmcuZdRZrZOk5aHYRICOfjI1cuXKR n59RFIYWuQ4xixr0UJ05Be1mwYZxqEcJRE+JTw4lVD8YE1N0et32vmhIptD2gSTtns3I ympg== X-Forwarded-Encrypted: i=1; AJvYcCWfRFzGItUaVc503UesorRIEv4FH2mmbHNdp0s7cFC0F1hLVN/Qu8zDemLkkZBvW8Mle+HgfHSW1w==@kvack.org X-Gm-Message-State: AOJu0YxSI8nGhLpnEeaV+IIiJQFuam8GbwOiShjQ8d8kBnUcEfYmDC7/ KlgeTP7aGN5GEgVtweQ4HLrIcXZGmFg9eSCLy9Dr2AqpidTc9Ecl X-Gm-Gg: ASbGncs4I0Z91DtFy+zwqV/rQCUs9GU0+CtP2sENtOc07RQVP4DPQAAjSKbYDHXd6nJ /rdkRUDWFrIRLT6ye4mAfz3HAdHlTdUWw557Tn1hzWgg+jOuOdvbgI1rnO9hY6YJyOs3HgTblMl FGXTyY+cnEWdfcbypJaU8UHSRldTCSUiZpTsCmdIIbxrcWQws7Ih5wkkVDEUs+2RPEXkEZRY+6p 6HkIFjFMFODGEwQ2FAEmWtfQxVXNTcQ1Zv78OuOwDmTVRrTz+VuihWI579RSU1LuUNcnkmaQegj aCA7IZtaJUcGVNh2TCl9Nr1a1L2fa0TqehY5AblM3alVhS9FS5/8maGk3IedT3qlrQOKl5eHLfs B X-Google-Smtp-Source: AGHT+IH8j08BYrvuBj5K8jf301fuevctg92TJ2z4hWrPiNQj1/tkgwsx7przf7EmkNTKfAJAwn5FIQ== X-Received: by 2002:a05:6a00:8213:b0:734:26c6:26d3 with SMTP id d2e1a72fcca58-739d6370b90mr2648689b3a.5.1743652540727; Wed, 02 Apr 2025 20:55:40 -0700 (PDT) Received: from fedora (c-67-164-59-41.hsd1.ca.comcast.net. [67.164.59.41]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-739d9ea0985sm382195b3a.104.2025.04.02.20.55.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Apr 2025 20:55:40 -0700 (PDT) Date: Wed, 2 Apr 2025 20:55:37 -0700 From: "Vishal Moola (Oracle)" To: Ye Liu Cc: Matthew Wilcox , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Markus.Elfring@web.de, Ye Liu , Sidhartha Kumar , Anshuman Khandual Subject: Re: [PATCH v4] mm/page_alloc: Consolidate unlikely handling in page_expected_state Message-ID: References: <20250328014757.1212737-1-ye.liu@linux.dev> <8720c775-c0fb-4fbf-a1a8-409fef2b67ad@linux.dev> <6cd78595-f9d3-4f26-8ca3-d1a0bf4e8dff@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6cd78595-f9d3-4f26-8ca3-d1a0bf4e8dff@linux.dev> X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 27B5918000A X-Stat-Signature: kgax9619w6bh6mcihxgindfp8ixkfxza X-Rspam-User: X-HE-Tag: 1743652541-376514 X-HE-Meta: U2FsdGVkX1/dpbTJq5Rhq1rLHHY3/9AaycYAd4gjDAFGkyLvfSiYXaLVI1Ao7akAaZpSSOGXM2OZv4Rfn3YknQIP+uVwyhAlZy2yqle7DFR9NRNhVlU7bO0zou+WX7F+O2QtA/dRld1qaYyqCN8e2xWMtaPDUh2vsoj30Gtt+hQX4kiTr2AM9xRUQz1PUgvQNJnH0lyHZcLgjJE0eclWoG+1d7FMwhmtaGG37pCPqY/kl9TpFtK9k3X28k6eBhFguimNSRX8pFVdeWal02g31kFVf7hEwvol+e4Q4jYA4BcZ90t0uJ6JVgbIsiZNdUgAd0k7oVJxt242nHTNGJtcy4USkcZgNIVw9Z/HsXbb4wLT7j4VcPrId/kgfNKwQYE7J5IPWQvOd0DyN63xl515RS5pCvURjEYAC4f5QYuE/7ehBEY0bI2mQXk4nc7uJJeHMn51D/VvPj0hxzMg7jwRhJqIkzrRzu0O2ExQ4Aaxmam6r+J2iSQdnsA7UxN5ht49waoFbMQT+5eismhOPzqTgEcZX4olxGCajFBsJ/76ti79ftcai7qee1T97txaCgoRh9xjdqInvg+jXxKLW/RzybddFrcL7e0+d6xTOo+KFQ8wRgM/Ne3l66pzeAftnVOVa94fs/5A2DovyPqPJ8M+8QwX5L0wYCXYQmXjXS4niyafc38rDxBaLkRpJGTGVRBbK++SA3jxZ39HJTQwMIWqRifBq75TCYrh3qU5rRzLxg/fQDgtdRFd95g137I5F+9PsDx5a3f7gFRACdX7tuWLv/EAfjvLsI8M6HnepBt4fK0bbrrLc++AzLZpM0K9yGK9GcNJ/K0DGCQ+V6fKE9bdQT8KrZqTzRqJZErydQVUcT5B0pksnWH9G4l2qB1Hu4JR/ObeWyGy1DpnF3xQ7DpRZIcojgt45rluGoVbEQib7XaZWmy1pgjFsw6vD0rQ/MtPfGNjoEKG0qJKcI3Febf Uv6raLMe drmEZzRxybGa9h9QFSOOrqOkTnuK91cWfyHl13QW2unzE1t0PjBOyZUcoSkpwfZ81bEzmDaf/7zqcCti6TAoPU30z2q2mrY+QQfM23S2h00G5UpW+NQko1DTiyuHqPjio9i1p/gFVFDgU2drcyCk9S0hN64ayjDytMcLU7L0CiCydd4ACdsktQJQYSc6Yh8zurUQt3c5WjY3xPEVi5tAc6XUKdqMf2Tulfca39LUqxRFDymq9LtTk4GmH5a0hbtV9OKxKFk3YO4awqw01pgtkVU7+sFp00nkIpJKEVi3TVmlYUca59hsm6AyvWxPIRyhPwlKFsnvA6sRelgagLWyGzKwZ8bWY/wQEeAirvylgjw0RHVe9trF5CUw/F9HegfYmvN0s/OdcrcpDwn2mkmMhMAb5ECdD4UeUrYuZsay+exlELPWP07nW8Rcewk7XSO9FKcU1znmY4KSNe/4x6jgOCfMmEwLPRfJbzpQMrQdlX9fUrAE/opvQGjTJWg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 02, 2025 at 10:49:17AM +0800, Ye Liu wrote: > > 在 2025/3/31 23:59, Matthew Wilcox 写道: > > On Mon, Mar 31, 2025 at 08:08:01PM +0800, Ye Liu wrote: > >> 在 2025/3/28 22:29, Matthew Wilcox 写道: > >>> On Fri, Mar 28, 2025 at 09:47:57AM +0800, Ye Liu wrote: > >>>> Consolidate the handling of unlikely conditions in the > >>>> page_expected_state() function to reduce code duplication and improve > >>>> readability. > >>> I don't think this is an equivalent transformation. > >> Could you explain it in detail? > > page_expected_state() is called both at free and alloc. I think > > the correct behaviour on encountering a HWPOISON page should be > > different at alloc and free, don't you? > In the alloc process, this patch does not modify the code behavior. > Regarding the free process, the if (unlikely(PageHWPoison(page)) && !order) > code handles the case where order is 0. When order is not 0, it does not > matter if __ClearPageBuddy is used to process the last page of the compound > page, because page->flags &= ~PAGE_FLAGS_CHECK_AT_PREP; will also clear it. > Is that right?                                                              I believe a page's "Buddy" flag is stored in page->type, so maybe this won't do what you expect?